[sr-dev] git:master:f612c958: qos: Remove dlg_flag docs

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: f612c9583072eb22dc477c11d000541ab8b944ad URL: https://github.com/kamailio/kamailio/commit/f612c9583072eb22dc477c11d000541ab8b944ad Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:7e139951: sst: Remove dlg_flag docs

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 7e139951dc925f60bdd37ce699b38188cb223888 URL: https://github.com/kamailio/kamailio/commit/7e139951dc925f60bdd37ce699b38188cb223888 Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:fbe3aede: acc: Remove dlg_flag docs

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: fbe3aedee492ceb23ef53c967f1fe256a94d876f URL: https://github.com/kamailio/kamailio/commit/fbe3aedee492ceb23ef53c967f1fe256a94d876f Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:60a5ea45: mediaproxy: Remove dlg_flag and update docs

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 60a5ea45c5cc18b7074330da52ed1944cfbf3fbb URL: https://github.com/kamailio/kamailio/commit/60a5ea45c5cc18b7074330da52ed1944cfbf3fbb Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:435fa668: pua_dialoginfo: Remove dlg_flag docs

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 435fa668e1709df8c3025961fa7a38224483914e URL: https://github.com/kamailio/kamailio/commit/435fa668e1709df8c3025961fa7a38224483914e Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:30a362bd: nat_traversal: Remove dlg_flag and update docs

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 30a362bd5d91205135721bf8bce129e41cef9651 URL: https://github.com/kamailio/kamailio/commit/30a362bd5d91205135721bf8bce129e41cef9651 Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:81f96617: dialog/doc: Remove dlg_flag docs and suggest dlg_manage() instead.

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 81f966174275b715608f50aae606d40a791dd67c URL: https://github.com/kamailio/kamailio/commit/81f966174275b715608f50aae606d40a791dd67c Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] git:master:e60a0646: dialog: Drop support for dlg_flag parameter

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: e60a06469503c566d40437e69cf3374aad361251 URL: https://github.com/kamailio/kamailio/commit/e60a06469503c566d40437e69cf3374aad361251 Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T13:39:0

[sr-dev] Re: [kamailio/kamailio] dialog: Remove deprecated dlg_flag (PR #3961)

2024-09-16 Thread Henning Westerholt via sr-dev
Merged #3961 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3961#event-14271470724 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] dialog: Remove deprecated dlg_flag (PR #3961)

2024-09-16 Thread Henning Westerholt via sr-dev
Thanks, it was merged. Please send a short e-mail to sr-users list that the dialog flag was removed and list the affected modules. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3961#issuecomment-2352678977 You are receiving this because you are s

[sr-dev] git:master:45a93b46: sst: small white space change in docs after dialog flag removal (commit 7e139951dc)

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 45a93b46f0845867fdc1fd07a798eda6a9480816 URL: https://github.com/kamailio/kamailio/commit/45a93b46f0845867fdc1fd07a798eda6a9480816 Author: Henning Westerholt Committer: Henning Westerholt Date: 2024-09-16T11:45:11Z sst: small white space change in docs a

[sr-dev] git:master:faca8e7a: tm: Emit request event when cancel is called

2024-09-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: faca8e7a20255d90a4786fd4043005ead9dfc5df URL: https://github.com/kamailio/kamailio/commit/faca8e7a20255d90a4786fd4043005ead9dfc5df Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com> Committer: Henning Westerholt Date: 2024-09-16T15:21:5

[sr-dev] Re: [kamailio/kamailio] tm: Emit request event when tm.cancel is called (PR #3962)

2024-09-16 Thread Henning Westerholt via sr-dev
Merged #3962 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3962#event-14273053476 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

2024-09-16 Thread Henning Westerholt via sr-dev
@JuanPascual2 a PR was merged that should fix the issue you reported, linked above. Maybe you can test and report back if your problem is solved. If not, please re-open this issue. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3831#issuecommen

[sr-dev] Re: [kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

2024-09-16 Thread Henning Westerholt via sr-dev
Closed #3831 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3831#event-14273067492 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] Re: [kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)

2024-09-16 Thread Henning Westerholt via sr-dev
@sergey-safarov Any more comments on this PR after the latest improvements? If there are no more comments, it will be merged soon. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886#issuecomment-2352922632 You are receiving this because you are s

[sr-dev] Re: [kamailio/kamailio] Service crashed for IMS VoLTE MT call (Issue #3973)

2024-09-16 Thread Henning Westerholt via sr-dev
Thanks for the report. Does the crash happened only once, or do you observe it frequently? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3973#issuecomment-2352966968 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: Change in mailing list configuration related to DMARC spam filtering

2023-09-22 Thread Henning Westerholt via sr-dev
Hello, there has been no feedback regarding this change, so the setting was done some minutes ago. In case of unforeseen issues, just follow up on the sr-users lists for further discussions. Thanks, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-05 Thread Henning Westerholt via sr-dev
Many linux software packages uses a different behaviour, if one configuration file is found, its using this and no merge of the values is done. Bash profile loading does it differently indeed, but I would argue that kamctl is more like a tool. But if people depend on this current behaviour, fine

[sr-dev] Re: [kamailio/kamailio] kamctl: Source only one kamctlrc (PR #3594)

2023-10-05 Thread Henning Westerholt via sr-dev
Thank you -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3594#issuecomment-1750064416 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailin

[sr-dev] git:master:672b72d6: ims_qos: spelling fix for suspend_transaction docs, more sensible value for example docs

2023-10-16 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 672b72d65aba0b30fb363d60ab648f9705810ba7 URL: https://github.com/kamailio/kamailio/commit/672b72d65aba0b30fb363d60ab648f9705810ba7 Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-10-16T13:36:42Z ims_qos: spelling fix for suspend_trans

[sr-dev] Re: Kamailio module http_client - setting timeout in ms - new parameter ?

2023-10-17 Thread Henning Westerholt via sr-dev
Hello Nicolas, sounds good, an additional parameter while keeping the existing functionality for the existing timeout would work. Just create a pull request, then developers can review it and maybe some smaller adjustments could be done before a merge. Thanks, Henning -- Henning Westerholt -

[sr-dev] git:master:d2f0e1c3: topos: spelling fix in docs

2023-10-18 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: d2f0e1c31920e5b2b38ddbc823c6bc332fac86a5 URL: https://github.com/kamailio/kamailio/commit/d2f0e1c31920e5b2b38ddbc823c6bc332fac86a5 Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-10-18T07:55:59Z topos: spelling fix in docs --- Modif

[sr-dev] Re: [kamailio/kamailio] tls: Add and apply tls_openssl_clear_errors function. (PR #3607)

2023-10-19 Thread Henning Westerholt via sr-dev
I will later merge it manually -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3607#issuecomment-1770265188 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER)

[sr-dev] Re: Kamailio module http_client - setting timeout in ms - new parameter ?

2023-10-19 Thread Henning Westerholt via sr-dev
Hello, thank you, will take a look! Regarding backporting it to stable branch, this will be unfortunately not possible as it's a new functionality. Generally speaking, its not necessary to create additional PRs for stable branches, this is usually done with cherry-picking. Cheers, Henning --

[sr-dev] git:master:110ebbaf: tls: Add and apply tls_openssl_clear_errors function

2023-10-19 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 110ebbafadcc225f4e88749287f06ae29a6cfa2e URL: https://github.com/kamailio/kamailio/commit/110ebbafadcc225f4e88749287f06ae29a6cfa2e Author: Xenofon Karamanos Committer: Henning Westerholt Date: 2023-10-19T12:18:38Z tls: Add and apply tls_openssl_clear_err

[sr-dev] Re: [kamailio/kamailio] tls: Add and apply tls_openssl_clear_errors function. (PR #3607)

2023-10-19 Thread Henning Westerholt via sr-dev
Thanks, was merged manually, close it -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3607#issuecomment-1770847826 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamaili

[sr-dev] Re: [kamailio/kamailio] tls: Add and apply tls_openssl_clear_errors function. (PR #3607)

2023-10-19 Thread Henning Westerholt via sr-dev
Closed #3607. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3607#event-10710873842 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:7731fc3a: tls: add log line-break, increase buffer size (related to GH 3612 and GH 3607)

2023-10-24 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 7731fc3a1d793ffc7204e5c042a8bfc38d97e691 URL: https://github.com/kamailio/kamailio/commit/7731fc3a1d793ffc7204e5c042a8bfc38d97e691 Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-10-24T11:13:36Z tls: add log line-break, increase buffe

[sr-dev] Re: [kamailio/kamailio] cdp: Add and apply cdp_openssl_clear_errors function (PR #3612)

2023-10-24 Thread Henning Westerholt via sr-dev
Thanks, merged -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3612#issuecomment-161242 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development M

[sr-dev] Re: [kamailio/kamailio] cdp: Add and apply cdp_openssl_clear_errors function (PR #3612)

2023-10-24 Thread Henning Westerholt via sr-dev
Merged #3612 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3612#event-10757588772 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread Henning Westerholt via sr-dev
Thanks. The PR #3601 was merged already. I did looked to this change, but did not spotted why the error clearing added yesterday caused additional problems here? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#issuecomment-1778649178 You are

[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

2023-10-25 Thread Henning Westerholt via sr-dev
Thanks for the clarification. Lets wait until the CI tests are done and then it will be merged, if there are no more comments. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#issuecomment-1778682246 You are receiving this because you are subs

[sr-dev] Re: clang-formatting branch 5.7

2023-11-08 Thread Henning Westerholt via sr-dev
Hello, it will be a rather large change, but nothing in general against it. Maybe you can also discuss at that occasion about the stable branch 5.6, I think the last minor release was there in March 2023. The standard workflow of cherry-picking changes from the newer branch would then also not

[sr-dev] Re: Github actions for opened issues and pull requests

2023-11-08 Thread Henning Westerholt via sr-dev
Hello, we probably also might want to inform the users on the sr-users lists about that, as reporting bugs can be some work indeed. One question related to the process: If the stale label has been removed from a user or developer, will it automatically be added again from the bot after 6 weeks

[sr-dev] git:master:2b966644: kamailio.cfg: use xalert instead of old format for xlog, similar as done in other cfg places

2023-11-10 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 2b9666445a9fd31f75bf86b9924658daffb7ac85 URL: https://github.com/kamailio/kamailio/commit/2b9666445a9fd31f75bf86b9924658daffb7ac85 Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-11-10T14:01:47Z kamailio.cfg: use xalert instead of old

[sr-dev] Re: [kamailio/kamailio] branch_failure route in case 503 and dns failover (PR #3138)

2023-11-13 Thread Henning Westerholt via sr-dev
Thank you for providing the update. Right now there seems to be some conflicts probably after some refactoring changes that have been done. Could you maybe re-base your changes and then developers could have another close look. -- Reply to this email directly or view it on GitHub: https://githu

[sr-dev] Re: [kamailio/kamailio] topoh: uses socket IP when no mask_ip is defined (PR #3341)

2023-11-13 Thread Henning Westerholt via sr-dev
@henningw commented on this pull request. The stale flag got now removed from the bot. I think this is a useful addition, even if it changes the default behaviour of the module. For people want the previous behavior back, they can easily configure 127.0.0.1 manually. I did a quick review, just

[sr-dev] Re: [kamailio/kamailio] tcp_send_timeout not used on reused socket (Issue #3443)

2023-11-13 Thread Henning Westerholt via sr-dev
@schoberw your pull request got merged already some time ago. Is there something missing in this issue? Otherwise it should be closed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3443#issuecomment-1808139951 You are receiving this because you

[sr-dev] Re: [kamailio/kamailio] core: Add TCP_USER_TIMEOUT socket option on listening socket. (PR #3528)

2023-11-13 Thread Henning Westerholt via sr-dev
I think it qualifies as bug fix, so it should be also included in the stable branches. Why it was not included in 5.7.2 I don't know, it might be that the patch was not easy to backport. The stable branches has been now also adapted to the same clang format to make future backports way easier.

[sr-dev] Re: [kamailio/kamailio] janssonrpcc: No failover to lower prio server (Issue #3378)

2023-11-13 Thread Henning Westerholt via sr-dev
For the record, the bot aparently removes the stale flag automatically now when there is activity. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3378#issuecomment-1808149045 You are receiving this because you are subscribed to this thread. Me

[sr-dev] Re: [kamailio/kamailio] Lost selectors (#2705)

2023-11-13 Thread Henning Westerholt via sr-dev
@sergey-safarov the PR is still in draft status, not sure about the status. If it will be not completed for some reasons, just let us know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2705#issuecomment-1808159252 You are receiving this because

[sr-dev] Re: [kamailio/kamailio] kamailio 5.5 (commit 54c9df) SIGSEGV on run_dlg_callbacks (Issue #3106)

2023-11-13 Thread Henning Westerholt via sr-dev
Closed #3106 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3106#event-10941872309 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] Re: [kamailio/kamailio] kamailio 5.5 (commit 54c9df) SIGSEGV on run_dlg_callbacks (Issue #3106)

2023-11-13 Thread Henning Westerholt via sr-dev
The version 5.5. is now end of life. So if you only observed it once, you probably can try to update to 5.6.x or 5.7.x and see if it still happens. Close this issue for now. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3106#issuecomment-18081

[sr-dev] Re: [kamailio/kamailio] pua_json module not compatible with library libjson-c-dev 0.15.2 (Issue #3376)

2023-11-13 Thread Henning Westerholt via sr-dev
@eschmidbauer anything I could do? Did you managed to have a look to it maybe? Thank you. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3376#issuecomment-1808203915 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] dialplan: implement Iterative dialplan matching (#764)

2023-11-13 Thread Henning Westerholt via sr-dev
Closed #764 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/764#event-10942110162 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Develop

[sr-dev] Re: [kamailio/kamailio] dialplan: implement Iterative dialplan matching (#764)

2023-11-13 Thread Henning Westerholt via sr-dev
Last activity was here in 2018, close this one, can be re-opened if people want to continue work on it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/764#issuecomment-1808213719 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] pua_json module not compatible with library libjson-c-dev 0.15.2 (Issue #3376)

2023-11-13 Thread Henning Westerholt via sr-dev
Thanks for the fast reply. We observed some time ago on an environment, but right now I don't have the means to reproduce it, unfortunately. I just looked into the report from the time, and it was easy to reproduce by just installing e.g. 5.6.3 from github and using the libjson-c-dev version 0.1

[sr-dev] Re: [kamailio/kamailio] tm: memory leak in case dropping messages in local-request event route (PR #3403)

2023-11-14 Thread Henning Westerholt via sr-dev
@sem32 Any feedback to the earlier comment from Daniel? There is now also one conflict, would be great if you could rebase it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3403#issuecomment-1809799229 You are receiving this because you are subsc

[sr-dev] Re: [kamailio/kamailio] rtp_media_server module hard codes contact header to "rms" (Issue #3380)

2023-11-14 Thread Henning Westerholt via sr-dev
@jchavanton not sure if this is still work in progress - if you have something that @danieldonoghue can test, just let us know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3380#issuecomment-1809827802 You are receiving this because you are su

[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Henning Westerholt via sr-dev
Yes, I don't know why it fails for older commits. If its not related to changes you've done, it can be ignored. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3640#issuecomment-1810148053 You are receiving this because you are subscribed to this t

[sr-dev] Re: [kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)

2023-11-14 Thread Henning Westerholt via sr-dev
Thanks for the PR. Regarding your questions about the shared memory management, there is a function to re-alloc an existing memory segment for SHM and PKG pool [link](https://www.asipto.com/pub/kamailio-devel-guide/#c04shm_realloc) -- Reply to this email directly or view it on GitHub: https://g

[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: add AoR parameter to ipsec_destroy() (Issue #3570)

2023-11-15 Thread Henning Westerholt via sr-dev
@jbipre2 Could you maybe create a pull request with your patch suggestion? Then it could be reviewed from the developers and possible also integrated in the code base. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3570#issuecomment-1811984001

[sr-dev] Re: [kamailio/kamailio] dmq: Add find dmq node by IP (PR #3642)

2023-11-15 Thread Henning Westerholt via sr-dev
Thanks for the PR. @charlesrchance any feedback from your side regarding it? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3642#issuecomment-1812161330 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: add AoR parameter to ipsec_destroy() (Issue #3570)

2023-11-16 Thread Henning Westerholt via sr-dev
@jbipre2 not sure why this happens, just to verify - you forked the kamailio repository and then based the PR on that modification in your tree? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3570#issuecomment-1814439014 You are receiving this b

[sr-dev] Re: [kamailio/kamailio] Allow function set_advertised_address to receive variable as parameter (#2137)

2023-11-16 Thread Henning Westerholt via sr-dev
In the end this is a free collaboration project. If nobody has time or financial resources to support the development of this new feature, then its probably not that important. This particular request is from 4 years ago. If you need some support in creating a PR, please ask on our sr-dev mailin

[sr-dev] Re: [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-16 Thread Henning Westerholt via sr-dev
Thanks for the PR. It is indeed valid to send a BYE instead of an CANCEL in an early-dialog. Its a small patch, lets wait for some more feedback before merging it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3644#issuecomment-1814495245 You ar

[sr-dev] Re: [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-17 Thread Henning Westerholt via sr-dev
@miconda As I noticed that you are working on some other topos fixes right now, I don't wanted to simply merge it and cause problems with your work in progress fixes. Sorry if this caused confusion, I'll merge it of course as I was the one caused the regression. -- Reply to this email directly

[sr-dev] git:master:9898c586: topos: BYE sent by caller before call was connected was badly managed

2023-11-17 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 9898c586095bd75cd31f0ca383ba0a347bfc4891 URL: https://github.com/kamailio/kamailio/commit/9898c586095bd75cd31f0ca383ba0a347bfc4891 Author: frederic Committer: Henning Westerholt Date: 2023-11-17T14:48:35+01:00 topos: BYE sent by caller before call was co

[sr-dev] Re: [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-17 Thread Henning Westerholt via sr-dev
Thanks, merged -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3644#issuecomment-1816464758 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development M

[sr-dev] Re: [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-17 Thread Henning Westerholt via sr-dev
Merged #3644 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3644#event-10994680971 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: [kamailio/kamailio] core: add socket timestamp of received packets and keep track of receive delay (PR #3404)

2023-11-20 Thread Henning Westerholt via sr-dev
@nchaigne are you interested in working further on this? Right now its also in a conflict state due to other changes in the last weeks in the core. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3404#issuecomment-1819420317 You are receiving this

[sr-dev] Re: [kamailio/kamailio] Kamailio 5.6 do not execute "event_route[websocket:closed]" when tcp reset (Issue #3389)

2023-11-20 Thread Henning Westerholt via sr-dev
It looks like a regression in the mentioned commit. Are you still observing this issue? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3389#issuecomment-1819425499 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] core: add socket timestamp of received packets and keep track of receive delay (PR #3404)

2023-11-20 Thread Henning Westerholt via sr-dev
Closed #3404. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3404#event-11014461434 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] core: add socket timestamp of received packets and keep track of receive delay (PR #3404)

2023-11-20 Thread Henning Westerholt via sr-dev
Thanks for the feedback, closing it then. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3404#issuecomment-1819457522 You are receiving this because you are subscribed to this thread. Message ID: ___ Kam

[sr-dev] Re: [kamailio/kamailio] dialog: failover database loading behaviour in shared DB scenario, expiration of dialogs (#2080)

2023-11-20 Thread Henning Westerholt via sr-dev
We will investigate adding a skip_remote_socket for this scenario, default behavior will stay of course the same. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2080#issuecomment-1820370087 You are receiving this because you are subscribed to th

[sr-dev] Re: [kamailio/kamailio] core/cfg refactoring to free quicker the old values from inactive processes (#2094)

2023-11-20 Thread Henning Westerholt via sr-dev
We will investigate how complex it is to change/fix. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2094#issuecomment-1820370960 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] srdb1 lib: big integers should not be treated as negative ones (#2106)

2023-11-20 Thread Henning Westerholt via sr-dev
@miconda There have been several changes to core and also PVs (like AVP, XAVPs etc..) to use now internally long instead of int. Do you think it would make sense now to address this DB library topic? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull

[sr-dev] Re: [kamailio/kamailio] callout from event_route [tm:local-response] only occurs once (Issue #3064)

2023-11-20 Thread Henning Westerholt via sr-dev
Will have a look if it can be still reproduced. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3064#issuecomment-1820375528 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

2023-11-20 Thread Henning Westerholt via sr-dev
Will have a look, its probably not a large extension. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1820375934 You are receiving this because you are subscribed to this thread. Message ID: _

[sr-dev] Re: [kamailio/kamailio] dmq: Add find dmq node by IP (PR #3642)

2023-11-20 Thread Henning Westerholt via sr-dev
Merged #3642 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3642#event-11020606723 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] git:master:26ba1d9f: dmq: Add find dmq node by IP

2023-11-20 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 26ba1d9f42c77362de5ceb185d2fc1d1bb3f2d0c URL: https://github.com/kamailio/kamailio/commit/26ba1d9f42c77362de5ceb185d2fc1d1bb3f2d0c Author: Xenofon Karamanos Committer: Henning Westerholt Date: 2023-11-21T08:50:18+01:00 dmq: Add find dmq node by IP - Add

[sr-dev] Re: [kamailio/kamailio] dmq: Add find dmq node by IP (PR #3642)

2023-11-20 Thread Henning Westerholt via sr-dev
Thanks, merged -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3642#issuecomment-1820397962 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development M

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)

2023-11-20 Thread Henning Westerholt via sr-dev
@xkaraman could you have a look here? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968#issuecomment-1820398661 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamai

[sr-dev] Re: [kamailio/kamailio] Dialog DMQ sync: Timer needs fixing, firing on wrong node! (Issue #3656)

2023-11-23 Thread Henning Westerholt via sr-dev
Just for reference, there is also another issue with is related to the DMQ dialog handling #2080 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3656#issuecomment-1825244374 You are receiving this because you are subscribed to this thread. Messa

[sr-dev] Re: [kamailio/kamailio] nathelper: Add Max-Forwards to keep-alive (PR #3657)

2023-11-29 Thread Henning Westerholt via sr-dev
Thanks! I merged it manually due to clang-format issues. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3657#issuecomment-1833177050 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] nathelper: Add Max-Forwards to keep-alive (PR #3657)

2023-11-29 Thread Henning Westerholt via sr-dev
Closed #3657. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3657#event-11104692347 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] git:master:e1d9bec0: nathelper: add Max-Forwards headers which is mandatory for OPTIONS according to RFC 3261 (GH 3657)

2023-11-29 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: e1d9bec0e16727325330c822c21ae29237c7812a URL: https://github.com/kamailio/kamailio/commit/e1d9bec0e16727325330c822c21ae29237c7812a Author: Kristian Hogh Committer: Henning Westerholt Date: 2023-11-30T06:21:25Z nathelper: add Max-Forwards headers which is

[sr-dev] Re: [kamailio/kamailio] topos: add compatiblity for early in-dialog NOTIFY (PR #3627)

2023-12-06 Thread Henning Westerholt via sr-dev
@mauritsderuiter95 So just to summarize, the problems you've seen were due to an issue in your test setup? So its now fine and this PR could be closed? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3627#issuecomment-1842439805 You are receiving t

[sr-dev] Re: [kamailio/kamailio] pv: Add support to $hfl $hflc for Diversion header (PR #3651)

2023-12-06 Thread Henning Westerholt via sr-dev
Xenofon did a review of the modules that uses diversion (diversion, sipcapture). The diversion module was tested with the PR. The sipcapture does only seems to store the header content in a string database field, so it should be fine. Regarding the SIP msg cloning, I reviewed the sip_msg_clone.c

[sr-dev] Re: [kamailio/kamailio] TLS related crash in Kamailio 5.7.2 (double free) (Issue #3635)

2023-12-07 Thread Henning Westerholt via sr-dev
Just a generic note, it seems that some projects like haproxy don't recomment openssl 3.x for production use anymore, due to similar issues and also multiple major performance regressions with a performance of 1/10 to 1/4 comparing to openssl 1.1.x [link](https://github.com/haproxy/wiki/wiki/SS

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

2023-12-21 Thread Henning Westerholt via sr-dev
@xkaraman -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3234#issuecomment-1866055685 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mai

[sr-dev] git:master:8ed4165f: pv: remove redunant variable definition (warning: unused variable ??????innerIndex??????)

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 8ed4165fd3b0a331a4580894e2e7f83456b474fa URL: https://github.com/kamailio/kamailio/commit/8ed4165fd3b0a331a4580894e2e7f83456b474fa Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T11:23:51Z pv: remove redunant variable definition

[sr-dev] git:master:0547a4be: pv: remove another redunant variable definition (warning: unused variable ??????innerIndex??????)

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 0547a4becbc6a48fdc473cfd26cdeedfa2a9317d URL: https://github.com/kamailio/kamailio/commit/0547a4becbc6a48fdc473cfd26cdeedfa2a9317d Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T11:34:14Z pv: remove another redunant variable de

[sr-dev] git:master:b2045d55: pv: remove another redunant variable definition related commit 8ed4165fd3b0a33

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: b2045d559ed720789df80f543fc00923a07ada83 URL: https://github.com/kamailio/kamailio/commit/b2045d559ed720789df80f543fc00923a07ada83 Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T11:54:52Z pv: remove another redunant variable de

[sr-dev] git:master:4c939854: pua: fix possible copy/paste error, we should use reginfo_increase_version for reginfo events (GH #3234)

2023-12-21 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 4c93985437122706bc68143b2f96a9d7f35be16d URL: https://github.com/kamailio/kamailio/commit/4c93985437122706bc68143b2f96a9d7f35be16d Author: Henning Westerholt Committer: Henning Westerholt Date: 2023-12-21T16:10:25Z pua: fix possible copy/paste error, we

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)

2024-01-03 Thread Henning Westerholt via sr-dev
Should be fixed be (not yet merged) PR #3679 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968#issuecomment-1874986540 You are receiving this because you are subscribed to this thread. Message ID: __

[sr-dev] Re: [kamailio/kamailio] topos: add compatiblity for early in-dialog NOTIFY (PR #3627)

2024-01-03 Thread Henning Westerholt via sr-dev
@mauritsderuiter95 Did you managed to have another look to this topic regarding the test of git master? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3627#issuecomment-1874988230 You are receiving this because you are subscribed to this thread.

[sr-dev] Re: [kamailio/kamailio] tls: OpenSSL 3/1.1.1 is using shared ERR_STATE in all workers (Issue #3695)

2024-01-04 Thread Henning Westerholt via sr-dev
Thank you for the detailed analysis and also the POC. I remember from a custom module that I maintained for some year that using threads in Kamailio can bring some challenges due to its multi-process architectures. So its probably need to be discussed more thoroughly. The other option you mentio

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2024-01-05 Thread Henning Westerholt via sr-dev
Are there more comments or objections? If not I would merge it in the next days. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878352646 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)

2024-01-05 Thread Henning Westerholt via sr-dev
Thanks, yes this was basically the question also @xkaraman had earlier. The XAVPs will be used in the cfg script context later on I think. He will do another review. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878409382 You

[sr-dev] Re: [kamailio/kamailio] error on make cdp module (Issue #3701)

2024-01-08 Thread Henning Westerholt via sr-dev
Hello, thanks for the report. Which Kamailio version are you using exactly? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3701#issuecomment-1880534915 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] error on make cdp module (Issue #3701)

2024-01-08 Thread Henning Westerholt via sr-dev
Hm, this is quite old and not maintained anymore. If you are also using the "https://github.com/herlesupreeth/kamailio"; repository, you should probably address your question to this project. Please re-open if you can reproduce this with the current Kamailio git master or release branch 5.6/5.7

[sr-dev] Re: [kamailio/kamailio] error on make cdp module (Issue #3701)

2024-01-08 Thread Henning Westerholt via sr-dev
Closed #3701 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3701#event-11417359598 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] git:master:4df92312: parser/contact: Change addition order to the end of list

2024-01-08 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 4df92312166d8aad77ef0898d0a7c6ba40b7 URL: https://github.com/kamailio/kamailio/commit/4df92312166d8aad77ef0898d0a7c6ba40b7 Author: Xenofon Karamanos Committer: Henning Westerholt Date: 2024-01-08T15:55:43+01:00 parser/contact: Change addition ord

[sr-dev] Re: [kamailio/kamailio] parser/contact: Change addition order to the end of list (PR #3698)

2024-01-08 Thread Henning Westerholt via sr-dev
Thanks for the PR and the review, merged. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3698#issuecomment-1881168665 You are receiving this because you are subscribed to this thread. Message ID: ___ Kam

[sr-dev] Re: [kamailio/kamailio] parser/contact: Change addition order to the end of list (PR #3698)

2024-01-08 Thread Henning Westerholt via sr-dev
Merged #3698 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3698#event-11418690902 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] Re: git:master:52e82aa7: gcrypt: new module for crypto functions

2024-01-09 Thread Henning Westerholt via sr-dev
Hello, thanks for the interesting module addition. Just a quick note, as maybe developers are not aware of it, there are AES ECB and CBC cryptographic functions also available in the core: /kamailio/src/core/crypto$ egrep "ecb_|cbc_" rijndael.h void aes_ecb_encrypt(rijndael_ctx *ctx, u_int8_t *

[sr-dev] Re: [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)

2024-01-10 Thread Henning Westerholt via sr-dev
Thanks for the PR, merged -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3706#issuecomment-1884446598 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - De

[sr-dev] git:master:5a40d1ef: http_async_client: exit mod_init if tm is not loaded

2024-01-10 Thread Henning Westerholt via sr-dev
Module: kamailio Branch: master Commit: 5a40d1ef1b484c4fc437a3f0183a101241e80313 URL: https://github.com/kamailio/kamailio/commit/5a40d1ef1b484c4fc437a3f0183a101241e80313 Author: Federico Cabiddu Committer: Henning Westerholt Date: 2024-01-10T10:06:05+01:00 http_async_client: exit mod_init if

<    1   2   3   4   >