[sr-dev] git:master:8596e84b: sipdump: enable param now defaults to 0

2017-10-16 Thread Juha Heinanen
Module: kamailio Branch: master Commit: 8596e84b20f93cf73963b0c61e15dbb049b2276a URL: https://github.com/kamailio/kamailio/commit/8596e84b20f93cf73963b0c61e15dbb049b2276a Author: Juha Heinanen Committer: Juha Heinanen Date: 2017-10-16T12:40:43+03:00 sipdump: enable param now defaults to 0

[sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio

2017-10-16 Thread Juha Heinanen
Module: kamailio Branch: master Commit: 02074c81158b0927778e5f2daaae8da953580f2f URL: https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f Author: Juha Heinanen Committer: Juha Heinanen Date: 2017-10-16T12:41:48+03:00 Merge branch 'maste

Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio

2017-10-16 Thread Juha Heinanen
Victor Seva writes: > rebase before pushing Hard to remember. Is it possible to configure git so that it cancels push if local repo is not up to date? And even if had remembered to rebase, there would still be a cap between push during which a new commit could have occurred. Sound broken system

Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio

2017-10-16 Thread Juha Heinanen
Victor Seva writes: > rebase before pushing This is what I did (taken from shell history): 2060 emacs sipdump_mod.c 2061 git diff 2062 git commit -a 2063 git push 2064 git pull 2065 git push If I remember correctly, first git push failed with message asking to do pull first, which I

Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio

2017-10-16 Thread Juha Heinanen
Victor Seva writes: > git pull --rebase is the missing step there. I have set pull rebase in > ~/.gitconfig [0] > > [pull] > rebase = true > > so git pull --rebase is automatic for me Thanks, Juha ___ Kamailio (SER) - Development Mailing List sr-

[sr-dev] ul.add params

2017-10-18 Thread Juha Heinanen
I noticed that my ul.add command that works OK in 5.0 doesn't anymore work in 5.1. I get back to the xmlrpc query: faultString Not enough parameters or wrong format I then went and compared ul.add in 5.0 and 5.1 and noticed that in 5.1 it has added two optional params: received (optiona

Re: [sr-dev] ul.add params

2017-10-18 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > if you don't need to provide any of those parameters, then it should just > work by not having them in the command. OK, but it doesn't as the error message told. I should not have made any changes to that part of code from 5.0 to 5.1, but can recheck. -- Juha

Re: [sr-dev] ul.add params

2017-10-18 Thread Juha Heinanen
Juha Heinanen writes: > > if you don't need to provide any of those parameters, then it should just > > work by not having them in the command. Perhaps the error is due to this change: in 5.0: path value of the contact in 5.1: path value with the Path vector (use '

Re: [sr-dev] ul.add params

2017-10-18 Thread Juha Heinanen
Juha Heinanen writes: > Perhaps the error is due to this change: > > in 5.0: >path value of the contact > > in 5.1: > path value with the Path vector (use '0' or '.' if it should not be set) > > In my x

Re: [sr-dev] ul.add params

2017-10-18 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > I will look at it. If you can the log messages with debug=3 in the config > for processing the command, I will try to spot it quicly. Otherwise likely > to take 1-2 days until I get back to office and can reproduce myself. I have been busy, but tries by adding t

Re: [sr-dev] ul.add params

2017-10-18 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > It proved that the issue was in the rpc module implementation related to > handling of the optional specifier '*' when there were no more params > available. I pushed some patches to both jsonrpcs and xmlrpc, but I > could test only with jsonrpcs. Maybe you can g

[sr-dev] MAX_FLAG

2017-10-26 Thread Juha Heinanen
I'm running out of flags. Is there some good reason why flag_t is unsigned int instead of unsigned long? -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] acc to db has stopped working

2017-11-08 Thread Juha Heinanen
I noticed that accounting to database has stopped working. I don't know when it has happened, but at least I have the problem with master. My acc config is like this: modparam("acc", "db_url", "mysql://user:pass@127.0.0.1/sip_proxy_usage") modparam("acc", "db_flag", 7) modparam("acc", "failed_tr

[sr-dev] acc to db has stopped working

2017-11-08 Thread Juha Heinanen
Found the reason why db acc had stopped working: I had removed async_workers parameter. Looks like acc module does not insert anything if db_insert_mode=2 and there is no async workers. From README, I get the impression that it should be doing standard insert in that case: 6.28. db_insert_mode

Re: [sr-dev] acc to db has stopped working

2017-11-09 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > This needs to be fixed to match the docs, but I am not sure where it > would a better place, inside acc (test if async workers is not set and > do db sync insert, so a solution specific for acc) or do it inside db > mysql async insert function (a global behaviour

[sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Juha Heinanen
Currently add_contact_alias() works like this: Adds an “;alias=ip~port~transport” parameter to the contact URI containing either received ip, port, and transport protocol or those given as parameters. If called without parameters, “;alias” parameter is only added if received ip and port di

[sr-dev] add_contact_alias(0) is proto differs

2017-11-23 Thread Juha Heinanen
When adding transport proto check to add_contact_alias, I noticed that in receive_info struct proto is defined like this: char proto; and in sip_uri struct like this: unsigned short proto; /*!< from transport */ That does not look good to me. They should have the same type in b

Re: [sr-dev] rfc: clang format the code

2017-11-24 Thread Juha Heinanen
Am Donnerstag, 23. November 2017, 17:20:48 CET schrieb Daniel-Constantin Mierla: > it was discussed during the last irc devel meeting and everyone there > agreed to use clang-format to format the source code: > > - https://clang.llvm.org/docs/ClangFormat.html Does anyone have emacs c-mode-hoo

[sr-dev] git:master:93c81f53: modules/nathelper: check also transport protocol when determining

2017-11-24 Thread Juha Heinanen
Module: kamailio Branch: master Commit: 93c81f5326acc2aefaca01c347f79c972727d0bf URL: https://github.com/kamailio/kamailio/commit/93c81f5326acc2aefaca01c347f79c972727d0bf Author: Juha Heinanen Committer: Juha Heinanen Date: 2017-11-24T10:18:33+02:00 modules/nathelper: check also transport

[sr-dev] git:5.1:a7049edf: modules/nathelper: check also transport protocol when determining

2017-11-24 Thread Juha Heinanen
Module: kamailio Branch: 5.1 Commit: a7049edf431b8b8f8c80040b3b005c2e00d44eca URL: https://github.com/kamailio/kamailio/commit/a7049edf431b8b8f8c80040b3b005c2e00d44eca Author: Juha Heinanen Committer: Juha Heinanen Date: 2017-11-24T10:51:04+02:00 modules/nathelper: check also transport

[sr-dev] git:5.0:ae575733: modules/nathelper: check also transport protocol when determining

2017-11-24 Thread Juha Heinanen
Module: kamailio Branch: 5.0 Commit: ae575733a2761dba1232166f105eeb82781229e6 URL: https://github.com/kamailio/kamailio/commit/ae575733a2761dba1232166f105eeb82781229e6 Author: Juha Heinanen Committer: Juha Heinanen Date: 2017-11-24T10:58:57+02:00 modules/nathelper: check also transport

Re: [sr-dev] add_contact_alias(0) is proto differs

2017-11-25 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > I am fine to get such fields to the same type, just be careful to have > them aligned to 32bits from the start of the structure. I'm not qualified enough to do that kind change, since it may affect many parts of the core and many modules. -- Juha _

[sr-dev] .clang-format error on debian stretch

2017-11-26 Thread Juha Heinanen
clang-format command on debian stretch cannot hand kamailio .clang-format without errors. first one is this: YAML:58:21: error: unknown key 'IncludeIsMainRegex' IncludeIsMainRegex: '$' second is this: YAML:61:19: error: unknown key 'JavaScriptQuotes' JavaScriptQuotes: Leave is it OK if I clean

[sr-dev] git:master:f8d0a395: .clang-format: do not use bleeding edge keys

2017-11-27 Thread Juha Heinanen
Module: kamailio Branch: master Commit: f8d0a395074cd066a9f3df26debf14cf26e21a12 URL: https://github.com/kamailio/kamailio/commit/f8d0a395074cd066a9f3df26debf14cf26e21a12 Author: Juha Heinanen Committer: Juha Heinanen Date: 2017-11-28T00:22:36+02:00 .clang-format: do not use bleeding edge

[sr-dev] Multiple memleaks and segfauts in Kamailio v5.0.4

2017-12-03 Thread Juha Heinanen
M S writes: > 1. Calling sip_trace method without any arguements or with only one > arguement (duplicate uri) crashes kamailio with segfault. My K does not crash when I make call like this: setflag(TRACE); sip_trace(); but I have not defined as many vars as you, but only these: # -- si

[sr-dev] git:5.1:edbfa1ea: usrloc: partion column name can be set via modparam

2018-01-02 Thread Juha Heinanen
Øyvind Kolbu writes: > Module: kamailio > Branch: 5.1 > Commit: edbfa1eae2df1b932dff0bf5b7182ef09592a37d > URL: > https://github.com/kamailio/kamailio/commit/edbfa1eae2df1b932dff0bf5b7182ef09592a37d > > Author: Oyvind Kolbu > Committer: Øyvind Kolbu > Date: 2018-01-02T13:30:54+01:00 > > usr

[sr-dev] git:master:49949603: core/parser: more strict parsing of sip uri host

2018-01-09 Thread Juha Heinanen
Module: kamailio Branch: master Commit: 4994960324d5353222b3de08515bed07802ab7bc URL: https://github.com/kamailio/kamailio/commit/4994960324d5353222b3de08515bed07802ab7bc Author: Juha Heinanen Committer: Juha Heinanen Date: 2018-01-10T08:39:48+02:00 core/parser: more strict parsing of sip uri

[sr-dev] git:master:22e4167e: modules: readme files regenerated - tcpops ... [skip ci]

2018-01-15 Thread Juha Heinanen
Kamailio Dev writes: > +3.7. tcp_get_conid(hostport, pvname) > + > + Get the connection id based on target host:port. The connection id is > + set in the variable named by pvname parameter. So this means that there can never be more than one simultaneous tcp connection to a peer? -- Juha _

[sr-dev] git:master:f7347016: lcr: fixed checking if there is more uris available for next_gw

2018-02-05 Thread Juha Heinanen
Module: kamailio Branch: master Commit: f73470163b081f5c877dddff9c08e94073b0cc4b URL: https://github.com/kamailio/kamailio/commit/f73470163b081f5c877dddff9c08e94073b0cc4b Author: Juha Heinanen Committer: Juha Heinanen Date: 2018-02-05T21:58:04+02:00 lcr: fixed checking if there is more uris

[sr-dev] git:5.1:732a3153: lcr: fixed checking if there is more uris available for next_gw

2018-02-05 Thread Juha Heinanen
Module: kamailio Branch: 5.1 Commit: 732a3153a0a41d5f951fff85de607f0b46ae73da URL: https://github.com/kamailio/kamailio/commit/732a3153a0a41d5f951fff85de607f0b46ae73da Author: Juha Heinanen Committer: Juha Heinanen Date: 2018-02-05T22:05:58+02:00 lcr: fixed checking if there is more uris

[sr-dev] compiler warnings in master's siptrace

2018-02-19 Thread Juha Heinanen
CC (gcc) [M siptrace.so]siptrace.o siptrace.c: In function 'trace_onreply_out': siptrace.c:1227:6: warning: unused variable 'len' [-Wunused-variable] int len; ^~~ siptrace.c: In function 'siptrace_net_data_recv': siptrace.c:1477:1: warning: label 'error' defined but not used

[sr-dev] dmq server address question

2018-02-19 Thread Juha Heinanen
I tried to configure dmq module according to README, but got this kind of error: Feb 20 07:32:55 rautu /usr/bin/pres-serv[17983]: ERROR: dmq [dmq.c:228]: mod_init(): server_uri is not a socket the proxy is listening on In the config I have: modparam("dmq", "server_address", "sip:192.26.133.10:5

Re: [sr-dev] dmq server address question

2018-02-20 Thread Juha Heinanen
Charles Chance writes: > You’re not missing anything. DMQ only works with UDP. So no security over the Internet if TLS is not available? IPSec doesn't sound like a good idea. -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio

[sr-dev] git:5.8:1928af8f: core: set null-terminated char for modparam (backport from master)

2024-03-11 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: 5.8 Commit: 1928af8f90ebf02f610c0904bc3d24a00aaedb81 URL: https://github.com/kamailio/kamailio/commit/1928af8f90ebf02f610c0904bc3d24a00aaedb81 Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-03-12T07:54:50+02:00 core: set null-terminated char for modparam

[sr-dev] git:5.8:2122afae: Avoid 'qm_strnstr' defined but not used warning

2024-03-12 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: 5.8 Commit: 2122afae2a6604c0bc44a43ab37ee274a15a700a URL: https://github.com/kamailio/kamailio/commit/2122afae2a6604c0bc44a43ab37ee274a15a700a Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-03-12T22:16:23+02:00 Avoid 'qm_strnstr' defined bu

[sr-dev] git:master:0054b875: Avoid 'qm_strnstr' defined but not used warning

2024-03-12 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: master Commit: 0054b875045b4badfedd3e8424bf4772d6a9bc6b URL: https://github.com/kamailio/kamailio/commit/0054b875045b4badfedd3e8424bf4772d6a9bc6b Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-03-12T22:18:20+02:00 Avoid 'qm_strnstr' defined bu

[sr-dev] git:5.8:3a34b468: tm: add mandatory Max-Forwards header to local AC

2024-05-20 Thread Juha Heinanen via sr-dev
Module: kamailio Branch: 5.8 Commit: 3a34b468ad93904c507bd0fc7ef592b25321807f URL: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-05-20T19:54:45+03:00 tm: add mandatory Max-Forwards header to local

[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local AC (3a34b46)

2024-05-20 Thread Juha Heinanen via sr-dev
Victor Seva via sr-dev writes: > @juha-h please use ``cherry-pick -x `` when back-porting I used `git cherry-pick . This gets too complicated for me so better that I leave the git stuff to those who know. ___ Kamailio (SER) - Development Mailing List T

[sr-dev] git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla via sr-dev writes: > core: added tcp_check_timer parameter > > - set the check interval (in seconds) for tcp connections > - default 10 Does this need to be smaller than tcp_msg_read_timeout and tcp_msg_data_timeout in order for them to have effect? _

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
If so, how about defaulting to half of tcp_msg_read_timeout or tcp_msg_data_timeout whichever is smallest? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla writes: > Smaller is recommended for better accuracy. In order to make configuration simpler, how about having a dynamic default as I suggested? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-de

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-16 Thread Juha Heinanen via sr-dev
Daniel-Constantin Mierla writes: > > In order to make configuration simpler, how about having a dynamic default > > as I suggested? > > Default is half (hardcoded), but its own parameter gives more > flexibility for granularity -- one extra parameter is not adding much > complexity, imo, and case

[sr-dev] Re: git:master:1acede64: core: added tcp_check_timer parameter

2023-10-19 Thread Juha Heinanen via sr-dev
How about the diff below? Also, is there plan to backport ksr_tcp_msg_data_timeout, ksr_tcp_msg_read_timeout, and ksr_tcp_check_timer to 5.7, since they can help in protecting from DoS attacks that we have seen in the wild. -- Juha diff --git a/src/main.c b/src/main.c index 0fa2da6ec2..f3cddf8ba

<    1   2   3