[sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

…Status as the reply method. I've patched sipcapture.c and sipcapture.h to insert the actual SIP Status into a 'status' field on replies, and the Method extracted from the CSEQ into the 'method' field. This means when using this version of the module, you're tables must include a 'status'

Re: [sr-dev] sipcapture sip-status and method

+1 for the improvement initiative, I've found myself sometimes doing those kind of queries with SQL... :| David Villasmil wrote: > How do i do the pull request? > > I don't seem to be allowed to do commits to a branch i created locally Do you have your branch

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

core: core.kamailio.sig11.29831 log from pid that crash: ``` 2016-12-01T16:16:21.463526+01:00 spce proxy[29831]: DEBUG: [parser/msg_parser.c:595]: parse_msg(): SIP Request: 2016-12-01T16:16:21.463531+01:00 spce proxy[29831]: DEBUG: [parser/msg_parser.c:597]: parse_msg(): method:

Re: [sr-dev] [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

+1 - I'm all for cleaning up any technical debt and moving on with more normalized concept. :) Sincerely, Brandon Armstead On Thu, Dec 1, 2016 at 6:17 AM Daniel-Constantin Mierla wrote: > Hello, > > we started discussing about removing MI (so called management interface) >

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

The way it works now, on a reply the SIP Status is inserted into the "method" field, this isn't very nice as, if you're working with the table, you'd need to actually look into the cseq and break it into Sequence and Method to be able to do anything useful. Then you'd need to check if the

Re: [sr-dev] [kamailio/kamailio] Kamailio crashes when it receives a 404 reply to an INVITE originated after a 302. (#875)

My bad... didn't realize I didn't have dbg installed. Attached is the real backtrace. [backtrace-bt_full.txt](https://github.com/kamailio/kamailio/files/625062/backtrace-bt_full.txt) [backtrace-info_locals.txt](https://github.com/kamailio/kamailio/files/625063/backtrace-info_locals.txt) --

[sr-dev] git:master:95d5be47: sl: updated the used of old style logging macros

Module: kamailio Branch: master Commit: 95d5be47d77287320c0c4f40be834f636406ff85 URL: https://github.com/kamailio/kamailio/commit/95d5be47d77287320c0c4f40be834f636406ff85 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

Can you add in kamailio.cfg: ``` log_prefix="{$mt $hdr(CSeq) $ci} " ``` Then reproduce the issue and grab again the log messages with debug=3. It will help to track better the messages printed for invite or cancel. Would be a easy way that I can reproduce it easy without a need to build a

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

Please format the commit log messages according with the guidelines from: * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md You should be able to amend previous commit log message in your branch and repush. -- You are receiving this because you are subscribed to

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

I'm getting core per pid, no other core was generated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/872#issuecomment-264173705___

[sr-dev] VERY IMPORTANT: deciding when to remove the MI code

Hello, we started discussing about removing MI (so called management interface) for very long time, more or less since 2008. The RPC should remain the control interface, given its better structure for commands, parameters, etc ... MI is custom protocol using a line-oriented communication via fifo

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

it can be approved only if it can be activated by param i.e.: modparam("sipcapture", "version_schema", 5); anyway, I don't see why we should do this way and not just add a cseq_method field ? This will avoid a lot potential issues and give you same possibility for searches. -- You are

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

you are talking about "view", that can be easy changed in UI and API. but I try to make a pointer on back compatibility with already existing setups. In this case more effective way is to add a cseq_method field and add mod param for this feature. also 5 cents for the cseq's method. What

[sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#877)

- when using with Homer, on onreply_route it is not possible to get the source ip address sending the reply. This patch exposes pv $hep(src_ip), i.e.: onreply_route { ... xlog("[onreply_route] Source IP: $hep(src_ip)\n"); ... } You can view, comment on, or merge this pull

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#877)

@miconda already wrote you in your prevision push. Please follow the guide line: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md in your patch a lot changes that not needed. Please re-push. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [sr-dev] [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

Brandon Armstead writes: > +1 - I'm all for cleaning up any technical debt and moving on with more > normalized concept. I'm also in favor of getting rid on MI interface. I'm myself relying only on one MI command (pua_publish) for which an RPC command does not exist (or did not exist last time

Re: [sr-dev] [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

I would also say that at this point, almost all classical uses of MI that I know of can be met with RPC. If, in removing MI for v5.0, something should be overlooked, I trust any howls of protest will expediently illuminate any small things that fell through the cracks. The major functionality

Re: [sr-dev] [SR-Users] VERY IMPORTANT: deciding when to remove the MI code

> I would also say that at this point, almost all classical uses of MI > that I know of can be met with RPC. Alex, Did you see my message about pua_mi? Is there now rpc version of it that I have missed to notice? -- Juha ___ sr-dev mailing list

[sr-dev] git:master:f611b341: kamunix: small adjustments to the code

Module: kamailio Branch: master Commit: f611b34157d135936f1b1e5e83f891201426936f URL: https://github.com/kamailio/kamailio/commit/f611b34157d135936f1b1e5e83f891201426936f Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:f2181d7c: jsonrpc-s: implemented datagram transport

Module: kamailio Branch: master Commit: f2181d7cb461527747e2b720f2a37cfc987fa518 URL: https://github.com/kamailio/kamailio/commit/f2181d7cb461527747e2b720f2a37cfc987fa518 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:3b8d7950: kamctl: added rpcfifo control engine

Module: kamailio Branch: master Commit: 3b8d7950539be080770e3665ced07b491b9065bb URL: https://github.com/kamailio/kamailio/commit/3b8d7950539be080770e3665ced07b491b9065bb Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:9c94ffa8: kamunix: removed svn id from man page file

Module: kamailio Branch: master Commit: 9c94ffa85a2a55e746f6de505f8b47947bf7dbce URL: https://github.com/kamailio/kamailio/commit/9c94ffa85a2a55e746f6de505f8b47947bf7dbce Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] Kamailio crashes when it receives a 404 reply to an INVITE originated after a 302. (#875)

please give the core dump to debug this more. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/875#issuecomment-264157579___ sr-dev

[sr-dev] git:master:25946c10: tm: converted log messages to use macros with prefix

Module: kamailio Branch: master Commit: 25946c1094f495090d0c20c5e4ce84010555bcef URL: https://github.com/kamailio/kamailio/commit/25946c1094f495090d0c20c5e4ce84010555bcef Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:0527dea7: modules: readme files regenerated - acc_radius ...

Module: kamailio Branch: master Commit: 0527dea7022551f45990d5be88731c014a3d050a URL: https://github.com/kamailio/kamailio/commit/0527dea7022551f45990d5be88731c014a3d050a Author: Kamailio Dev Committer: Kamailio Dev Date:

Re: [sr-dev] [kamailio/kamailio] sending repeated CANCEL (#870)

Can you provide the pcap with the traffic for such case as well as the log messages from syslog with debug=3 in the kamailio.cfg? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

Maybe related to 8814e5fc2e44f792cbff8e83d184034b3d1ebc59 ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

> Are you doing async (suspend/continue) in the config? No > Back to the issue -- can it be reproduced Yes, We can -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

Are you doing async (suspend/continue) in the config? The 8814e5f is somehow related to that and I couldn't spot any relation with the report details of the issue. Back to the issue -- can it be reproduced, or it was like one time event? -- You are receiving this because you are subscribed to

[sr-dev] git:4.4:689d1274: tm: fix wrong CRLF position when building local request when reusing received buffer

Module: kamailio Branch: 4.4 Commit: 689d12741b86f101d00b1bcd348c3093f47d5158 URL: https://github.com/kamailio/kamailio/commit/689d12741b86f101d00b1bcd348c3093f47d5158 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:6db0e6b5: tm: fix wrong CRLF position when building local request when reusing received buffer

Module: kamailio Branch: master Commit: 6db0e6b5a0b8ef48250abd7bfaedd15fc4860ddd URL: https://github.com/kamailio/kamailio/commit/6db0e6b5a0b8ef48250abd7bfaedd15fc4860ddd Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:49d43d78: ss7ops: fix the dobook markdown and properly named the sections

Module: kamailio Branch: master Commit: 49d43d789eb0cecdfd60c5c43a0cf478e101cd47 URL: https://github.com/kamailio/kamailio/commit/49d43d789eb0cecdfd60c5c43a0cf478e101cd47 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

[sr-dev] git:master:4991821d: ss7ops: safety check before freeing allocated isup json buffer

Module: kamailio Branch: master Commit: 4991821daf9053cdd68957b18bfa23b8e906a00e URL: https://github.com/kamailio/kamailio/commit/4991821daf9053cdd68957b18bfa23b8e906a00e Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date:

Re: [sr-dev] [kamailio/kamailio] Kamailio crashes when it receives a 404 reply to an INVITE originated after a 302. (#875)

For a useful backtrace, you have to install debugging symbols, respectively kamailio dbg package. Then get the output from gdb for 'bt full' and 'info locals'. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] kamailio crashes on CANCEL due to empty reply_lumps (#872)

Are you getting only a corefile (dumping corefiles per pid should be enabled)? Because this one looks a bit clean and I want to be sure it is not because another core dump was done first and then overwriten. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [sr-dev] [kamailio/kamailio] Sipcapture fixes (#874)

thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/874#issuecomment-264166812___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:97492c52: Merge pull request #874 from grumvalski/sipcapture-fixes

Module: kamailio Branch: master Commit: 97492c5284b4fa5ec3eab123272abbdca67e3447 URL: https://github.com/kamailio/kamailio/commit/97492c5284b4fa5ec3eab123272abbdca67e3447 Author: Alexandr Dubovikov Committer: GitHub Date:

[sr-dev] git:master:1fbca28c: sipcapture: perform ntohs on src and dst port when payload is not SIP

Module: kamailio Branch: master Commit: 1fbca28c3a6e90ca478d152e116aca5e64780e9e URL: https://github.com/kamailio/kamailio/commit/1fbca28c3a6e90ca478d152e116aca5e64780e9e Author: Federico Cabiddu Committer: grumvalski Date:

Re: [sr-dev] [kamailio/kamailio] Sipcapture fixes (#874)

Merged #874. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/874#event-878409246___ sr-dev mailing list sr-dev@lists.sip-router.org

[sr-dev] git:master:969f4600: sipcapture: fix captid extraction from hep header for v3

Module: kamailio Branch: master Commit: 969f4600193139d95b5f876378e0c92d4eab9a7a URL: https://github.com/kamailio/kamailio/commit/969f4600193139d95b5f876378e0c92d4eab9a7a Author: Federico Cabiddu Committer: grumvalski Date:

Re: [sr-dev] [kamailio/kamailio] Sipcapture fixes (#874)

Should I adapt the fixes for 4.4? Being a fix I'd say yes. On Thu, Dec 1, 2016 at 1:55 PM, Alexandr Dubovikov wrote: > Merged #874 . > > — > You are receiving this because you authored the thread. > Reply to this email

Re: [sr-dev] [kamailio/kamailio] Sipcapture fixes (#874)

@grumvalski yes, please do cherry pick :-) thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/874#issuecomment-264167541___

[sr-dev] git:4.4:ad00a617: sipcapture: fix captid extraction from hep header for v3

Module: kamailio Branch: 4.4 Commit: ad00a617dec57073a1e9facc64cf3a64904c6592 URL: https://github.com/kamailio/kamailio/commit/ad00a617dec57073a1e9facc64cf3a64904c6592 Author: Federico Cabiddu Committer: grumvalski Date: 2016-12-01T14:15:34+01:00

[sr-dev] git:4.4:6291792e: sipcapture: perform ntohs on src and dst port when payload is not SIP

Module: kamailio Branch: 4.4 Commit: 6291792ecaee0bfb1855bf6ba4560e4d6af09f3e URL: https://github.com/kamailio/kamailio/commit/6291792ecaee0bfb1855bf6ba4560e4d6af09f3e Author: Federico Cabiddu Committer: grumvalski Date: 2016-12-01T14:04:45+01:00