Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-02 Thread David Villasmil
I've been looking into Homer's source code, and you are correct. It's easier doing it on the resultCtrl.js. In any case, this has been a good exercise for me in terms of working with Kamailio's source code, as I'm just a beginner. Thanks! -- You are receiving this because you are subscribed

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-02 Thread David Villasmil
Closed #876. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/876#event-879833214___ sr-dev mailing list sr-dev@lists.sip-router.org

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread Alexandr Dubovikov
you are talking about "view", that can be easy changed in UI and API. but I try to make a pointer on back compatibility with already existing setups. In this case more effective way is to add a cseq_method field and add mod param for this feature. also 5 cents for the cseq's method. What

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread David Villasmil
The way it works now, on a reply the SIP Status is inserted into the "method" field, this isn't very nice as, if you're working with the table, you'd need to actually look into the cseq and break it into Sequence and Method to be able to do anything useful. Then you'd need to check if the

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread Alexandr Dubovikov
it can be approved only if it can be activated by param i.e.: modparam("sipcapture", "version_schema", 5); anyway, I don't see why we should do this way and not just add a cseq_method field ? This will avoid a lot potential issues and give you same possibility for searches. -- You are

Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread Daniel-Constantin Mierla
Please format the commit log messages according with the guidelines from: * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md You should be able to amend previous commit log message in your branch and repush. -- You are receiving this because you are subscribed to

[sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread David Villasmil
…Status as the reply method. I've patched sipcapture.c and sipcapture.h to insert the actual SIP Status into a 'status' field on replies, and the Method extracted from the CSEQ into the 'method' field. This means when using this version of the module, you're tables must include a 'status'