Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-22 Thread Donald Carr
Ok, if you are saying your configuration fix would correctly work to check the address type at run-time, then I guess it would work. Otherwise, it would be all IPv6 or all IPv4. The fix you added that adds the brackets automatically at run-time for $siz is the best way actually, as then you

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-22 Thread Daniel-Constantin Mierla
I have installations with IPv6 since 2002 and they work. I don't get what you mean by "all existing installations will start working with IPv6 when they upgrade". And as I said, I use bare IPv6 in a lot of database tables that I query with sqlops or do HTTP API requests to external systems

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-22 Thread Donald Carr
Ok, sorry, I posted about the same time. We will use your fix using "siz" as the function name. Not sure there is any place you need it without brackets . . . Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-22 Thread Donald Carr
My opinion is it is better to just change the existing code, and all existing installations will start working with IPv6 when they upgrade. It is also much simpler. However, the following has been tested and also works to add a $ function that returns a correct IP string for IPv6: The

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-22 Thread Daniel-Constantin Mierla
The $si is one of the oldest variables, being in this form from beginning. Not sure about others, but I use it in many API requests or sqlops queries. Moreover, the definition of an IPv6 address is without brackets. The brackets are in the grammar of an address or URI. The $si won't change, I

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-22 Thread Daniel-Constantin Mierla
Btw, where is the issue with the null termination, the buffers seem to be defined with `max_address_len + 1`? Can you point in the source code (file path and line)? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-21 Thread David Wang
@miconda Thank you so much for your advice! We will try your suggestion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-21 Thread doncarr
@linuxmaniac, @miconda, I work with @davidxbwang I found the issue in modules/pv/pv_core.c. Function pv_get_srcip(). We should substitute the function ip_addr2strz() for ip_addr2a(). ip_addr2strz() correctly inserts the [] in the string when the address is IPv6. Also, I noticed that both of

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-17 Thread David Wang
@linuxmaniac Thank you. I corrected a format issue in my previous post. How to select "markdown format"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-16 Thread Victor Seva
@davidxbwang please use markdown format when pasting. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1136#issuecomment-309082579___

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-14 Thread David Wang
It seems like this issue is introduced by PCSCF when Soft Phone registers. The SIP Register from PCSCF to ICSCF is as below: REGISTER sip:ims.mnc001.mcc001.3gppnetwork.org SIP/2.0 Via: SIP/2.0/UDP [FC00:1235:1:0:0:0:0:45];branch=z9hG4bK9fc5.213ad03f122aa3a2b0840eae36a852ba.1 Via: SIP/2.0/UDP

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-06 Thread David Wang
Attached is wireshark log. Thank you! [ipv6 Jitsi parse error.pcapng.zip](https://github.com/kamailio/kamailio/files/1055707/ipv6.Jitsi.parse.error.pcapng.zip) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [sr-dev] [kamailio/kamailio] IPv6 parse_uri error (#1136)

2017-06-06 Thread David Wang
Thank you, miconda. We don't set r-uri value in pcscf.cfg, icscf.cfg or scscf.cfg. I will show more details below using the logs with Jitsi. I will omit SDP to save space. 1. When PCSCF received the Sip Invite from caller, the Sip headers look fine: INVITE