Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)
https://github.com/kamailio/kamailio/pull/1440 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1437#issuecomment-365724100___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)
Closed #1437. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1437#event-1472395932___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)
This makes sense, `acc` would remain the base building block for transaction callbacks and dialogs and other modules could implement transformation and export. I will do the necessary. Thank you for the review -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1437#issuecomment-365304948___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)
Thanks for the contribution! The option to enable features in a module with compile time defines is not preferred at all. We had in the past the RADIUS (and DIAMETER) accounting as part of acc and it was very inconvenient to maintain or package. The solution is to implement this as a new module on top of acc module, like `acc_json`, similar to `acc_radius`. In this way the module doesn't have compile time defines and can be packaged separately as part of jansson-modules pkg. It should be very easy to build the new module by reusing the code you have in this patch. I did the split of acc_radius module. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1437#issuecomment-365178761___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)
@jchavanton pushed 1 commit. 6b8fccd acc: Makefile test -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1437/files/8e15a950002718b40293298737096d1c6682813e..6b8fccd2fa076d350d4f45ad959326b59c471720 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)
I wonder what is the problem with the CI build, looking at the logs last thing done was building, and then nothing. ``` CC (clang) [M evrexec.so] evrexec_mod.o LD (clang) [M evrexec.so] evrexec.so ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1437#issuecomment-365078676___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
