Re: [sr-dev] [kamailio/kamailio] ndb_redis: adds support for sentinel (#1493)

2018-04-09 Thread Daniel-Constantin Mierla
Thanks for the additional details. I am merging it. For the future -- the README should no longer be regenerated even when changing in xml file, the reason is that various systems format the text file differently and it can result in a large diff (hard to backport if it is the case, etc.). Here

Re: [sr-dev] [kamailio/kamailio] ndb_redis: adds support for sentinel (#1493)

2018-04-09 Thread Daniel-Constantin Mierla
Merged #1493. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1493#event-1563494550___ Kamailio (SER) - Development Mailing List sr-dev@lis

Re: [sr-dev] [kamailio/kamailio] ndb_redis: adds support for sentinel (#1493)

2018-04-04 Thread Julien Ammous
After a quick look on redis website the sentinel is shipped with redis since 2.8 so I suppose this is the minimum required but if the sentinel options are not used the driver should work as before with any redis version. -- You are receiving this because you are subscribed to this thread. Reply

Re: [sr-dev] [kamailio/kamailio] ndb_redis: adds support for sentinel (#1493)

2018-04-04 Thread Daniel-Constantin Mierla
Thanks! One question before attempting to merge, does this require a specific version of redis server or redis client library? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1493#is