Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-17 Thread Kristian Høgh
I did some testing and it seems to work as expected. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/823#issuecomment-254218447___

Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-17 Thread Daniel-Constantin Mierla
Closed #823. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/823#event-825624409___ sr-dev mailing list sr-dev@lists.sip-router.org http://

Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-17 Thread Daniel-Constantin Mierla
I pushed the commit that combines this pull requests with some refactoring of the internals not to break the inter-module api as well as use straight flag meaning for domain lookup, instead of negative meaning. It should not affect use from config, but testing would be good to do to be sure. -

Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-17 Thread Kristian Høgh
I re-added use_domain module parameter and added option "u" to use domain on alias_db_lookup/alias_db_find. Will you fix the API, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/p

Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-16 Thread Kristian Høgh
@khoegh pushed 2 commits. 456941e alias_db: Re-add module parameter use_domain c1e36d0 alias_db: Add flag to use domain to alias_db_lookup/alias_db_find -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/823/files/

Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-14 Thread Kristian Høgh
Thanks, I will add use_domain again after the weekend. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/823#issuecomment-253763108___ sr-de

Re: [sr-dev] [kamailio/kamailio] Aliasdb (#823)

2016-10-14 Thread Daniel-Constantin Mierla
I would like to discuss more about the removal of use_domain parameter. It is a common parameter name across many modules and it is a easy way to turn on/off multi-domain support (even done also for alias_db in default kamailio.cfg). I would like a coherent solution, like either removing this mo