[SSSD] Re: [PATCH]: test ldap provider with TLS or SSL

2016-03-10 Thread Dan Lavu
Updated patch is attached, There were a few more packages I had to install to get CI running for Debian, should we had these to the makefile? root@sssd2:~# apt-get python-openssl dpkg -ihttp://ftp.us.debian.org/debian/pool/main/n/nss-wrapper/libnss-wrapper_1.1.2-1_amd64.deb dpkg

[SSSD] Re: [PATCH] Fix responders socket cleanup code

2016-03-10 Thread Simo Sorce
On Thu, 2016-03-10 at 21:04 -0500, Simo Sorce wrote: > The attached patch fixes #2973, > it's pretty straightforward. Same patch but fixed the typos in the commit message. Simo. -- Simo Sorce * Red Hat, Inc * New York From 93a636ca1283ca9b2bfbda55684eec43afff5c06 Mon Sep 17 00:00:00 2001 From:

[SSSD] [PATCH] Fix responders socket cleanup code

2016-03-10 Thread Simo Sorce
The attached patch fixes #2973, it's pretty straightforward. Simo. -- Simo Sorce * Red Hat, Inc * New York From 8cfba566ecddfc59e9c07236d28c5cdc62a316cd Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 10 Mar 2016 20:52:43 -0500 Subject: [PATCH] Responders: Fix client

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 20:02), Jakub Hrozek wrote: >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote: >> diff --git a/Makefile.am b/Makefile.am >> index d6eb0fc..f8111d0 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES = >>

[SSSD] Re: Tlog integration and packages

2016-03-10 Thread Nikolai Kondrashov
On 03/04/2016 12:54 PM, Jakub Hrozek wrote: I was playing with tlog yesterday and for the 'local configuration' I suggest we start small and avoid adding too many options, because we'd have to support them for a long time. Agreed. It seems to me that all the options except the user's shell

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-10 Thread Jakub Hrozek
On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote: > diff --git a/Makefile.am b/Makefile.am > index d6eb0fc..f8111d0 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES = > src/providers/ipa/ipa_hbac.exports > libipa_hbac_la_SOURCES = \

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Jakub Hrozek
On Wed, Mar 09, 2016 at 05:39:51PM +0100, Lukas Slebodnik wrote: > ehlo, > > I read log files from latest 1.13 today and it was a small challenge > due to missing line feed after some ldb messages. > > LS > From c9f7e99fb933706663948efc659937299ec54077 Mon Sep 17 00:00:00 2001 > From: Lukas

[SSSD] Re: UTIL: Fix warning misleading-indentation

2016-03-10 Thread Michal Židek
On 03/10/2016 02:44 PM, Lukas Slebodnik wrote: On (10/03/16 14:13), Michal Židek wrote: On 03/10/2016 01:03 PM, Pavel Březina wrote: On 03/07/2016 10:23 AM, Lukas Slebodnik wrote: ehlo, There are new warnings with gcc-6.0 LS Ack. Just for the record. Here is the CI:

[SSSD] Re: UTIL: Fix warning misleading-indentation

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 14:13), Michal Židek wrote: >On 03/10/2016 01:03 PM, Pavel Březina wrote: >>On 03/07/2016 10:23 AM, Lukas Slebodnik wrote: >>>ehlo, >>> >>>There are new warnings with gcc-6.0 >>> >>>LS >> >>Ack. > >Just for the record. > >Here is the CI:

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-10 Thread Pavel Březina
On 03/09/2016 05:49 PM, Petr Cech wrote: On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I will address some suggestions tomorrow. I am doing tests

[SSSD] Re: UTIL: Fix warning misleading-indentation

2016-03-10 Thread Michal Židek
On 03/10/2016 01:03 PM, Pavel Březina wrote: On 03/07/2016 10:23 AM, Lukas Slebodnik wrote: ehlo, There are new warnings with gcc-6.0 LS Ack. Just for the record. Here is the CI: http://sssd-ci.duckdns.org/logs/job/38/78/summary.html There are still some of these warnings left, but they

[SSSD] Re: [PATCH] BUILD: Simplify build of cwrap tests

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 13:39), Pavel Březina wrote: >On 03/07/2016 04:45 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Attached patch should speed up build a little bit. >>But the main purspose is to sipmplify src/tests/cwrap/Makefile.am >> >>LS > >Ack. > >http://sssd-ci.duckdns.org/logs/job/38/81/summary.html

[SSSD] Re: [PATCH] BUILD: Remove unused include directories

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 13:59), Pavel Březina wrote: >On 03/07/2016 10:37 AM, Lukas Slebodnik wrote: >>ehlo, >> >>We do not have the "include" directory in git >>and such directory is not generated by autotools in >>build directory either. >> >>LS > >Ack. >

[SSSD] Re: [PATCH] BUILD: Remove unused include directories

2016-03-10 Thread Pavel Březina
On 03/07/2016 10:37 AM, Lukas Slebodnik wrote: ehlo, We do not have the "include" directory in git and such directory is not generated by autotools in build directory either. LS Ack. http://sssd-ci.duckdns.org/logs/job/38/82/summary.html ___

[SSSD] Re: [PATCH] BUILD: Simplify build of cwrap tests

2016-03-10 Thread Pavel Březina
On 03/07/2016 04:45 PM, Lukas Slebodnik wrote: ehlo, Attached patch should speed up build a little bit. But the main purspose is to sipmplify src/tests/cwrap/Makefile.am LS Ack. http://sssd-ci.duckdns.org/logs/job/38/81/summary.html ___ sssd-devel

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 13:10), Pavel Březina wrote: >On 03/10/2016 01:05 PM, Lukas Slebodnik wrote: >>On (10/03/16 12:58), Pavel Březina wrote: >>>On 03/09/2016 05:39 PM, Lukas Slebodnik wrote: ehlo, I read log files from latest 1.13 today and it was a small challenge due to missing line

[SSSD] Re: [PATCH] PAM: Clarify man page for domains option

2016-03-10 Thread Pavel Březina
On 03/04/2016 10:18 AM, Pavel Reichl wrote: On 03/02/2016 01:08 PM, Pavel Březina wrote: On 02/09/2016 03:42 PM, Pavel Reichl wrote: On 02/09/2016 08:17 AM, Jakub Hrozek wrote: On Fri, Jan 29, 2016 at 02:30:36PM +0100, Pavel Reichl wrote: Hello, please see trivial patch attached. Thanks.

[SSSD] Re: [PATCH] Add a test for external group members resolution

2016-03-10 Thread Pavel Březina
On 03/05/2016 03:03 PM, Jakub Hrozek wrote: Hi, I was in a hurry when I submitted the patch for external group members, so I didn't add a test. Bad developer, no cookie. The attached patch adds a test for that code. Ack. ___ sssd-devel mailing list

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Pavel Březina
On 03/10/2016 01:05 PM, Lukas Slebodnik wrote: On (10/03/16 12:58), Pavel Březina wrote: On 03/09/2016 05:39 PM, Lukas Slebodnik wrote: ehlo, I read log files from latest 1.13 today and it was a small challenge due to missing line feed after some ldb messages. LS Can we check if new line

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 12:58), Pavel Březina wrote: >On 03/09/2016 05:39 PM, Lukas Slebodnik wrote: >>ehlo, >> >>I read log files from latest 1.13 today and it was a small challenge >>due to missing line feed after some ldb messages. >> >>LS > >Can we check if new line is present instead of always appending

[SSSD] Re: UTIL: Fix warning misleading-indentation

2016-03-10 Thread Pavel Březina
On 03/07/2016 10:23 AM, Lukas Slebodnik wrote: ehlo, There are new warnings with gcc-6.0 LS Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Pavel Březina
On 03/09/2016 05:39 PM, Lukas Slebodnik wrote: ehlo, I read log files from latest 1.13 today and it was a small challenge due to missing line feed after some ldb messages. LS Can we check if new line is present instead of always appending it? ___

[SSSD] Re: [PATCH] pam_sss: reorder pam_message array

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 12:54), Pavel Březina wrote: >On 03/08/2016 05:55 PM, Sumit Bose wrote: >>Hi, >> >>This patch fixes a 2FA issues observed with sudo. See commit message for >>details. >> >>bye, >>Sumit >> >> >>0001-pam_sss-reorder-pam_message-array.patch >> >> >> From

[SSSD] Re: [PATCH] pam_sss: reorder pam_message array

2016-03-10 Thread Pavel Březina
On 03/08/2016 05:55 PM, Sumit Bose wrote: Hi, This patch fixes a 2FA issues observed with sudo. See commit message for details. bye, Sumit 0001-pam_sss-reorder-pam_message-array.patch From 2c38adad7b527aceb4f9cb41c7d7b4c66d4580c9 Mon Sep 17 00:00:00 2001 From: Sumit Bose

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 11:54), Jakub Hrozek wrote: >Hi, > >attached are patches that in my opinion make libipa_hbac easier to use >by external projects like pam_hbac. > >[PATCH 1/4] libipa_hbac: Do not use C99 >- even though we use C99 in the deamon, pam_hbac needs to run on very > exotic platforms. I

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 11:41), Jakub Hrozek wrote: >On Thu, Mar 10, 2016 at 10:15:01AM +0100, Lukas Slebodnik wrote: >> On (09/03/16 18:47), Jakub Hrozek wrote: >> >On Wed, Mar 09, 2016 at 10:06:38AM +0100, Pavel Březina wrote: >> >> I'm fine either way. >> > >> >OK, see the attached patch. >> >> >From

[SSSD] [PATCH] libipa_hbac cleanup patches

2016-03-10 Thread Jakub Hrozek
Hi, attached are patches that in my opinion make libipa_hbac easier to use by external projects like pam_hbac. [PATCH 1/4] libipa_hbac: Do not use C99 - even though we use C99 in the deamon, pam_hbac needs to run on very exotic platforms. I don't think the code readability is decreased too

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-10 Thread Jakub Hrozek
On Thu, Mar 10, 2016 at 10:15:01AM +0100, Lukas Slebodnik wrote: > On (09/03/16 18:47), Jakub Hrozek wrote: > >On Wed, Mar 09, 2016 at 10:06:38AM +0100, Pavel Březina wrote: > >> I'm fine either way. > > > >OK, see the attached patch. > > >From ea49df6b0816845ec667392a170f4176e759731f Mon Sep 17

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-10 Thread Dan Lavu
Thanks Lukas, Turns out when I installed my image in openstack, I just named it Wheezy, I actually was running Jessie. Now that I have a little more time, going to try and wrap this up today, the SSL/TLS patch. Dan On 3/1/16 10:35 AM, Lukas Slebodnik wrote: dpkg --install *.deb

[SSSD] Re: [PATCH] memberof: Don't allocate on a NULL context

2016-03-10 Thread Lukas Slebodnik
On (09/03/16 18:36), Jakub Hrozek wrote: >On Wed, Mar 09, 2016 at 05:37:12PM +0100, Lukas Slebodnik wrote: >> On (09/03/16 15:21), Jakub Hrozek wrote: >> >On Wed, Mar 09, 2016 at 11:32:39AM +0100, Pavel Březina wrote: >> >> On 02/26/2016 02:03 PM, Jakub Hrozek wrote: >> >> >On Fri, Feb 26, 2016 at

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-10 Thread Lukas Slebodnik
On (09/03/16 18:47), Jakub Hrozek wrote: >On Wed, Mar 09, 2016 at 10:06:38AM +0100, Pavel Březina wrote: >> I'm fine either way. > >OK, see the attached patch. >From ea49df6b0816845ec667392a170f4176e759731f Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Wed, 9 Mar 2016