[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ @lslebodn: After some proper checking, seems that all "-Wunitialized" reports are false positives, so I've removed the patches from this series. I've added "Reviewed-by: " to t

[SSSD] [sssd PR#50][synchronized] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Author: fidencio Title: #50: [RFC] Use GNULIB's compiler warning code Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/50/head:pr50 git checkout pr50 From 185ff593a0e1010ad67914

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ Lukáš, I'm afraid you didn't understand how the usage of the GNULIB's compiler warnings is supposed to be. There are basically 3 essential files: - warnings.m4 - manywarnings.

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ Disabling Werror on RHEL6 will be just a matter of passing "--enable-werror=no" to configure. It should be **really** simple as long as we agree on doing that. About the extra

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code lslebodn commented: """ On (09/11/16 07:54), fidencio wrote: >@lslebodn, a way easier solution would be to disable -Werror when running CI >on RHEL6 than fixing those issues only caught there. Is ther

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ @lslebodn, a way easier solution would be to disable -Werror when running CI on RHEL6 than fixing those issues only caught there. Is there a simple way to do that? """ See th

[SSSD] [Q] t3222 sssd still showing ipa user after removed from last group

2016-11-09 Thread Petr Cech
Hi all, I came back to ticket #3222 "sssd still showing ipa user after removed from last group" [1]. And I have new knowledge. But I still do not see the light at the end of the tunnel. [1] https://fedorahosted.org/sssd/ticket/3222 I attached patch which enables some basic debug on using of

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code lslebodn commented: """ I do not think that initialisation to NULL is the best solution for Wunitialized on RHLE6. My experience is that such bugs occurs when there is some suspicious code in functi

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ http://sssd-ci.duckdns.org/logs/job/56/78/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/50#issuecomment-259444704

[SSSD] Re: about letting the responder choose the sysdb optimization level

2016-11-09 Thread Jakub Hrozek
On Wed, Nov 09, 2016 at 07:26:14AM -0500, Simo Sorce wrote: > On Wed, 2016-11-09 at 13:08 +0100, Sumit Bose wrote: > > On Tue, Nov 08, 2016 at 10:28:20AM +0100, Jakub Hrozek wrote: > > > Hi, > > > > > > I would like to ask for opinions about: > > > https://fedorahosted.org/sssd/ticket/3126 > > >

[SSSD] [Q] t3222 sssd still showing ipa user after removed from last group

2016-11-09 Thread Petr Cech
Hi all, I came back to ticket #3222 "sssd still showing ipa user after removed from last group" [1]. And I have new knowledge. But I still do not see the light at the end of the tunnel. [1] https://fedorahosted.org/sssd/ticket/3222 I attached patch which enables some basic debug on using of

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code fidencio commented: """ I've updated this series and I'm still waiting for CI to finish. A lot of warnings were just caught when building on RHEL6 machine (which passes gracefully now). I'll post the

[SSSD] [sssd PR#50][-Changes requested] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#50][synchronized] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/50 Author: fidencio Title: #50: [RFC] Use GNULIB's compiler warning code Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/50/head:pr50 git checkout pr50 From 185ff593a0e1010ad67914

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-11-09 Thread HouzuoGuo
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations HouzuoGuo commented: """ All right, `once` is now gone and mutex is now guarding cancellation state. """ See the full comment at https://github.com/SSSD/sssd/pull

[SSSD] Re: [PATCH] Unit tests for pam_sss using pam_wrapper (need help with CI..)

2016-11-09 Thread Lukas Slebodnik
On (11/10/16 19:56), Jakub Hrozek wrote: >On Tue, Sep 13, 2016 at 09:27:32AM +0200, Lukas Slebodnik wrote: >> On (09/08/16 10:18), Jakub Hrozek wrote: >> >On Tue, Aug 09, 2016 at 08:04:38AM +0200, Lukas Slebodnik wrote: >> >> On (09/05/16 10:07), Jakub Hrozek wrote: >> >> >On Wed, May 04, 2016 at 1

[SSSD] [sssd PR#46][synchronized] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-11-09 Thread HouzuoGuo
URL: https://github.com/SSSD/sssd/pull/46 Author: HouzuoGuo Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/46/head:pr46 git che

[SSSD] [sssd PR#72][closed] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Author: jhrozek Title: #72: Remove two unused methods from monitor's sbus interface Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/72/head:pr72 git checkout pr72 ___

[SSSD] [sssd PR#72][+Pushed] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Title: #72: Remove two unused methods from monitor's sbus interface Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#72][comment] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Title: #72: Remove two unused methods from monitor's sbus interface lslebodn commented: """ master: * fd25e68446ae86135489edb0823607b394f4ec40 * ab792150c97bd6eba1f8cd46653f41a0c64fd765 LS """ See the full comment at https://github.com/SSSD/sssd/pull

[SSSD] [sssd PR#72][comment] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Title: #72: Remove two unused methods from monitor's sbus interface lslebodn commented: """ Obvious ACK LS """ See the full comment at https://github.com/SSSD/sssd/pull/72#issuecomment-259404349 ___ sssd-de

[SSSD] Re: about letting the responder choose the sysdb optimization level

2016-11-09 Thread Simo Sorce
On Wed, 2016-11-09 at 13:08 +0100, Sumit Bose wrote: > On Tue, Nov 08, 2016 at 10:28:20AM +0100, Jakub Hrozek wrote: > > Hi, > > > > I would like to ask for opinions about: > > https://fedorahosted.org/sssd/ticket/3126 > > > > The basic idea is that the responder would choose what kind of optimiz

[SSSD] [sssd PR#65][comment] Fixing of nitpicks

2016-11-09 Thread celestian
URL: https://github.com/SSSD/sssd/pull/65 Title: #65: Fixing of nitpicks celestian commented: """ @pbrezina please, could you join discussion? How we can see we call function ```rdp_process_pending_call()``` on two places. And we are not consistent on return value checking. Is there reason for

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ Please do not reopen this PR anymore. Mails are much more suitable for such discussion. """ See the full comment at https://github.com/SSSD/sssd/pull/59#issuecomment-259401554

[SSSD] [sssd PR#59][closed] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59 __

[SSSD] Re: about letting the responder choose the sysdb optimization level

2016-11-09 Thread Sumit Bose
On Tue, Nov 08, 2016 at 10:28:20AM +0100, Jakub Hrozek wrote: > Hi, > > I would like to ask for opinions about: > https://fedorahosted.org/sssd/ticket/3126 > > The basic idea is that the responder would choose what kind of optimization > would the back end perform when saving the sysdb entries.

[SSSD] [sssd PR#77][opened] Qualify ghost users with RFC2307bis and ldap_nesting_level=0

2016-11-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/77 Author: jhrozek Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0 Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/77/head:pr77 git check

[SSSD] [sssd PR#59][reopened] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: reopened To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ Well, changing the ticket is a detail, we can change the ticket wording if necessary. I would like to get some comments on the lowercasing and if we want to go with the solutio

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ It looks like you forgot how to read. this PR is completely wrong. Subject and fix are wrong. Reopening does not help. """ See the full comment at https://github.com/SSSD/sssd

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ Please open new PR with correct ticket attached. You can inspire in https://fedorahosted.org/sssd/ticket/2275 """ See the full comment at https://github.com/SSSD/sssd/pull/59#is

[SSSD] [sssd PR#59][closed] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59 __

[SSSD] [sssd PR#76][closed] AD: Fix crash in AD subdomain reinit

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/76 Author: justin-stephenson Title: #76: AD: Fix crash in AD subdomain reinit Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/76/head:pr76 git checkout pr76

[SSSD] [sssd PR#76][comment] AD: Fix crash in AD subdomain reinit

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/76 Title: #76: AD: Fix crash in AD subdomain reinit lslebodn commented: """ Closing as duplicate of PR #74 """ See the full comment at https://github.com/SSSD/sssd/pull/76#issuecomment-259370381 ___ sssd-devel m

[SSSD] [sssd PR#76][+Rejected] AD: Fix crash in AD subdomain reinit

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/76 Title: #76: AD: Fix crash in AD subdomain reinit Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ Hi, I am reopening this ticket, because FreeIPA UQE have a test. Btw. I can change the patch to not lowercase the key in the first place (while creating the entry in the table)