URL: https://github.com/SSSD/sssd/pull/65
Title: #65: Fixing of nitpicks
celestian commented:
"""
@pbrezina please, could you join discussion?
How we can see we call function ```rdp_process_pending_call()``` on two places.
And we are not consistent on return value checking. Is there reason for this?
Or should we use one form for it?
```
$ git grep -n -a5 'rdp_process_pending_call' -- '*.c'
src/responder/common/data_provider/rdp_message.c-81- }
src/responder/common/data_provider/rdp_message.c-82-
src/responder/common/data_provider/rdp_message.c-83- return ret;
src/responder/common/data_provider/rdp_message.c-84-}
src/responder/common/data_provider/rdp_message.c-85-
src/responder/common/data_provider/rdp_message.c:86:static errno_t
rdp_process_pending_call(TALLOC_CTX *mem_ctx,
src/responder/common/data_provider/rdp_message.c-87-
DBusPendingCall *pending,
src/responder/common/data_provider/rdp_message.c-88-
DBusMessage **_reply)
src/responder/common/data_provider/rdp_message.c-89-{
src/responder/common/data_provider/rdp_message.c-90- DBusMessage *reply;
src/responder/common/data_provider/rdp_message.c-91- dbus_bool_t bret;
--
src/responder/common/data_provider/rdp_message.c-198- errno_t ret;
src/responder/common/data_provider/rdp_message.c-199-
src/responder/common/data_provider/rdp_message.c-200- req =
talloc_get_type(ptr, struct tevent_req);
src/responder/common/data_provider/rdp_message.c-201- state =
tevent_req_data(req, struct rdp_message_state);
src/responder/common/data_provider/rdp_message.c-202-
src/responder/common/data_provider/rdp_message.c:203: ret =
rdp_process_pending_call(state, pending, &state->reply);
src/responder/common/data_provider/rdp_message.c-204- if (ret != EOK) {
src/responder/common/data_provider/rdp_message.c-205-
tevent_req_error(req, ret);
src/responder/common/data_provider/rdp_message.c-206- return;
src/responder/common/data_provider/rdp_message.c-207- }
src/responder/common/data_provider/rdp_message.c-208-
--
src/responder/common/data_provider/rdp_message.c-266- dbus_bool_t dbret;
src/responder/common/data_provider/rdp_message.c-267- errno_t ret;
src/responder/common/data_provider/rdp_message.c-268-
src/responder/common/data_provider/rdp_message.c-269- sbus_req =
talloc_get_type(ptr, struct sbus_request);
src/responder/common/data_provider/rdp_message.c-270-
src/responder/common/data_provider/rdp_message.c:271: ret =
rdp_process_pending_call(sbus_req, pending, &reply);
src/responder/common/data_provider/rdp_message.c-272- if (reply == NULL) {
src/responder/common/data_provider/rdp_message.c-273- /* Something bad
happened. Just kill the request. */
src/responder/common/data_provider/rdp_message.c-274- ret = EIO;
src/responder/common/data_provider/rdp_message.c-275- goto done;
src/responder/common/data_provider/rdp_message.c-276- }
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/65#issuecomment-259402267
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
