[SSSD] Re: Group renaming issue when "id_provider = ldap" is set.

2017-01-10 Thread Jakub Hrozek
On Tue, Jan 10, 2017 at 10:12:37PM +0100, Fabiano Fidêncio wrote: > On Mon, Jan 9, 2017 at 11:51 AM, Jakub Hrozek wrote: > > On Sun, Jan 08, 2017 at 09:58:22PM +0100, Fabiano Fidêncio wrote: > >> I've been working on rhbz#1401241 > >>

[SSSD] Re: Group renaming issue when "id_provider = ldap" is set.

2017-01-10 Thread Fabiano Fidêncio
On Mon, Jan 9, 2017 at 11:51 AM, Jakub Hrozek wrote: > On Sun, Jan 08, 2017 at 09:58:22PM +0100, Fabiano Fidêncio wrote: >> I've been working on rhbz#1401241 >> (https://bugzilla.redhat.com/show_bug.cgi?id=1401241) and I'd like to >> clarify some doubts that showed up. >> >>

[SSSD] [sssd PR#119][opened] Remove unused Attr type

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/119 Author: lslebodn Title: #119: Remove unused Attr type Action: opened PR body: """ I noticed that there is an unused parameter in `users_get_send`. But it went deeper and more code could be removed. """ To pull the PR as Git branch: git remote add

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ Solved, thanks to @lslebodn . I will prepare new version. """ See the full comment at https://github.com/SSSD/sssd/pull/85#issuecomment-271581697

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler pbrezina commented: """ Looks good to me. """ See the full comment at https://github.com/SSSD/sssd/pull/107#issuecomment-271574259

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ WIP of tests added. I have issue with proeprly setting up test environment. This call (at line 95): ``` test_ctx->initgr_state->opts = mock_sdap_options_ldap(... ```

[SSSD] [sssd PR#85][synchronized] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-10 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Author: celestian Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/85/head:pr85 git checkout pr85 From

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ **UTIL: Add a generic inotify module** ```c if ((debug_level & SSSDBG_TRACE_LIBS) == false) { return; } ^ use DEBUG_IS_SET(SSSDBG_TRACE_LIBS) ``` **D-Bus

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler fidencio commented: """ Patchset updated! """ See the full comment at https://github.com/SSSD/sssd/pull/107#issuecomment-271558289

[SSSD] [sssd PR#107][-Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#107][synchronized] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Author: fidencio Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/107/head:pr107 git checkout pr107

[SSSD] [sssd PR#107][+Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] Re: [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread Fabiano Fidêncio
On Tue, Jan 10, 2017 at 10:13 AM, lslebodn wrote: > URL: https://github.com/SSSD/sssd/pull/107 > Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler > > lslebodn commented: > """ > Are there any objection to the proposed change?

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler lslebodn commented: """ Are there any objection to the proposed change? """ See the full comment at https://github.com/SSSD/sssd/pull/107#issuecomment-271523691

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler lslebodn commented: """ I checked the man page and API on linux and BSD and setpgrp has a different API on these platforms. But there is similar function which do the same and

[SSSD] [sssd PR#110][+Accepted] Add more DEBUG messages to help admins diagnose Kerberos login failures

2017-01-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#110][comment] Add more DEBUG messages to help admins diagnose Kerberos login failures

2017-01-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures sumit-bose commented: """ Thank you, this looks good imo. """ See the full comment at https://github.com/SSSD/sssd/pull/110#issuecomment-271518468

[SSSD] [sssd PR#113][closed] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/113 Author: jhrozek Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch

[SSSD] [sssd PR#113][+Pushed] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/113 Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To

[SSSD] [sssd PR#113][comment] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/113 Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. lslebodn commented: """ master: * 1a71eeb4d71f7f6d63edb4298d69b35a94edc020 sssd-1-14: *

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2017-01-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing lslebodn commented: """ On (07/01/17 08:28), Jakub Hrozek wrote: > >> On 6 Jan 2017, at 16:29, lslebodn wrote: >> >> On (06/01/17 05:52), Jakub Hrozek wrote: >> >This patch is