[SSSD] [sssd PR#153][comment] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache celestian commented: """ Thanks for comments. In my opinion it would be better to have the same value of dataExpireTimestamp only if we use sss_cache. The question is whether it could be

[SSSD] [sssd PR#153][comment] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache fidencio commented: """ @celestian, there are a few integration tests breaking after this patch: test_ts_cache.py::test_group_2307bis_update_same_modstamp FAILED

[SSSD] [sssd PR#153][+Changes requested] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#153][comment] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache lslebodn commented: """ On (13/02/17 06:26), celestian wrote: >When a group/users are invalidated from sss cache, the group/user >information in Domain (cache_LDAP.ldb) and timestamps

[SSSD] [sssd PR#154][opened] Confront caches first

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/154 Author: fidencio Title: #154: Confront caches first Action: opened PR body: """ This patch set has been written on top of PR#141, thus PR#141 should be merged before this one and also the following patches* are don't have to be reviewed as part of

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-13 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes justin-stephenson commented: """ The commit `DYNDNS: Update PTR record after non-fatal error` has been successfully tested and confirmed fixed by a SSSD user with RHEL 6 and RHEL7 systems. """ See the full comment

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ I hope this wouldn't be an issue because the inotify code doesn't call the callbacks immediately but with a tevent timer (by default immediate tevent action) which IIRC waits until the

[SSSD] [sssd PR#153][opened] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Action: opened PR body: """ When a group/users are invalidated from sss cache, the group/user information in Domain (cache_LDAP.ldb) and timestamps cache are

[SSSD] [sssd PR#153][synchronized] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From

[SSSD] [sssd PR#146][-Changes requested] Avoid running two instances of the same service

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ Hi, those changes looks good. I have just one comment -- what happens if both groups and passwd are being updated? I see that both will trigger files_account_info_finished(), this looks

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ The code looks good and manual tests went fine so far. Also the CI run passed: http://sssd-ci.duckdns.org/logs/job/62/55/summary.html """ See the full

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/62/54/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/106#issuecomment-279363621

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service fidencio commented: """ This patch set has been updated following @sumit-bose's suggestion. """ See the full comment at https://github.com/SSSD/sssd/pull/146#issuecomment-279358608

[SSSD] [sssd PR#146][synchronized] Avoid running two instances of the same service

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Author: fidencio Title: #146: Avoid running two instances of the same service Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/146/head:pr146 git checkout pr146 From

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ Patch set has been rebased on top of git master. """ See the full comment at https://github.com/SSSD/sssd/pull/141#issuecomment-279357985

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req to perform initgroups lookups

2017-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ With some help from Pavel, I fixed a memory issue we had in the sbus code. I think the patches are now ready for review. One thing I will submit separately is automatic enablement of the

[SSSD] [sssd PR#106][-Changes requested] Add a new "files" provider

2017-02-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org