URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider
jhrozek commented:
"""
I hope this wouldn't be an issue because the inotify code doesn't call the
callbacks immediately but with a tevent timer (by default immediate tevent
action) which IIRC waits until the next 'tick' of the event loop and therefore
serializes the callbacks. In the first version, I even had a single `updating`
variable instead of the two for passwd and group. But I agree having two
variables but having them both finish a single request makes little sense.
So maybe it would be more defensive to add something like:
```
if (id_ctx->updating_passwd == true || id_ctx->updating_groups== true) {
/* Another concurrent callback is still updating the db, don't finish the
request yet */
return;
}
```
to files_account_info_finished. Do you think that would help?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/106#issuecomment-279415804
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
