URL: https://github.com/SSSD/sssd/pull/158
Author: celestian
Title: #158: IPA_SUDO: Unused value fix
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/158/head:pr158
git checkout pr158
URL: https://github.com/SSSD/sssd/pull/158
Title: #158: IPA_SUDO: Unused value fix
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/158
Title: #158: IPA_SUDO: Unused value fix
lslebodn commented:
"""
On (16/02/17 08:36), fidencio wrote:
>Go for it.
>
master:
* 334029028e566fab3dce5ce4b1b53cc4809c21b8
LS
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/157
Author: lslebodn
Title: #157: intg: Fix python3 issues
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/157/head:pr157
git checkout pr157
From
URL: https://github.com/SSSD/sssd/pull/66
Title: #66: Minor Dynamic DNS fixes
justin-stephenson commented:
"""
Thank you @fidencio @jhrozek
2 different customers confirmed this fix addressed their issue with the PTR
record not being created. If you are not able to easily reproduce easily then
URL: https://github.com/SSSD/sssd/pull/66
Title: #66: Minor Dynamic DNS fixes
jhrozek commented:
"""
btw I'm fine with the patch, I was just waiting for Justin's confirmation that
the patch indeed helps the customer.
But please, go ahead and review it again, I only scrolled through the patch
URL: https://github.com/SSSD/sssd/pull/66
Title: #66: Minor Dynamic DNS fixes
fidencio commented:
"""
@justin-stephenson,
Firstly, sorry this patch has been waiting for so long.
I'll try to reproduce the issue and review it Tomorrow.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/158
Title: #158: IPA_SUDO: Unused value fix
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/158
Title: #158: IPA_SUDO: Unused value fix
fidencio commented:
"""
Go for it.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/158#issuecomment-280383805
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
@lslebodn: I'd say the changes mentioned by Martin (thanks for the review, btw)
could (and do make sense) be part of this "series" (not exactly the same patch
though, as already mentioned
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/156
Title: #156: FILES: Remove unnecessary check
fidencio commented:
"""
Go for it.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/156#issuecomment-280362258
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/156
Title: #156: FILES: Remove unnecessary check
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
Patch does make sense, but I don't feel comfortable ACKing python related stuff.
Martin Basti? :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/157#issuecomment-280361657
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
I take my comment back. I've submitted the wrong patch version to CI.
Yes, those tests are failing!
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
@celestian:
Just ran the ci on your patch and it passed without issues (apart from the
rhel6, but the failure is unrelated).
URL: https://github.com/SSSD/sssd/pull/158
Author: celestian
Title: #158: IPA_SUDO: Unused value fix
Action: opened
PR body:
"""
Unused value was immediately overwritten.
Resolves:
https://fedorahosted.org/sssd/ticket/3309
"""
To pull the PR as Git branch:
git remote add ghsssd
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
The are results from our CI
http://sssd-ci.duckdns.org/logs/job/62/90/summary.html
How we can see this patch fails on test_ts_cache.py integration test, namely:
URL: https://github.com/SSSD/sssd/pull/137
Title: #137: Initial pkinit support
sumit-bose commented:
"""
Hi Lukas,
thank you for your comments. I move get_pkinit_identity() out if the ifdef
block. For pam_check_user_done() I removed the assignment which should
hopefully silence the Coverity
URL: https://github.com/SSSD/sssd/pull/137
Author: sumit-bose
Title: #137: Initial pkinit support
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/137/head:pr137
git checkout pr137
From
URL: https://github.com/SSSD/sssd/pull/157
Author: lslebodn
Title: #157: intg: Fix python3 issues
Action: opened
PR body:
"""
Mostly string/bytes related issues.
It looks like my comments to the integration tests
were lost as part of review or due to rebases.
"""
To pull the PR as Git
URL: https://github.com/SSSD/sssd/pull/156
Author: lslebodn
Title: #156: FILES: Remove unnecessary check
Action: opened
PR body:
"""
"grp_iter->gr_mem" is an array of strings and not just a string.
We tried to compare first string to NULL (acctually '\0')
But after that we iterated over the
23 matches
Mail list logo
