[SSSD] [sssd PR#838][comment] FIPS140 compliant usage of PRNG

2019-07-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/838 Title: #838: FIPS140 compliant usage of PRNG alexey-tikhonov commented: """ Hi @pbrezina, Thanks for the review. > there are few minor coding style violations but otherwise I accept these > patches. I rebased patches and addressed all comments. >

[SSSD] [sssd PR#838][-Changes requested] FIPS140 compliant usage of PRNG

2019-07-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/838 Title: #838: FIPS140 compliant usage of PRNG Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#838][synchronized] FIPS140 compliant usage of PRNG

2019-07-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/838 Author: alexey-tikhonov Title: #838: FIPS140 compliant usage of PRNG Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/838/head:pr838 git checkout pr838 From

[SSSD] [sssd PR#846][comment] crypto: unconst key in sss_encrypt and sss_decrypt

2019-07-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/846 Title: #846: crypto: unconst key in sss_encrypt and sss_decrypt pbrezina commented: """ Sure, feel free to implement your suggestion. I agree with you. """ See the full comment at https://github.com/SSSD/sssd/pull/846#issuecomment-509214181

[SSSD] [sssd PR#846][+Changes requested] crypto: unconst key in sss_encrypt and sss_decrypt

2019-07-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/846 Title: #846: crypto: unconst key in sss_encrypt and sss_decrypt Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#846][comment] crypto: unconst key in sss_encrypt and sss_decrypt

2019-07-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/846 Title: #846: crypto: unconst key in sss_encrypt and sss_decrypt alexey-tikhonov commented: """ > The key parameter was made const in > [8aa0dfd](https://github.com/SSSD/sssd/commit/8aa0dfdf6e36fa90855c0f35a4dfa57139ad6504) > but it produces errors: >

[SSSD] [sssd PR#847][opened] systemd: add Restart=on-failure to sssd.service

2019-07-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/847 Author: pbrezina Title: #847: systemd: add Restart=on-failure to sssd.service Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/4040 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch

[SSSD] [sssd PR#636][synchronized] failover: tune up default timeouts

2019-07-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/636 Author: pbrezina Title: #636: failover: tune up default timeouts Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/636/head:pr636 git checkout pr636 From

[SSSD] [sssd PR#846][opened] crypto: unconst key in sss_encrypt and sss_decrypt

2019-07-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/846 Author: pbrezina Title: #846: crypto: unconst key in sss_encrypt and sss_decrypt Action: opened PR body: """ The key parameter was made const in 8aa0dfdf6e36fa90855c0f35a4dfa57139ad6504 but it produces errors: ``` CC

[SSSD] [sssd PR#838][comment] FIPS140 compliant usage of PRNG

2019-07-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/838 Title: #838: FIPS140 compliant usage of PRNG pbrezina commented: """ I agree with Alexey's statements, i.e. it is not necessary to fail in cases where security concerns are not relevant and just simple random number is needed (for example to compute