On Thu, Jul 23, 2015 at 09:54:49PM +0200, Jakub Hrozek wrote:
On Thu, Jul 23, 2015 at 01:47:19PM +0200, Pavel Reichl wrote:
I hope attached patch set addresses all concerns, thanks!
My issues were addressed and the code seems to work. Coverity didn't
find anything either.
ACK
* master:
On Thu, Jul 23, 2015 at 01:47:19PM +0200, Pavel Reichl wrote:
I hope attached patch set addresses all concerns, thanks!
My issues were addressed and the code seems to work. Coverity didn't
find anything either.
ACK
___
sssd-devel mailing list
I hope attached patch set addresses all concerns, thanks!
From 228335d2a51b5624f8500e69418e0df1355dc64c Mon Sep 17 00:00:00 2001
From: Pavel Reichl prei...@redhat.com
Date: Wed, 8 Jul 2015 09:01:24 -0400
Subject: [PATCH 1/5] DYNDNS: sss_iface_addr_list_get return ENOENT
If none of eligible
On Wed, Jul 22, 2015 at 07:54:43PM +0200, Pavel Reichl wrote:
Hello Jakub,
thanks for the comments, I have updated first 4th patches as you proposed,
but I need some clarification of the last patch, please see comments inline:
The first patches are mostly good now, I only have two minor
On 07/23/2015 11:42 AM, Jakub Hrozek wrote:
+static errno_t match_ip(const struct sockaddr *sa,
+const struct sockaddr *sb,
+bool *_res)
Don't you think it would be simpler to just return bool? For cases where
Yes, it would be simpler, but I
On Thu, Jul 23, 2015 at 12:28:33PM +0200, Pavel Reichl wrote:
On 07/23/2015 11:42 AM, Jakub Hrozek wrote:
+static errno_t match_ip(const struct sockaddr *sa,
+const struct sockaddr *sb,
+bool *_res)
Don't you think it would be simpler to just
Hello Jakub,
thanks for the comments, I have updated first 4th patches as you
proposed, but I need some clarification of the last patch, please see
comments inline:
This relates to the 3rd patch.
I think we can just remove this note. If you like, we can say
something like Choose the
On Wed, Jul 15, 2015 at 07:40:29PM +0200, Pavel Reichl wrote:
On 07/13/2015 12:04 PM, Martin Basti wrote:
On 10/07/15 20:16, Jakub Hrozek wrote:
On Fri, Jul 10, 2015 at 05:52:20PM +0200, Martin Basti wrote:
On 10/07/15 16:55, Jakub Hrozek wrote:
On Thu, Jul 09, 2015 at 01:17:44PM +0200,
On 16/07/15 11:01, Pavel Reichl wrote:
On 07/15/2015 07:40 PM, Pavel Reichl wrote:
[snip]
Hello, please see updated patch set, 1st and 2nd patch were not
changed (except for the ticket number in commit message).
I have tested the patches against IPA successfully, patches also work
On 07/15/2015 07:40 PM, Pavel Reichl wrote:
[snip]
Hello, please see updated patch set, 1st and 2nd patch were not
changed (except for the ticket number in commit message).
I have tested the patches against IPA successfully, patches also work
against AD but I'm seeing some problems in
On 07/13/2015 12:04 PM, Martin Basti wrote:
On 10/07/15 20:16, Jakub Hrozek wrote:
On Fri, Jul 10, 2015 at 05:52:20PM +0200, Martin Basti wrote:
On 10/07/15 16:55, Jakub Hrozek wrote:
On Thu, Jul 09, 2015 at 01:17:44PM +0200, Pavel Reichl wrote:
While reading #2558 I noticed that there is a
On 10/07/15 20:16, Jakub Hrozek wrote:
On Fri, Jul 10, 2015 at 05:52:20PM +0200, Martin Basti wrote:
On 10/07/15 16:55, Jakub Hrozek wrote:
On Thu, Jul 09, 2015 at 01:17:44PM +0200, Pavel Reichl wrote:
While reading #2558 I noticed that there is a further request relating to
these patches -
On 10/07/15 16:55, Jakub Hrozek wrote:
On Thu, Jul 09, 2015 at 01:17:44PM +0200, Pavel Reichl wrote:
While reading #2558 I noticed that there is a further request relating to
these patches - mbasti asks If there could be some mean how to send IPs of
all interfaces?
Is this a good idea in
On Fri, Jul 10, 2015 at 05:52:20PM +0200, Martin Basti wrote:
On 10/07/15 16:55, Jakub Hrozek wrote:
On Thu, Jul 09, 2015 at 01:17:44PM +0200, Pavel Reichl wrote:
While reading #2558 I noticed that there is a further request relating to
these patches - mbasti asks If there could be some mean
On Thu, Jul 09, 2015 at 01:17:44PM +0200, Pavel Reichl wrote:
While reading #2558 I noticed that there is a further request relating to
these patches - mbasti asks If there could be some mean how to send IPs of
all interfaces?
Is this a good idea in general?
I suppose I could implement it
On 07/09/2015 11:15 AM, Pavel Reichl wrote:
Hello,
please see attached patches.
1st patch adds return value ENOENT to sss_iface_addr_list_get() so I
can provide more concrete debug message for missing interface or if
interface is not suitable (missing IP address)
2nd patch:
* I introduced
Hello,
please see attached patches.
1st patch adds return value ENOENT to sss_iface_addr_list_get() so I can
provide more concrete debug message for missing interface or if
interface is not suitable (missing IP address)
2nd patch:
* I introduced new public function
17 matches
Mail list logo
