Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-05 Thread Jakub Hrozek
On Wed, Sep 03, 2014 at 04:59:41PM +0200, Pavel Reichl wrote: Thanks, ACK Pushed to master: 3ac7c4fe618ede980a4df8d90341ef1fd0f1f62f William, thank you very much for your contribution and the patience while the patch was being reviewed! ___

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-03 Thread Jan Cholasta
Dne 2.9.2014 v 16:37 Lukas Slebodnik napsal(a): On (02/09/14 16:21), Pavel Reichl wrote: On 09/01/2014 02:27 PM, Pavel Reichl wrote: On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-03 Thread Pavel Reichl
On 09/03/2014 02:40 PM, Jan Cholasta wrote: Dne 2.9.2014 v 16:37 Lukas Slebodnik napsal(a): On (02/09/14 16:21), Pavel Reichl wrote: On 09/01/2014 02:27 PM, Pavel Reichl wrote: On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-02 Thread Pavel Reichl
On 09/01/2014 02:27 PM, Pavel Reichl wrote: On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-02 Thread Lukas Slebodnik
On (02/09/14 16:21), Pavel Reichl wrote: On 09/01/2014 02:27 PM, Pavel Reichl wrote: On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub

Re: [SSSD] sss_cache flush ssh hosts list.

2014-09-01 Thread Pavel Reichl
On 08/29/2014 10:41 AM, Jan Cholasta wrote: Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-29 Thread Pavel Reichl
not sure they beat my arguments). - Original Message - From: Lukas Slebodnik lsleb...@redhat.com To: Development of the System Security Services Daemon sssd-devel@lists.fedorahosted.org Sent: Thursday, August 28, 2014 11:02:46 PM Subject: Re: [SSSD] sss_cache flush ssh hosts list. On (28/08/14

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-29 Thread Jakub Hrozek
On Fri, Aug 29, 2014 at 03:53:55AM -0400, Pavel Reichl wrote: Because Jakubs' message came after I started to write my message and I didn't read it till I posted mine. Still the discussion was between you and me, so it would be more discussion friendly if you at least had writen that you

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-29 Thread Jan Cholasta
Dne 28.8.2014 v 18:11 Pavel Reichl napsal(a): On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-28 Thread Lukas Slebodnik
On (28/08/14 18:11), Pavel Reichl wrote: On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that last patch, I

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-28 Thread Jakub Hrozek
On Thu, Aug 28, 2014 at 06:24:23PM +0200, Lukas Slebodnik wrote: This test ran OK this time, so I think you are right. I have some comments to the patch itself. I'm not personally fan of big patches like this one. Could you at least separate the man page changes to separate patch - so we

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-28 Thread Pavel Reichl
On 08/28/2014 06:24 PM, Lukas Slebodnik wrote: On (28/08/14 18:11), Pavel Reichl wrote: On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-28 Thread Lukas Slebodnik
On (28/08/14 18:37), Pavel Reichl wrote: On 08/28/2014 06:24 PM, Lukas Slebodnik wrote: On (28/08/14 18:11), Pavel Reichl wrote: On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-28 Thread Pavel Reichl
On 08/28/2014 07:13 PM, Lukas Slebodnik wrote: On (28/08/14 18:37), Pavel Reichl wrote: On 08/28/2014 06:24 PM, Lukas Slebodnik wrote: On (28/08/14 18:11), Pavel Reichl wrote: On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM,

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-28 Thread Lukas Slebodnik
On (28/08/14 19:19), Pavel Reichl wrote: On 08/28/2014 07:13 PM, Lukas Slebodnik wrote: On (28/08/14 18:37), Pavel Reichl wrote: On 08/28/2014 06:24 PM, Lukas Slebodnik wrote: On (28/08/14 18:11), Pavel Reichl wrote: On 08/25/2014 02:05 PM, Jan Cholasta wrote: Dne 4.8.2014 v 19:34 Pavel Reichl

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-25 Thread Jan Cholasta
Dne 4.8.2014 v 19:34 Pavel Reichl napsal(a): On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that last patch, I messed up and didn't include a .h file. Here is the fixed patch. This new patch

Re: [SSSD] sss_cache flush ssh hosts list.

2014-08-04 Thread Pavel Reichl
On 07/21/2014 02:08 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that last patch, I messed up and didn't include a .h file. Here is the fixed patch. This new patch seems to be based on some older version of

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Jan Cholasta
On 18.7.2014 06:41, William wrote: Ignore that last patch, I messed up and didn't include a .h file. Here is the fixed patch. This new patch seems to be based on some older version of the patch, it uses wrong option name, sysdb_update_ssh_host still has the confdb argument, etc. Fixed,

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Lukas Slebodnik
On (21/07/14 14:08), Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that last patch, I messed up and didn't include a .h file. Here is the fixed patch. This new patch seems to be based on some older version of the

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread William
On 21 Jul 2014, at 21:42, Lukas Slebodnik lsleb...@redhat.com wrote: On (21/07/14 14:08), Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that last patch, I messed up and didn't include a .h file. Here is the

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 11:35:31PM +0930, William wrote: On 21 Jul 2014, at 21:42, Lukas Slebodnik lsleb...@redhat.com wrote: On (21/07/14 14:08), Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta wrote: On 18.7.2014 06:41, William wrote: Ignore that

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-21 Thread William
On Mon, 2014-07-21 at 17:15 +0200, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 11:35:31PM +0930, William wrote: On 21 Jul 2014, at 21:42, Lukas Slebodnik lsleb...@redhat.com wrote: On (21/07/14 14:08), Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 01:55:20PM +0200, Jan Cholasta

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-17 Thread Jan Cholasta
On 16.7.2014 04:16, William wrote: On Tue, 2014-07-15 at 15:57 +0200, Jan Cholasta wrote: On 11.7.2014 03:35, William wrote: Thanks. Could you please rename the option to entry_cache_ssh_host_timeout, so that it's consistent with the rest of the cache timeout options? However, I can't

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-17 Thread William
Ignore that last patch, I messed up and didn't include a .h file. Here is the fixed patch. This new patch seems to be based on some older version of the patch, it uses wrong option name, sysdb_update_ssh_host still has the confdb argument, etc. Fixed, and fixed the documentation

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-16 Thread Lukas Slebodnik
On (16/07/14 11:46), William wrote: On Tue, 2014-07-15 at 15:57 +0200, Jan Cholasta wrote: On 11.7.2014 03:35, William wrote: Thanks. Could you please rename the option to entry_cache_ssh_host_timeout, so that it's consistent with the rest of the cache timeout options? However, I

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-16 Thread William
Doesn't appear to be related to anything I have changed I don't think ... You forgot to change usage of sysdb_store_ssh_host in sysdb_ssh-tests. tests cannot be compiled. (make check) CC src/tests/sysdb_ssh_tests-sysdb_ssh-tests.o src/tests/sysdb_ssh-tests.c:179:43: error:

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-15 Thread Jan Cholasta
On 11.7.2014 03:35, William wrote: Thanks. Could you please rename the option to entry_cache_ssh_host_timeout, so that it's consistent with the rest of the cache timeout options? However, I can't quite work out how to access confdb inside of ipa_hostid.c when it calls sysdb_store_ssh_host.

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-15 Thread Jakub Hrozek
On Tue, Jul 15, 2014 at 03:57:14PM +0200, Jan Cholasta wrote: I do see some dbus changes: src/responder/ifp/ifp_iface_generated.c As Pavel and Lukáš pointed out earlier, these changes should not be included in the patch, as they are a result of a bug in dbus codegen script. btw to solve

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-15 Thread William
On Tue, 2014-07-15 at 15:57 +0200, Jan Cholasta wrote: On 11.7.2014 03:35, William wrote: Thanks. Could you please rename the option to entry_cache_ssh_host_timeout, so that it's consistent with the rest of the cache timeout options? However, I can't quite work out how to access

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-15 Thread William
On Tue, 2014-07-15 at 15:57 +0200, Jan Cholasta wrote: On 11.7.2014 03:35, William wrote: Thanks. Could you please rename the option to entry_cache_ssh_host_timeout, so that it's consistent with the rest of the cache timeout options? However, I can't quite work out how to access

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-10 Thread William
Thanks. Could you please rename the option to entry_cache_ssh_host_timeout, so that it's consistent with the rest of the cache timeout options? However, I can't quite work out how to access confdb inside of ipa_hostid.c when it calls sysdb_store_ssh_host. I guess you can store the

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-07 Thread Jan Cholasta
On 29.6.2014 13:14, William wrote: On Sun, 2014-06-29 at 20:22 +0930, William wrote: On Tue, 2014-06-24 at 10:21 +0200, Jan Cholasta wrote: Hi, I'm terribly sorry for the late reply. That's okay, I understand how it can be. Could you add a sssd.conf option for the cache timeout? Done.

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-07 Thread Pavel Reichl
On Mon, 2014-07-07 at 13:41 +0200, Jan Cholasta wrote: On 29.6.2014 13:14, William wrote: On Sun, 2014-06-29 at 20:22 +0930, William wrote: On Tue, 2014-06-24 at 10:21 +0200, Jan Cholasta wrote: Hi, I'm terribly sorry for the late reply. That's okay, I understand how it can be.

Re: [SSSD] sss_cache flush ssh hosts list.

2014-07-07 Thread Lukas Slebodnik
On (07/07/14 13:41), Jan Cholasta wrote: On 29.6.2014 13:14, William wrote: On Sun, 2014-06-29 at 20:22 +0930, William wrote: On Tue, 2014-06-24 at 10:21 +0200, Jan Cholasta wrote: Hi, I'm terribly sorry for the late reply. That's okay, I understand how it can be. Could you add a sssd.conf

Re: [SSSD] sss_cache flush ssh hosts list.

2014-06-29 Thread William
On Tue, 2014-06-24 at 10:21 +0200, Jan Cholasta wrote: Hi, I'm terribly sorry for the late reply. That's okay, I understand how it can be. Could you add a sssd.conf option for the cache timeout? Done. The option exists, and I updated the man page (?), and the default option for this.

Re: [SSSD] sss_cache flush ssh hosts list.

2014-06-29 Thread William
On Sun, 2014-06-29 at 20:22 +0930, William wrote: On Tue, 2014-06-24 at 10:21 +0200, Jan Cholasta wrote: Hi, I'm terribly sorry for the late reply. That's okay, I understand how it can be. Could you add a sssd.conf option for the cache timeout? Done. The option exists, and I

Re: [SSSD] sss_cache flush ssh hosts list.

2014-06-24 Thread Jan Cholasta
Hi, I'm terribly sorry for the late reply. On 18.6.2014 17:53, Jakub Hrozek wrote: On Thu, May 29, 2014 at 10:30:26AM +0930, William wrote: On Mon, 2014-05-26 at 09:19 +0200, Jan Cholasta wrote: On 26.5.2014 03:41, William wrote: I'm afraid there is no right thing to call ATM, as there is

Re: [SSSD] sss_cache flush ssh hosts list.

2014-06-18 Thread Jakub Hrozek
On Thu, May 29, 2014 at 10:30:26AM +0930, William wrote: On Mon, 2014-05-26 at 09:19 +0200, Jan Cholasta wrote: On 26.5.2014 03:41, William wrote: I'm afraid there is no right thing to call ATM, as there is no support for cache invalidation in SSH host code. I guess you'll have to

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-28 Thread William
On Mon, 2014-05-26 at 09:19 +0200, Jan Cholasta wrote: On 26.5.2014 03:41, William wrote: I'm afraid there is no right thing to call ATM, as there is no support for cache invalidation in SSH host code. I guess you'll have to implement it yourself. Off the top of my head, you need to

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-26 Thread Jan Cholasta
On 26.5.2014 03:41, William wrote: I'm afraid there is no right thing to call ATM, as there is no support for cache invalidation in SSH host code. I guess you'll have to implement it yourself. Off the top of my head, you need to properly set SYSDB_CACHE_EXPIRE in sysdb_store_ssh_host, return

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-25 Thread William
I'm afraid there is no right thing to call ATM, as there is no support for cache invalidation in SSH host code. I guess you'll have to implement it yourself. Off the top of my head, you need to properly set SYSDB_CACHE_EXPIRE in sysdb_store_ssh_host, return only unexpired hosts in

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-13 Thread Jan Cholasta
On 8.5.2014 02:53, William Brown wrote: The way I read the SSH responder, calling sysdb_update_ssh_known_host_expire() would be the right thing to do, but I wonder if that would be enough or whether we'd need to call out to the ssh responder to force writing out a new hosts file. What you

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-07 Thread William Brown
The way I read the SSH responder, calling sysdb_update_ssh_known_host_expire() would be the right thing to do, but I wonder if that would be enough or whether we'd need to call out to the ssh responder to force writing out a new hosts file. What you want to do is remove the entry from

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-06 Thread Jan Cholasta
On 2.5.2014 13:57, Jakub Hrozek wrote: On Thu, May 01, 2014 at 01:35:49PM +0930, William Brown wrote: Hi, I have been working on sssd being able to flush hosts from it's cache. Here is an initial patch to add the options to the cli of sss_cache. I have noticed that there are some methods

Re: [SSSD] sss_cache flush ssh hosts list.

2014-05-02 Thread Jakub Hrozek
On Thu, May 01, 2014 at 01:35:49PM +0930, William Brown wrote: Hi, I have been working on sssd being able to flush hosts from it's cache. Here is an initial patch to add the options to the cli of sss_cache. I have noticed that there are some methods already in src/db/sysdb_ssh.c like

[SSSD] sss_cache flush ssh hosts list.

2014-04-30 Thread William Brown
Hi, I have been working on sssd being able to flush hosts from it's cache. Here is an initial patch to add the options to the cli of sss_cache. I have noticed that there are some methods already in src/db/sysdb_ssh.c like sysdb_update_ssh_known_host_expire: Does that seem like the right