Re: [SSSD] [PATCH] Allow arbitrary-length PAM messages

2010-03-25 Thread Sumit Bose
On Wed, Mar 24, 2010 at 06:56:10AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/2010 06:49 AM, Stephen Gallagher wrote: On 03/23/2010 04:51 PM, Simo Sorce wrote: On Tue, 23 Mar 2010 16:38:57 -0400 Stephen Gallagher sgall...@redhat.com wrote:

Re: [SSSD] [PATCH] Allow arbitrary-length PAM messages

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 09:56 AM, Sumit Bose wrote: NACK. Please consider the following two comments: - can you call free(user_msg) just after do_pam_conversation() to avoid to have it two times? - can you make buf in read_pipe_handler() a

Re: [SSSD] [PATCH] Allow arbitrary-length PAM messages

2010-03-24 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/2010 06:49 AM, Stephen Gallagher wrote: On 03/23/2010 04:51 PM, Simo Sorce wrote: On Tue, 23 Mar 2010 16:38:57 -0400 Stephen Gallagher sgall...@redhat.com wrote: +tempbuf = talloc_realloc(state, state-buf, uint8_t, +

Re: [SSSD] [PATCH] Allow arbitrary-length PAM messages

2010-03-23 Thread Simo Sorce
On Tue, 23 Mar 2010 16:38:57 -0400 Stephen Gallagher sgall...@redhat.com wrote: +tempbuf = talloc_realloc(state, state-buf, uint8_t, + state-len + size); +if(!tempbuf) { +tevent_req_error(req, ENOMEM); return;