On Tue, 23 Mar 2010 16:38:57 -0400
Stephen Gallagher <sgall...@redhat.com> wrote:
> + tempbuf = talloc_realloc(state, state->buf, uint8_t,
> + state->len + size);
> + if(!tempbuf) {
> + tevent_req_error(req, ENOMEM);
> return;
> }
> + state->buf = talloc_steal(state, tempbuf);
Why the use of tempbuf ?
you can simply do
state->buf = talloc_realloc(state, state->buf, ...
if state->buf is null you abort the whole operation anyway.
The talloc_steal is also useless given that talloc_realloc doesn't
change the parent.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
