Re: [SSSD] [PATCH] SDAP: remove duplicated code

2014-07-22 Thread Pavel Reichl
On 07/21/2014 11:57 PM, Lukas Slebodnik wrote: On (21/07/14 22:13), Pavel Reichl wrote: Hello, please see attached trivial patch. Thanks, Pavel Reichl From 649762a6433066464ae22fe8a3399f0fe4b0d24c Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date: Mon, 21 Jul 2014

Re: [SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-22 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 02:10:34PM +0200, Pavel Březina wrote: On 07/21/2014 12:07 PM, Jakub Hrozek wrote: On Fri, Jul 18, 2014 at 01:15:25PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2385 The code looks good, but needs to be rebased on top of PavelR's patches I just

Re: [SSSD] [PATCH] SDAP: remove duplicated code

2014-07-22 Thread Lukas Slebodnik
On (22/07/14 08:48), Pavel Reichl wrote: On 07/21/2014 11:57 PM, Lukas Slebodnik wrote: On (21/07/14 22:13), Pavel Reichl wrote: Hello, please see attached trivial patch. Thanks, Pavel Reichl From e1097b44fe561909a56e1c9c646fc6eb59b89764 Mon Sep 17 00:00:00 2001 From: Pavel Reichl

Re: [SSSD] [PATCH] UTIL: rename find_subdomain_by_sid

2014-07-22 Thread Jakub Hrozek
On Mon, Jul 21, 2014 at 02:23:57PM +0200, Pavel Reichl wrote: On 07/21/2014 12:03 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 09:30:06AM +0200, Pavel Reichl wrote: On 07/20/2014 10:06 PM, Jakub Hrozek wrote: On Sun, Jul 20, 2014 at 09:49:46PM +0200, Jakub Hrozek wrote: ACK I take the

Re: [SSSD] [PATCH] UTIL: rename find_subdomain_by_sid

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 09:39:46AM +0200, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 02:23:57PM +0200, Pavel Reichl wrote: On 07/21/2014 12:03 PM, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 09:30:06AM +0200, Pavel Reichl wrote: On 07/20/2014 10:06 PM, Jakub Hrozek wrote: On Sun, Jul

Re: [SSSD] [PATCH] SDAP: remove duplicated code

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 09:33:36AM +0200, Lukas Slebodnik wrote: On (22/07/14 08:48), Pavel Reichl wrote: On 07/21/2014 11:57 PM, Lukas Slebodnik wrote: On (21/07/14 22:13), Pavel Reichl wrote: Hello, please see attached trivial patch. Thanks, Pavel Reichl From

Re: [SSSD] [PATCH] AD: Cache gpo version; only download policy files if version changes

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 03:13:58AM -0400, Yassir Elley wrote: Hi Jakub, I agree with all of your comments so far and have attached revised patches to this email. I split the original patch into two patches, as you suggested, and I addressed your review comments in the revised patches.

[SSSD] [PATCH] TESTS: Add unit tests for the GPO interface

2014-07-22 Thread Jakub Hrozek
Hi, I used the attached patch to exercise Yassir's new additions to the sysdb API. From 5bd6a51b595872f0a2a7fc9b28a49c1bff5b32ee Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Mon, 21 Jul 2014 20:31:15 +0200 Subject: [PATCH] TESTS: Add unit tests for the GPO interface ---

[SSSD] [PATCHES] PAM, NSS: allow UPN login names

2014-07-22 Thread Sumit Bose
Hi, this series of patches should solve https://fedorahosted.org/sssd/ticket/1749 . The solution is a bit different than the one outline in https://fedorahosted.org/sssd/wiki/DesignDocs/NSSWithKerberosPrincipal but after a couple of iterations I prefer this solution because it adds only a minimal

Re: [SSSD] [PATCH] TESTS: Add unit tests for the GPO interface

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 01:25:50PM +0200, Jakub Hrozek wrote: Hi, I used the attached patch to exercise Yassir's new additions to the sysdb API. Sorry there was one useless hunk in Makefile.am. A new patch is attached. From 4ebcf633f07b58c1256751a74a0b0d7643e93989 Mon Sep 17 00:00:00 2001

Re: [SSSD] [PATCHES] sss_case = preserving

2014-07-22 Thread Pavel Reichl
On 07/22/2014 02:03 PM, Pavel Reichl wrote: I finally tested the patches and it seems to me to be working with AD and LDAP provider, but does not seem to work with IPA provider. I was not able to create an user in IPA with some upper case so I had to change it directly in LDAP. This is

[SSSD] [PATCHES] Implement MIT Kerberos localauth plugin

2014-07-22 Thread Sumit Bose
Hi, these two patches implement the MIT Kerberos localauth plugin for SSSD. Since it uses the new plugin style (http://k5wiki.kerberos.org/wiki/Projects/Plugin_support_improvements) it has to be activated explicitly. A section like [plugins] localauth = { module =

Re: [SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-22 Thread Pavel Březina
On 07/22/2014 10:43 AM, Jakub Hrozek wrote: On Tue, Jul 22, 2014 at 09:33:01AM +0200, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 02:10:34PM +0200, Pavel Březina wrote: On 07/21/2014 12:07 PM, Jakub Hrozek wrote: On Fri, Jul 18, 2014 at 01:15:25PM +0200, Pavel Březina wrote:

Re: [SSSD] [PATCHES] sss_case = preserving

2014-07-22 Thread Michal Židek
On 07/22/2014 02:49 PM, Pavel Reichl wrote: On 07/22/2014 02:03 PM, Pavel Reichl wrote: I finally tested the patches and it seems to me to be working with AD and LDAP provider, but does not seem to work with IPA provider. I was not able to create an user in IPA with some upper case so I had

Re: [SSSD] [PATCHES] sss_case = preserving

2014-07-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2014 09:32 AM, Michal Židek wrote: On 07/22/2014 02:49 PM, Pavel Reichl wrote: On 07/22/2014 02:03 PM, Pavel Reichl wrote: I finally tested the patches and it seems to me to be working with AD and LDAP provider, but does not seem to

Re: [SSSD] [PATCHES] PAM, NSS: allow UPN login names

2014-07-22 Thread Pavel Březina
On 07/22/2014 01:27 PM, Sumit Bose wrote: Hi, this series of patches should solve https://fedorahosted.org/sssd/ticket/1749 . The solution is a bit different than the one outline in https://fedorahosted.org/sssd/wiki/DesignDocs/NSSWithKerberosPrincipal but after a couple of iterations I prefer

Re: [SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 03:32:18PM +0200, Pavel Březina wrote: On 07/22/2014 10:43 AM, Jakub Hrozek wrote: On Tue, Jul 22, 2014 at 09:33:01AM +0200, Jakub Hrozek wrote: On Mon, Jul 21, 2014 at 02:10:34PM +0200, Pavel Březina wrote: On 07/21/2014 12:07 PM, Jakub Hrozek wrote: On Fri, Jul 18,

Re: [SSSD] [PATCH] ad: update membership after SIDs are resolved

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 06:19:46PM +0200, Jakub Hrozek wrote: ACK to both, then. * master: * ed346bcc84b8a326996e5550771773d8e63f17c2 * e6fa71b990d7068d66b98015ae54aae399cc84f1 * sssd-1-11: * e00a71a43980963adf9b9f5e3d2f356f175498e9 * c123f5352ac406b5d02acab88642a9564fe31381

Re: [SSSD] [PATCH] sudo: fetch sudoRunAs attribute

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 15, 2014 at 04:48:52PM +0200, Jakub Hrozek wrote: * master: 7c30e60c525ea798aaab142766ff00eef4b5df3b Also pushed to sssd-1-11: e1c8821cd260c7c5322843b5f295888b3e29dc22 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] TESTS: Add unit tests for the GPO interface

2014-07-22 Thread Yassir Elley
- Original Message - On Tue, Jul 22, 2014 at 01:25:50PM +0200, Jakub Hrozek wrote: Hi, I used the attached patch to exercise Yassir's new additions to the sysdb API. Sorry there was one useless hunk in Makefile.am. A new patch is attached.

Re: [SSSD] [PATCH] Two minor patches for tokenGroups nested group processing

2014-07-22 Thread Jakub Hrozek
On Thu, Mar 13, 2014 at 12:00:47PM +0100, Sumit Bose wrote: On Wed, Mar 12, 2014 at 11:20:42PM +0100, Jakub Hrozek wrote: Hi, the attached two patches are not strictly related to tokenGroups processing, but it's very easy to reproduce the problem that way. The issue is only confusing

Re: [SSSD] [PATCH] AD: Cache gpo version; only download policy files if version changes

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 03:13:58AM -0400, Yassir Elley wrote: See some comments about ad_gpo.c inline, I'm still reading ad_gpo_child.c From f3f00a78102ad5e389266b28c43d0396caf57592 Mon Sep 17 00:00:00 2001 From: Yassir Elley yel...@redhat.com Date: Tue, 22 Jul 2014 03:03:03 -0400 Subject:

Re: [SSSD] [PATCH] Exit offline mode only if server is available.

2014-07-22 Thread Michal Židek
On 07/09/2014 03:35 PM, Michal Židek wrote: On 07/07/2014 07:33 PM, Michal Židek wrote: On 07/07/2014 03:09 PM, Michal Židek wrote: On 07/07/2014 03:01 PM, Jakub Hrozek wrote: On Mon, Jul 07, 2014 at 02:11:52PM +0200, Michal Židek wrote: On 07/06/2014 06:44 PM, Simo Sorce wrote: On Sun,

Re: [SSSD] sss_client: thread safe initialisation of sss_nss_mc_get_ctx

2014-07-22 Thread Michal Židek
On 07/18/2014 04:16 PM, Jakub Hrozek wrote: On Fri, Jul 18, 2014 at 01:10:24PM +0200, Sumit Bose wrote: ACK to 0001 and 0002. bye, Sumit Thank you for the review! I agree with Lukas that client code should be checked thoroughly, so I'd like to ask Simo to take a look too, since he wrote

Re: [SSSD] [PATCH] AD: Cache gpo version; only download policy files if version changes

2014-07-22 Thread Lukas Slebodnik
On (22/07/14 03:13), Yassir Elley wrote: On Sun, Jul 20, 2014 at 05:48:45PM -0400, Yassir Elley wrote: Hi, The attached patch adds support for gpo version checking and for conditional downloading of policy files. In order to get that to work, this patch also replaces the deprecated smb

[SSSD] [PATCH] SDAP: reduce code duplicity-rfc2307bis nested groups

2014-07-22 Thread Pavel Reichl
Hello, please see attached trivial patch. Thanks, Pavel ReichlFrom d9dc93beb523d87f56820fcc74e634df09106fad Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date: Tue, 22 Jul 2014 19:45:06 +0200 Subject: [PATCH] SDAP: reduce code duplicity-rfc2307bis nested groups Move copypasted

Re: [SSSD] [PATCHES] PAM, NSS: allow UPN login names

2014-07-22 Thread Sumit Bose
On Tue, Jul 22, 2014 at 05:55:21PM +0200, Pavel Březina wrote: On 07/22/2014 01:27 PM, Sumit Bose wrote: Hi, this series of patches should solve https://fedorahosted.org/sssd/ticket/1749 . The solution is a bit different than the one outline in

Re: [SSSD] [PATCH] AD: Cache gpo version; only download policy files if version changes

2014-07-22 Thread Jakub Hrozek
On Tue, Jul 22, 2014 at 07:32:17PM +0200, Lukas Slebodnik wrote: On (22/07/14 03:13), Yassir Elley wrote: On Sun, Jul 20, 2014 at 05:48:45PM -0400, Yassir Elley wrote: Hi, The attached patch adds support for gpo version checking and for conditional downloading of policy files. In

Re: [SSSD] [PATCH] libwbclient: SSSD implementation

2014-07-22 Thread Lukas Slebodnik
On (22/07/14 10:51), Sumit Bose wrote: Hi, this patch contains the libwbclient implementation for SSSD to allow Samba file-servers and utilities to use SSSD instead of winbind to map SIDs, names and POSIX IDs. The related ticket is https://fedorahosted.org/sssd/ticket/1588. The SSSD specific

Re: [SSSD] [PATCH] libwbclient: SSSD implementation

2014-07-22 Thread Lukas Slebodnik
On (23/07/14 00:58), Lukas Slebodnik wrote: On (22/07/14 10:51), Sumit Bose wrote: Hi, this patch contains the libwbclient implementation for SSSD to allow Samba file-servers and utilities to use SSSD instead of winbind to map SIDs, names and POSIX IDs. The related ticket is