Re: [SSSD] [PATCH] IPA: Remove MPG groups if getgrgid was called before getpw()

2015-09-18 Thread Lukas Slebodnik
On (14/09/15 11:59), Jakub Hrozek wrote: >On Fri, Jul 31, 2015 at 10:26:58AM +0200, Jakub Hrozek wrote: >> On Thu, Jul 30, 2015 at 06:20:31PM +0200, Sumit Bose wrote: >> > On Wed, Jul 22, 2015 at 12:18:07PM +0200, Jakub Hrozek wrote: >> > > On Wed, Jul 22, 2015 at 10:01:31AM +0200, Sumit Bose

Re: [SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

2015-09-18 Thread Lukas Slebodnik
On (01/09/15 11:06), Lukas Slebodnik wrote: >ehlo, > >attached is alternative version for ticket 2744. >The unit test passed but there is a performance improvement. > >If we compare 3rd patch to current master than >there is a 10 less invocation of malloc (an also other functions) per group. >and

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-18 Thread Lukas Slebodnik
On (18/09/15 11:18), Michal Židek wrote: >On 09/18/2015 10:19 AM, Lukas Slebodnik wrote: >>On (16/09/15 13:41), Michal Židek wrote: >>>On 09/14/2015 05:49 PM, Jakub Hrozek wrote: On Mon, Sep 07, 2015 at 03:38:32PM +0200, Michal Židek wrote: >Hi, > >patch for ticket

Re: [SSSD] [PATCH] IPA: Remove MPG groups if getgrgid was called before getpw()

2015-09-18 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 10:52:05AM +0200, Lukas Slebodnik wrote: > On (14/09/15 11:59), Jakub Hrozek wrote: > >On Fri, Jul 31, 2015 at 10:26:58AM +0200, Jakub Hrozek wrote: > >> On Thu, Jul 30, 2015 at 06:20:31PM +0200, Sumit Bose wrote: > >> > On Wed, Jul 22, 2015 at 12:18:07PM +0200, Jakub

Re: [SSSD] [PATCH] Temporarily mark subdomain as inactive instead marking the whole back end offline

2015-09-18 Thread Jakub Hrozek
On Thu, Sep 17, 2015 at 10:41:07PM +0200, Pavel Březina wrote: > On 09/04/2015 02:35 PM, Jakub Hrozek wrote: > >Hi, > > > >the attached patches implement https://fedorahosted.org/sssd/ticket/2637 > > > >There are two main use-cases: > > 1) If AD DCs are not reachable on the IPA server itself,

Re: [SSSD] [PATCH] views: do not require overrideDN in groups when LOCAL view is set

2015-09-18 Thread Sumit Bose
On Thu, Sep 17, 2015 at 02:50:09PM +0200, Pavel Březina wrote: > On 09/17/2015 01:26 PM, Pavel Březina wrote: > >On 09/17/2015 01:21 PM, Sumit Bose wrote: > >>On Thu, Sep 17, 2015 at 12:44:37PM +0200, Pavel Březina wrote: > >>>On 09/17/2015 12:37 PM, Sumit Bose wrote: > On Thu, Sep 17, 2015 at

Re: [SSSD] [PATCH] cache_req: support UPN

2015-09-18 Thread Petr Cech
On 09/17/2015 11:06 AM, Pavel Březina wrote: I wanted to avoid writing types for send_fn and done_fn. I'll do it if you want me to, but I think this is good enough for test. Well. # return run_cache_req(...) but it doesn't provide value. It was there originally then I realized I don't have

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-18 Thread Sumit Bose
On Fri, Sep 18, 2015 at 11:43:26AM +0200, Michal Židek wrote: > On 09/18/2015 11:27 AM, Lukas Slebodnik wrote: > >On (18/09/15 11:18), Michal Židek wrote: > >>On 09/18/2015 10:19 AM, Lukas Slebodnik wrote: > >>>On (16/09/15 13:41), Michal Židek wrote: > On 09/14/2015 05:49 PM, Jakub Hrozek

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-18 Thread Petr Cech
On 09/14/2015 01:53 PM, Sumit Bose wrote: Hi Petr, thank you for your patience. Both versions of your patches work as expected and fixes the issues with group and nested group memberships. After testing a reading the current sources I think the best solution might be a slight variant of your

Re: [SSSD] [PATCHES] test*: Create keytabs in unique directory

2015-09-18 Thread Jakub Hrozek
On Mon, Sep 14, 2015 at 03:38:54PM +0200, Jakub Hrozek wrote: > On Fri, Sep 11, 2015 at 02:56:14PM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > attached patches should intermittent failures reported in ticket #2694. > > Few files could touch the same keytab which could cause issues. > > But I

Re: [SSSD] [PATCH] tests: Use unique name for TEST_PATH

2015-09-18 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 10:40:58AM +0200, Lukas Slebodnik wrote: > On (14/09/15 15:37), Jakub Hrozek wrote: > >On Thu, Sep 10, 2015 at 03:28:50PM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> attached patch should prevent copy@paste errors in unit tests. > >> > >> e.g. > >>

Re: [SSSD] [PATCH] views: do not require overrideDN in groups when LOCAL view is set

2015-09-18 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 11:48:11AM +0200, Sumit Bose wrote: > Hi, > > the patches are looking good, fix the issue, do not cause issues while > testing with IPA overrides and pass CI > (http://sssd-ci.duckdns.org/logs/job/26/79/summary.html), so ACK. > > bye, > Sumit *

Re: [SSSD] [PATCH] DDNS: execute nsupdate for single update of PTR rec

2015-09-18 Thread Jakub Hrozek
On Wed, Sep 16, 2015 at 08:23:16PM +0200, Pavel Reichl wrote: > Hello, please see updated version of the patch. > > On 09/16/2015 11:58 AM, Jakub Hrozek wrote: > >On Mon, Sep 14, 2015 at 07:53:06PM +0200, Pavel Reichl wrote: > > >>+static uint8_t *nsupdate_convert_address(struct sockaddr_storage

Re: [SSSD] [PATCH] tests: Use unique name for TEST_PATH

2015-09-18 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 01:20:32PM +0200, Jakub Hrozek wrote: > Thanks, ACK. > > CI (together with your other test patches): > http://sssd-ci.duckdns.org/logs/job/26/81/summary.html master: * d71cd46ede9c57e3947c86c61306a9caddce242c * 50c9d542e8bf641412debaa82a4dcf67ddb72258

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-18 Thread Lukas Slebodnik
On (16/09/15 13:41), Michal Židek wrote: >On 09/14/2015 05:49 PM, Jakub Hrozek wrote: >>On Mon, Sep 07, 2015 at 03:38:32PM +0200, Michal Židek wrote: >>>Hi, >>> >>>patch for ticket https://fedorahosted.org/sssd/ticket/2773 >>>is attached. >>> >>>Michal >> >>> From

Re: [SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

2015-09-18 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 11:40:20AM +0200, Lukas Slebodnik wrote: > On (01/09/15 11:06), Lukas Slebodnik wrote: > >ehlo, > > > >attached is alternative version for ticket 2744. > >The unit test passed but there is a performance improvement. > > > >If we compare 3rd patch to current master than >

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-18 Thread Michal Židek
On 09/18/2015 11:27 AM, Lukas Slebodnik wrote: On (18/09/15 11:18), Michal Židek wrote: On 09/18/2015 10:19 AM, Lukas Slebodnik wrote: On (16/09/15 13:41), Michal Židek wrote: On 09/14/2015 05:49 PM, Jakub Hrozek wrote: On Mon, Sep 07, 2015 at 03:38:32PM +0200, Michal Židek wrote: Hi,

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-18 Thread Petr Cech
Hello, there are fixed patches attached. On 09/18/2015 11:08 AM, Lukas Slebodnik wrote: --version-info 0:1:0 +-version-info 1:0:1 >>>Lukas, are you sure this version number 1:0:1? If you're really sure this >>>number, I have not understood it properly. You might also look

Re: [SSSD] [PATCH] PAM: Make p11_child timeout configurable

2015-09-18 Thread Michal Židek
On 09/18/2015 12:07 PM, Sumit Bose wrote: On Fri, Sep 18, 2015 at 11:43:26AM +0200, Michal Židek wrote: On 09/18/2015 11:27 AM, Lukas Slebodnik wrote: On (18/09/15 11:18), Michal Židek wrote: On 09/18/2015 10:19 AM, Lukas Slebodnik wrote: On (16/09/15 13:41), Michal Židek wrote: On

Re: [SSSD] [PATCH] Temporarily mark subdomain as inactive instead marking the whole back end offline

2015-09-18 Thread Jakub Hrozek
On Fri, Sep 18, 2015 at 11:04:36AM +0200, Jakub Hrozek wrote: > On Thu, Sep 17, 2015 at 10:41:07PM +0200, Pavel Březina wrote: > > On 09/04/2015 02:35 PM, Jakub Hrozek wrote: > > >Hi, > > > > > >the attached patches implement https://fedorahosted.org/sssd/ticket/2637 > > > > > >There are two main

Re: [SSSD] [PATCH] Temporarily mark subdomain as inactive instead marking the whole back end offline

2015-09-18 Thread Pavel Březina
On 09/18/2015 03:03 PM, Jakub Hrozek wrote: On Fri, Sep 18, 2015 at 11:04:36AM +0200, Jakub Hrozek wrote: On Thu, Sep 17, 2015 at 10:41:07PM +0200, Pavel Březina wrote: On 09/04/2015 02:35 PM, Jakub Hrozek wrote: Hi, the attached patches implement https://fedorahosted.org/sssd/ticket/2637

Re: [SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

2015-09-18 Thread Pavel Březina
On 09/01/2015 11:06 AM, Lukas Slebodnik wrote: ehlo, attached is alternative version for ticket 2744. The unit test passed but there is a performance improvement. If we compare 3rd patch to current master than there is a 10 less invocation of malloc (an also other functions) per group. and we

[SSSD] [PATCH] sss_override: remove -d from manpage

2015-09-18 Thread Pavel Březina
Even though Lukas caught -d in command line help, I kinda managed to keep it in manual page. >From 1cfaff9f1697c1d92c3ed7b6309372abf5e10026 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Fri, 18 Sep 2015 15:55:13 +0200 Subject: [PATCH] sss_override:

Re: [SSSD] [PATCH] tests: Use unique name for TEST_PATH

2015-09-18 Thread Lukas Slebodnik
On (14/09/15 15:37), Jakub Hrozek wrote: >On Thu, Sep 10, 2015 at 03:28:50PM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> attached patch should prevent copy@paste errors in unit tests. >> >> e.g. >> e0f2a783439fb7d3b85469f34ad6d672abf7e1fa >> 0d0e787555efc1e6e4eb39a924bb9861bf2921d5 >> >> LS >

Re: [SSSD] [PATCH] DDNS: execute nsupdate for single update of PTR rec

2015-09-18 Thread Pavel Reichl
On 09/18/2015 02:22 PM, Jakub Hrozek wrote: I would just like to squash these style changes: diff --git a/src/providers/ldap/sdap_dyndns.c b/src/providers/ldap/sdap_dyndns.c index c80a468..673f884 100644 --- a/src/providers/ldap/sdap_dyndns.c +++