Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Dmitri Pal
Stephen Gallagher wrote: > On 09/28/2009 01:46 PM, Dmitri Pal wrote: > >> Stephen Gallagher wrote: >> >>> On 09/28/2009 09:55 AM, Simo Sorce wrote: >>> >>> On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: > The SSSD needs a config_from_f

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Sumit Bose
On Mon, Sep 28, 2009 at 02:50:30PM -0400, Stephen Gallagher wrote: > On 09/28/2009 01:46 PM, Dmitri Pal wrote: > > Stephen Gallagher wrote: > >> On 09/28/2009 09:55 AM, Simo Sorce wrote: > >> > >>> On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: > >>> > The SSSD needs a con

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Sumit Bose
On Mon, Sep 28, 2009 at 02:51:11PM -0400, Stephen Gallagher wrote: > On 09/28/2009 01:52 PM, Stephen Gallagher wrote: > > On 09/28/2009 12:24 PM, Stephen Gallagher wrote: > >> On 09/28/2009 11:49 AM, Sumit Bose wrote: > >>> Hi, > > > >>> with the patch the config file is only read if it is > >>> -

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Stephen Gallagher
On 09/28/2009 01:52 PM, Stephen Gallagher wrote: > On 09/28/2009 12:24 PM, Stephen Gallagher wrote: >> On 09/28/2009 11:49 AM, Sumit Bose wrote: >>> Hi, > >>> with the patch the config file is only read if it is >>> - a regular file >>> - owner and group are 0 (root) >>> - file permissions are 600

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Stephen Gallagher
On 09/28/2009 01:46 PM, Dmitri Pal wrote: > Stephen Gallagher wrote: >> On 09/28/2009 09:55 AM, Simo Sorce wrote: >> >>> On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: >>> The SSSD needs a config_from_fd() variant of the config_from_file() call so that we can pre

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 12:24 PM, Stephen Gallagher wrote: > On 09/28/2009 11:49 AM, Sumit Bose wrote: >> Hi, > >> with the patch the config file is only read if it is >> - a regular file >> - owner and group are 0 (root) >> - file permissions are 600 > >> Thi

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Dmitri Pal
Stephen Gallagher wrote: > On 09/28/2009 11:49 AM, Sumit Bose wrote: > > Hi, > > > with the patch the config file is only read if it is > > - a regular file > > - owner and group are 0 (root) > > - file permissions are 600 > > > This patch depends on the config_from_fd patch currently under review.

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Dmitri Pal
Stephen Gallagher wrote: > On 09/28/2009 09:55 AM, Simo Sorce wrote: > >> On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: >> >>> The SSSD needs a config_from_fd() variant of the config_from_file() >>> call >>> so that we can preopen a config file and perform some verification on

[SSSD] [PATCH] Add SASL/GSSAPI support to ldap id provider

2009-09-28 Thread Simo Sorce
This is an initial implementation of SASL support for the id provider. It works and IMO it is complete enough to be committed. Comments or acks welcome :-) Simo. 0001-Initial-implementation-of-sasl-bind-support.patch Description: application/mbox ___

Re: [SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 11:49 AM, Sumit Bose wrote: > Hi, > > with the patch the config file is only read if it is > - a regular file > - owner and group are 0 (root) > - file permissions are 600 > > This patch depends on the config_from_fd patch currently und

Re: [SSSD] [PATCH] update sysdb tests to new config file version

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 11:52 AM, Sumit Bose wrote: > On Mon, Sep 28, 2009 at 11:32:08AM -0400, Stephen Gallagher wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 09/28/2009 11:00 AM, Sumit Bose wrote: >>> Hi, >>> >>> this patch should make sy

Re: [SSSD] [PATCH] update sysdb tests to new config file version

2009-09-28 Thread Sumit Bose
On Mon, Sep 28, 2009 at 11:32:08AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/28/2009 11:00 AM, Sumit Bose wrote: > > Hi, > > > > this patch should make sysdb tests happy again. > > > > bye, > > Sumit > > > > > >

[SSSD] [PATCH] add utility call check_and_open_readonly

2009-09-28 Thread Sumit Bose
Hi, with the patch the config file is only read if it is - a regular file - owner and group are 0 (root) - file permissions are 600 This patch depends on the config_from_fd patch currently under review. bye, Sumit >From 0407564c2461da1fdd915b97f82de47d359139e8 Mon Sep 17 00:00:00 2001 From: Sumi

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Sumit Bose
On Mon, Sep 28, 2009 at 10:33:22AM -0400, Stephen Gallagher wrote: > On 09/28/2009 09:55 AM, Simo Sorce wrote: > > On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: > >> The SSSD needs a config_from_fd() variant of the config_from_file() > >> call > >> so that we can preopen a config file

Re: [SSSD] [PATCH] update sysdb tests to new config file version

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 11:00 AM, Sumit Bose wrote: > Hi, > > this patch should make sysdb tests happy again. > > bye, > Sumit > > > > > ___

[SSSD] [PATCH] update sysdb tests to new config file version

2009-09-28 Thread Sumit Bose
Hi, this patch should make sysdb tests happy again. bye, Sumit >From cd13b1e84e8b9f972851e07857d6a547c6077677 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Mon, 28 Sep 2009 16:58:31 +0200 Subject: [PATCH] update sysdb tests to new config file version --- server/tests/sysdb-tests.c |8 +++

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Stephen Gallagher
On 09/28/2009 09:55 AM, Simo Sorce wrote: > On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: >> The SSSD needs a config_from_fd() variant of the config_from_file() >> call >> so that we can preopen a config file and perform some verification on >> it >> before parsing it. The config_from

Re: [SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Simo Sorce
On Mon, 2009-09-28 at 09:38 -0400, Stephen Gallagher wrote: > The SSSD needs a config_from_fd() variant of the config_from_file() > call > so that we can preopen a config file and perform some verification on > it > before parsing it. The config_from_fd() call is used to avoid race > conditions bet

[SSSD] [PATCH] Add config_from_fd() to ini_config

2009-09-28 Thread Stephen Gallagher
The SSSD needs a config_from_fd() variant of the config_from_file() call so that we can preopen a config file and perform some verification on it before parsing it. The config_from_fd() call is used to avoid race conditions between testing the file and reading it in. Note: the *_from_fd() function

Re: [SSSD] [PATCH] tighten up file permissions just to be safe

2009-09-28 Thread Simo Sorce
On Mon, 2009-09-28 at 08:22 -0400, Stephen Gallagher wrote: > On 09/28/2009 08:10 AM, Simo Sorce wrote: > > just make double sure we do not leak info. > Ack, although you may want to change "sensible" to "sensitive" in the > commit comment before pushing. Pushed and fixed the comment. Simo. ___

Re: [SSSD] [PATCH] tighten up file permissions just to be safe

2009-09-28 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/28/2009 08:10 AM, Simo Sorce wrote: > just make double sure we do not leak info. > > Simo. > > > > > ___ > sssd-devel mailing

[SSSD] [PATCH] tighten up file permissions just to be safe

2009-09-28 Thread Simo Sorce
just make double sure we do not leak info. Simo. 0001-Tighten-up-permission.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel