[SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Petr Cech
Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Petr From ca782a1518480635ef60bc2cdf77d9b8644132b0 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 8 Jul 2015 07:17:28 -0400

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Pavel Reichl
On 07/08/2015 02:13 PM, Petr Cech wrote: Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Petr Hello Petr, thank for the patch! I haven't tested the patch yet, but I have some nitpicks. Please

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Sumit Bose
On Wed, Jul 08, 2015 at 02:13:42PM +0200, Petr Cech wrote: Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Hi Petr, welcome and thank you for your first patch. Besides Pavel's suggestions I

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Petr Cech
On 07/08/2015 02:46 PM, Pavel Reichl wrote: On 07/08/2015 02:13 PM, Petr Cech wrote: Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Petr Hello Petr, thank for the patch! I haven't tested

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Michal Židek
Hi! I think the function is a little overkill. The only change I would do in case of sss_cli commands is that I would change the decimal %d to a hexa 0x%x because that matches the representation in the header and would simplify grepping the code. OTOH if we want to make the messages also