Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-08-17 Thread Petr Cech
On 07/17/2015 01:26 PM, Petr Cech wrote: Hi, I have read the wiki pages. And I have the edited version. It would be difficult to send the diff, so I started a new pages where you can view the result. Original pages: [ 1] https://fedorahosted.org/sssd/wiki/Contribute [ 2]

Re: [SSSD] [PATCH] p11child: set restrictive umask and clear environment

2015-08-17 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 12:56:58PM +0200, Lukas Slebodnik wrote: On (17/08/15 10:35), Jakub Hrozek wrote: On Mon, Aug 17, 2015 at 09:01:24AM +0200, Lukas Slebodnik wrote: On (13/08/15 17:46), Jakub Hrozek wrote: Hi, the attached patch hardens the p11_child process. From

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Lukas Slebodnik
On (16/08/15 17:59), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with it so I gave up eventually. Of course, it would be quite

Re: [SSSD] [PATCH] p11child: set restrictive umask and clear environment

2015-08-17 Thread Lukas Slebodnik
On (17/08/15 10:35), Jakub Hrozek wrote: On Mon, Aug 17, 2015 at 09:01:24AM +0200, Lukas Slebodnik wrote: On (13/08/15 17:46), Jakub Hrozek wrote: Hi, the attached patch hardens the p11_child process. From 4023fb832cc5c5122c235b713c0ef401c5d21dd0 Mon Sep 17 00:00:00 2001 From: Jakub

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Lukas Slebodnik
On (17/08/15 10:32), Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Pavel Březina
On 08/17/2015 10:52 AM, Lukas Slebodnik wrote: On (17/08/15 10:32), Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 10:52:41AM +0200, Lukas Slebodnik wrote: On (17/08/15 10:32), Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction

Re: [SSSD] [PATCH] pam: Incerease p11 child timeout

2015-08-17 Thread Lukas Slebodnik
On (14/08/15 14:40), Michal Židek wrote: Hi, this patch is a hotfix for pam-srv-failing tests. Increasing the timeout to 30 seconds seems to be enough. I do not want to make it too big because the timeout is currently not configurable. The observation seems to be correct; at least according to

Re: [SSSD] [PATCH] test_memory_cache: Wait short time after cache invalidation

2015-08-17 Thread Michal Židek
On 08/17/2015 02:42 PM, Lukas Slebodnik wrote: On (13/08/15 13:31), Michal Židek wrote: On 08/13/2015 07:05 AM, Lukas Slebodnik wrote: On (12/08/15 14:35), Michal Židek wrote: Seriously? Is that your proposed solution? Yes, it's better to remove test rather then have intermittent failures.

Re: [SSSD] [PATCH] test_memory_cache: Wait short time after cache invalidation

2015-08-17 Thread Lukas Slebodnik
On (13/08/15 13:31), Michal Židek wrote: On 08/13/2015 07:05 AM, Lukas Slebodnik wrote: On (12/08/15 14:35), Michal Židek wrote: Seriously? Is that your proposed solution? Yes, it's better to remove test rather then have intermittent failures. You are twisting the plot here. Removing the test

Re: [SSSD] [PATCH] pam: Incerease p11 child timeout

2015-08-17 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 03:03:35PM +0200, Lukas Slebodnik wrote: On (17/08/15 14:45), Michal Židek wrote: On 08/17/2015 01:22 PM, Lukas Slebodnik wrote: On (14/08/15 14:40), Michal Židek wrote: Hi, this patch is a hotfix for pam-srv-failing tests. Increasing the timeout to 30 seconds

Re: [SSSD] [PATCH] pam: Incerease p11 child timeout

2015-08-17 Thread Lukas Slebodnik
On (17/08/15 14:45), Michal Židek wrote: On 08/17/2015 01:22 PM, Lukas Slebodnik wrote: On (14/08/15 14:40), Michal Židek wrote: Hi, this patch is a hotfix for pam-srv-failing tests. Increasing the timeout to 30 seconds seems to be enough. I do not want to make it too big because the timeout is

Re: [SSSD] [PATCH] pam: Incerease p11 child timeout

2015-08-17 Thread Michal Židek
On 08/17/2015 01:22 PM, Lukas Slebodnik wrote: On (14/08/15 14:40), Michal Židek wrote: Hi, this patch is a hotfix for pam-srv-failing tests. Increasing the timeout to 30 seconds seems to be enough. I do not want to make it too big because the timeout is currently not configurable. The

Re: [SSSD] [PATCHSET] LDAP: sanitize group name when used in filter

2015-08-17 Thread Jakub Hrozek
On Thu, Aug 13, 2015 at 12:23:02PM +0200, Pavel Březina wrote: On 08/06/2015 02:31 PM, Pavel Reichl wrote: On 08/05/2015 02:44 PM, Pavel Březina wrote: On 08/05/2015 12:11 PM, Pavel Reichl wrote: On 08/05/2015 11:34 AM, Pavel Březina wrote: On 08/04/2015 03:52 PM, Pavel Reichl wrote:

Re: [SSSD] [PATCH] Use sss_unique_file instead of calling mkstemp directly

2015-08-17 Thread Jakub Hrozek
On Thu, Aug 13, 2015 at 03:43:43PM +0200, Pavel Březina wrote: On 08/12/2015 02:23 PM, Jakub Hrozek wrote: Hi, there is a patchset that adds sss_unique_file with an optional destructor: https://patchwork.acksyn.org/patch/11351/ Attached are patches that use the function instead of

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-08-17 Thread Lukas Slebodnik
- Original Message - From: Nikolai Kondrashov nikolai.kondras...@redhat.com To: Development of the System Security Services Daemon sssd-devel@lists.fedorahosted.org Sent: Monday, August 17, 2015 6:40:36 PM Subject: [SSSD] [PATCH v3] Remove trailing whitespace On 08/17/2015 09:37

[SSSD] [PATCH v3] Remove trailing whitespace

2015-08-17 Thread Nikolai Kondrashov
On 08/17/2015 09:37 AM, Lukas Slebodnik wrote: On (13/08/15 15:48), Nikolai Kondrashov wrote: On 08/13/2015 02:57 PM, Lukas Slebodnik wrote: On (13/08/15 14:47), Nikolai Kondrashov wrote: +if GIT_CHECKOUT +export GIT_DIR=$(abs_top_srcdir)/.git +export GIT_WORK_TREE=$(abs_top_srcdir) +endif

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 10:32:00AM +0200, Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs,

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 10:52:41AM +0200, Lukas Slebodnik wrote: On (17/08/15 10:32), Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction

Re: [SSSD] [WIP] [TEST]: Observation patch

2015-08-17 Thread Lukas Slebodnik
On (14/08/15 15:17), Petr Cech wrote: Hi, I wrote patch. Regards Petr From c871c97862997df4e724647f1a0ce7297f2f059b Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Fri, 14 Aug 2015 13:17:22 +0200 Subject: [PATCH] TEST: Fix for responder_cache_req-tests Tests, that do not pass,

Re: [SSSD] [PATCH] p11child: set restrictive umask and clear environment

2015-08-17 Thread Lukas Slebodnik
On (13/08/15 17:46), Jakub Hrozek wrote: Hi, the attached patch hardens the p11_child process. From 4023fb832cc5c5122c235b713c0ef401c5d21dd0 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Wed, 5 Aug 2015 17:25:20 +0200 Subject: [PATCH] p11child: set restrictive umask and

Re: [SSSD] [PATCH v2] Remove trailing whitespace

2015-08-17 Thread Lukas Slebodnik
On (13/08/15 15:48), Nikolai Kondrashov wrote: On 08/13/2015 02:57 PM, Lukas Slebodnik wrote: On (13/08/15 14:47), Nikolai Kondrashov wrote: On 08/11/2015 07:13 PM, Nikolai Kondrashov wrote: Hi Pavel, On 08/11/2015 03:44 PM, Pavel Reichl wrote: On 08/11/2015 02:11 PM, Lukas Slebodnik wrote: On

[SSSD] [PATCH] SYSDB: Index the objectSIDString attribute

2015-08-17 Thread Jakub Hrozek
Hi, the attached patch was confirmed to work, so the code review should be easy. But because it adds an index to objectSID, which all AD objects have, there are two catches: 1) How log the upgrade takes 2) How much the database grows To test, I created an AD instance with 10.000 users

Re: [SSSD] [WIP] [TEST]: Observation patch

2015-08-17 Thread Petr Cech
On 08/17/2015 08:52 AM, Lukas Slebodnik wrote: From c871c97862997df4e724647f1a0ce7297f2f059b Mon Sep 17 00:00:00 2001 From: Petr Cechpc...@redhat.com Date: Fri, 14 Aug 2015 13:17:22 +0200 Subject: [PATCH] TEST: Fix for responder_cache_req-tests Tests, that do not pass, have a problem with

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Jakub Hrozek
On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with it so I gave up eventually. Thanks a

Re: [SSSD] [PATCH] p11child: set restrictive umask and clear environment

2015-08-17 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 09:01:24AM +0200, Lukas Slebodnik wrote: On (13/08/15 17:46), Jakub Hrozek wrote: Hi, the attached patch hardens the p11_child process. From 4023fb832cc5c5122c235b713c0ef401c5d21dd0 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Wed, 5 Aug

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-17 Thread Pavel Březina
On 08/17/2015 10:32 AM, Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles

Re: [SSSD] [WIP] [TEST]: Observation patch

2015-08-17 Thread Lukas Slebodnik
On (17/08/15 10:17), Petr Cech wrote: On 08/17/2015 08:52 AM, Lukas Slebodnik wrote: From c871c97862997df4e724647f1a0ce7297f2f059b Mon Sep 17 00:00:00 2001 From: Petr Cechpc...@redhat.com Date: Fri, 14 Aug 2015 13:17:22 +0200 Subject: [PATCH] TEST: Fix for responder_cache_req-tests Tests, that do