Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-08-18 Thread Michal Židek
On 08/18/2015 02:31 PM, Nikolai Kondrashov wrote: On 08/17/2015 08:42 PM, Lukas Slebodnik wrote: - Original Message - From: Nikolai Kondrashov nikolai.kondras...@redhat.com To: Development of the System Security Services Daemon sssd-devel@lists.fedorahosted.org Sent: Monday, August 17,

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Jakub Hrozek
On Mon, Aug 17, 2015 at 12:17:29PM +0200, Lukas Slebodnik wrote: On (16/08/15 17:59), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-18 Thread Petr Cech
On 08/05/2015 11:23 AM, Jakub Hrozek wrote: B) While writing a patch Lukas noticed another similar logging messages [sssd[pam]] [sss_dp_get_account_msg] (0x0400): Creating request for [LDAP][3][1][name=mof_user6] I investigated it. This is the same thing -- BE_REQ_*, but it is no longer

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Jakub Hrozek
On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with it so I gave up eventually. Of

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Pavel Březina
On 08/18/2015 01:23 PM, Jakub Hrozek wrote: On Mon, Aug 17, 2015 at 12:17:29PM +0200, Lukas Slebodnik wrote: On (16/08/15 17:59), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-08-18 Thread Nikolai Kondrashov
On 08/17/2015 08:42 PM, Lukas Slebodnik wrote: - Original Message - From: Nikolai Kondrashov nikolai.kondras...@redhat.com To: Development of the System Security Services Daemon sssd-devel@lists.fedorahosted.org Sent: Monday, August 17, 2015 6:40:36 PM Subject: [SSSD] [PATCH v3] Remove

[SSSD] [PATCH] sdap_async: Use specific errmsg when available

2015-08-18 Thread Michal Židek
Hi! The attached change was requested by: https://bugzilla.redhat.com/show_bug.cgi?id=1254723 Thanks, Michal From bc41a3748754881ad495bed1b654cc8d90d0c69a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= mzi...@redhat.com Date: Tue, 18 Aug 2015 20:39:03 +0200 Subject: [PATCH]

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Pavel Březina
On 08/18/2015 01:35 PM, Jakub Hrozek wrote: I wonder if it would be cleaner if there was a function that would accept a mem_ctx and line syntax and would create a sss_colondb_read_field* describing a line. Then sss_colondb_readline() would remove the talloc children first, then fill new data.

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Jakub Hrozek
On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with it so I gave up eventually. Of

[SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure

2015-08-18 Thread Jakub Hrozek
Hi, one more usage of sss_unique_file I forgot to send earlier. From 729bf7ce633fa8065e82e7e985a776f949bdd87d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Wed, 12 Aug 2015 12:45:34 +0200 Subject: [PATCH] GPO: Use sss_unique_file and close fd on failure The GPO child

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-08-18 Thread Petr Cech
On 08/13/2015 11:11 AM, Lukas Slebodnik wrote: From a93e36f11759cf9a748942e7632d4a07a088b098 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 8 Jul 2015 07:17:28 -0400 Subject: [PATCH] UTIL: Function 2string for enum sss_cli_command Improvement of debug messages. Instead

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Pavel Březina
On 08/18/2015 03:21 PM, Jakub Hrozek wrote: On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles

Re: [SSSD] [PATCH] SYSDB: Index the objectSIDString attribute

2015-08-18 Thread Michal Židek
On 08/17/2015 10:35 PM, Jakub Hrozek wrote: Hi, the attached patch was confirmed to work, so the code review should be easy. But because it adds an index to objectSID, which all AD objects have, there are two catches: 1) How log the upgrade takes My main concern was the heartbeat

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Jakub Hrozek
On Tue, Aug 18, 2015 at 05:15:02PM +0200, Pavel Březina wrote: On 08/18/2015 01:35 PM, Jakub Hrozek wrote: I wonder if it would be cleaner if there was a function that would accept a mem_ctx and line syntax and would create a sss_colondb_read_field* describing a line. Then

Re: [SSSD] [PATCH] sss_override: support import and export

2015-08-18 Thread Pavel Březina
On 08/16/2015 05:59 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2737 Hi, it should work... :-) However, I wanted to make import as transaction so no changes are made if some error occurs, but I had some troubles with it so I gave up eventually. Of course, it would be quite