Re: [SSSD] Code style -- for loop iterative variables initial declaration

2015-08-28 Thread Petr Cech
On 08/28/2015 09:18 AM, Lukas Slebodnik wrote: On (28/08/15 09:03), Petr Cech wrote: Hi everyone, I would like to ask you what you think about the initialization of iterative variables in forloops. I know that present code style does not allow it. But how I recognized, we use C99, and this

[SSSD] [PATCH] TESTS: fix fail in test_id_cleanup_exp_group

2015-08-28 Thread Pavel Reichl
Hello, please see trivial patch attached. Thanks! From 4b83c3d1b050ff9f9bfe713c373f257e0eb88d8c Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date: Fri, 28 Aug 2015 03:36:58 -0400 Subject: [PATCH] TESTS: fix fail in test_id_cleanup_exp_group Test was named same as the folder

Re: [SSSD] [PATCH] TESTS: fix fail in test_id_cleanup_exp_group

2015-08-28 Thread Lukas Slebodnik
On (28/08/15 09:46), Pavel Reichl wrote: Hello, please see trivial patch attached. Thanks! From 4b83c3d1b050ff9f9bfe713c373f257e0eb88d8c Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date: Fri, 28 Aug 2015 03:36:58 -0400 Subject: [PATCH] TESTS: fix fail in

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Pavel Březina
On 08/28/2015 12:21 PM, Lukas Slebodnik wrote: On (28/08/15 12:13), Pavel Březina wrote: On 08/27/2015 12:49 PM, Lukas Slebodnik wrote: On (25/08/15 13:00), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 From f181b0a94863f082abaf074a0940e83fbf1c89b1 Mon Sep 17 00:00:00 2001

Re: [SSSD] [PATCHES] DYDNDS: update quality of input for nsupdate

2015-08-28 Thread Pavel Reichl
On 08/14/2015 04:12 PM, Jakub Hrozek wrote: On Thu, Aug 13, 2015 at 05:31:07PM +0200, Pavel Reichl wrote: On 08/13/2015 02:12 PM, Pavel Reichl wrote: Sorry, this time with correct patches! ___ sssd-devel mailing list

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Pavel Březina
On 08/27/2015 12:49 PM, Lukas Slebodnik wrote: On (25/08/15 13:00), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 From f181b0a94863f082abaf074a0940e83fbf1c89b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Tue, 25 Aug 2015 12:58:45

Re: [SSSD] [PATCH] pam: Incerease p11 child timeout

2015-08-28 Thread Sumit Bose
On Fri, Aug 14, 2015 at 02:40:45PM +0200, Michal Židek wrote: Hi, this patch is a hotfix for pam-srv-failing tests. Increasing the timeout to 30 seconds seems to be enough. I do not want to make it too big because the timeout is currently not configurable. I'd like to talk to Sumit

Re: [SSSD] More upstream CI tests

2015-08-28 Thread Lukas Slebodnik
On (19/08/15 23:38), Jakub Hrozek wrote: Hi, as we're stabilizing the 1.13 branch and before we plan what we want to work on during the 1.14 development, we should use that time to write some more tests! Here are some areas where we could add tests. Please discuss or add your ideas, I would like

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Petr Cech
On 08/28/2015 03:13 PM, Petr Cech wrote: I am doing code review for fixed patch now. Patch looks good to me and it works. I discussed the problem above (about fprintf vs. libpopt) with both offline. The libpopt solution starts here [1] and I agree it would not be straightforward. So I am

[SSSD] [PATCH] AD: send less logs to syslog

2015-08-28 Thread Pavel Reichl
Hello, please see simple patch attached. Thanks! From c2fbcfd7c711d7978083b1d21e3c27d3e3f9c83a Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date: Fri, 28 Aug 2015 08:06:18 -0400 Subject: [PATCH] AD: send less logs to syslog Create new callback that handles logging messages in

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Petr Cech
On 08/28/2015 12:25 PM, Pavel Březina wrote: I would be also curious why you need to provide hacks for printing argument description for autohelp. There is a much more elegant way how to do it with libpopt. (small hint POPT_ARGFLAG_DOC_HIDDEN in sss_tool_common_opts) Your curiosity is

Re: [SSSD] [PATCH] pam: Incerease p11 child timeout

2015-08-28 Thread Michal Židek
On 08/28/2015 10:29 AM, Sumit Bose wrote: On Fri, Aug 14, 2015 at 02:40:45PM +0200, Michal Židek wrote: Hi, this patch is a hotfix for pam-srv-failing tests. Increasing the timeout to 30 seconds seems to be enough. I do not want to make it too big because the timeout is currently not

Re: [SSSD] [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-28 Thread Petr Cech
On 08/27/2015 05:49 PM, Michal Židek wrote: I agree. Attached is the same patch that was already ACKed, just with the changed name and added const. Michal Yes, it is the same, with const. ACK again. Petr ___ sssd-devel mailing list

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-28 Thread Petr Cech
On 08/27/2015 01:26 PM, Lukas Slebodnik wrote: Petr, what do you think about small simplification. #include providers/data_provider_req.h +#define be_req_to_str(req_type, be_req_t) \ +((req_type) BE_REQ_FAST) \ +? FAST #be_req_t \ +: #be_req_t + const char