Re: [SSSD] [PATCH v3] Remove trailing whitespace

On (27/08/15 10:56), Lukas Slebodnik wrote: >On (18/08/15 15:31), Nikolai Kondrashov wrote: >>On 08/17/2015 08:42 PM, Lukas Slebodnik wrote: >>>- Original Message - From: "Nikolai Kondrashov" To: "Development of the System Security Services Daemon"

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

On 08/27/2015 10:42 AM, Pavel Reichl wrote: * SSSDBG_TRACE_ALL produces: ...hbac_evaluator.c:150] [< hbac_evaluate() ...hbac_evaluator.c:410] REQUEST: ...hbac_evaluator.c:391] service [sshd] ...hbac_evaluator.c:400] service_group (none) ...hbac_evaluator.c:391] user [csikos]

Re: [SSSD] [PATCH] sss_override: document --debug options

On Fri, Aug 28, 2015 at 03:24:21PM +0200, Petr Cech wrote: > On 08/28/2015 03:13 PM, Petr Cech wrote: > >I am doing code review for fixed patch now. Patch looks good to me and > >it works. > > > >I discussed the problem above (about fprintf vs. libpopt) with both > >offline. The libpopt solution

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

On 08/31/2015 01:32 PM, Pavel Reichl wrote: 0x2000 (Mon Aug 31 07:03:04 2015) [sssd[be[cygnus.dev]]] [hbac] (0x0100): [../src/providers/ipa/hbac_evaluator.c:152] [< hbac_evaluate() (Mon Aug 31 07:03:04 2015) [sssd[be[cygnus.dev]]] [hbac] (0x2000): [../src/providers/ipa/hbac_evaluator.c:409]

Re: [SSSD] [PATCH] TESTS: ldap_id_cleanup timeouts

On Fri, Aug 28, 2015 at 03:19:42PM +0200, Petr Cech wrote: > On 08/27/2015 05:49 PM, Michal Židek wrote: > > > >I agree. Attached is the same patch that was already ACKed, > >just with the changed name and added const. > > > >Michal > > Yes, it is the same, with const. > > ACK again. > > Petr

Re: [SSSD] [PATCH] TESTS: fix fail in test_id_cleanup_exp_group

On Fri, Aug 28, 2015 at 09:55:05AM +0200, Lukas Slebodnik wrote: > On (28/08/15 09:46), Pavel Reichl wrote: > >Hello, > > > >please see trivial patch attached. > > > >Thanks! > > >From 4b83c3d1b050ff9f9bfe713c373f257e0eb88d8c Mon Sep 17 00:00:00 2001 > >From: Pavel Reichl >

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

On Thu, Aug 27, 2015 at 01:05:00PM +0200, Lukas Slebodnik wrote: > On (24/08/15 16:09), Michal Židek wrote: > >On 08/21/2015 04:55 PM, Petr Cech wrote: > >>On 08/21/2015 02:35 PM, Michal Židek wrote: > >>>Hi, > >>> > >>>some of the tests you deleted are valid and > >>>should not be deleted. > >>>

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote: > ACK > > LS * master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sssd: incorrect checks on length values during packet, decoding

On Fri, Aug 21, 2015 at 04:20:15PM +0200, Petr Cech wrote: > On 07/23/2015 02:44 PM, Michal Židek wrote: > >Hi, > > > >see the attached patch for ticket > >https://fedorahosted.org/sssd/ticket/1697 > > > >I think this is a candidate to include in our > >coding guidelines. > > > I agree. It is a

Re: [SSSD] [PATCH] LDAP: end on ENOMEM

On Mon, Aug 24, 2015 at 01:19:00PM +0200, Pavel Březina wrote: > On 08/24/2015 01:11 PM, Pavel Reichl wrote: > >Hello, > > > >please see trivial patch fixing coverity warning. > > > >Thanks! > > > >0001-LDAP-end-on-ENOMEM.patch > > > > > > From 69c20ca306827a558d6be015d0d060f9f46423f8 Mon Sep 17

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 08/31/2015 03:08 PM, Pavel Reichl wrote: On 08/10/2015 04:27 PM, Michal Židek wrote: From 725cb791d43e9f651345ec50419143c4e6bd22b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Thu, 6 Aug 2015 09:16:03 +0200 Subject: [PATCH 1/3] SYSDB: Add

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

On 08/31/2015 06:29 PM, Jakub Hrozek wrote: On Thu, Aug 27, 2015 at 01:05:00PM +0200, Lukas Slebodnik wrote: On (24/08/15 16:09), Michal Židek wrote: On 08/21/2015 04:55 PM, Petr Cech wrote: On 08/21/2015 02:35 PM, Michal Židek wrote: Hi, some of the tests you deleted are valid and should

Re: [SSSD] [PATCH] NSS: Don't ignore backslash in usernames with ldap provider

On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote: > ehlo, > > please review attached patch for regression #2772 > > LS Hi Lukas, thank you for taking care of the issue. The patch is working as expected without breaking the SID lookups and passes the CI

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote: > On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote: > > ACK > > > > LS > > * master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a This patch broke distcheck: ../src/util/sss_cli_cmd.c -fPIC -DPIC -o

Re: [SSSD] More upstream CI tests

On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: > On (19/08/15 23:38), Jakub Hrozek wrote: > >Hi, > > > >as we're stabilizing the 1.13 branch and before we plan what we want to > >work on during the 1.14 development, we should use that time to write > >some more tests! > > > >Here

Re: [SSSD] More upstream CI tests

On Fri, Aug 21, 2015 at 04:24:13PM +0300, Nikolai Kondrashov wrote: > On 08/20/2015 12:38 AM, Jakub Hrozek wrote: > >as we're stabilizing the 1.13 branch and before we plan what we want to > >work on during the 1.14 development, we should use that time to write > >some more tests! > > > >Here are

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On 08/31/2015 01:09 PM, Alexander Bokovoy wrote: On Mon, 31 Aug 2015, Lukas Slebodnik wrote: On (29/08/15 14:33), Alexander Bokovoy wrote: On Fri, 28 Aug 2015, Petr Cech wrote: Hi everyone, I would like to ask you what you think about the initialization of iterative variables in forloops.

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On 08/31/2015 01:20 PM, Jakub Hrozek wrote: On Mon, Aug 31, 2015 at 02:09:19PM +0300, Alexander Bokovoy wrote: On Mon, 31 Aug 2015, Lukas Slebodnik wrote: On (29/08/15 14:33), Alexander Bokovoy wrote: On Fri, 28 Aug 2015, Petr Cech wrote: Hi everyone, I would like to ask you what you think

Re: [SSSD] More upstream CI tests

On Mon, Aug 31, 2015 at 12:31:03PM +0200, Jakub Hrozek wrote: > Yes, this e-mail was about Sorry, I fat-fingered the first mail. This e-mail was about where should we concentrate our effort to add more tests in the next couple of weeks as we stabilize 1.13 and before we start on 1.14.

Re: [SSSD] More upstream CI tests

On 08/31/2015 01:32 PM, Jakub Hrozek wrote: On Fri, Aug 21, 2015 at 04:24:13PM +0300, Nikolai Kondrashov wrote: On 08/20/2015 12:38 AM, Jakub Hrozek wrote: as we're stabilizing the 1.13 branch and before we plan what we want to work on during the 1.14 development, we should use that time to

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

On 08/31/2015 01:18 PM, Petr Cech wrote: 0x0080 (Mon Aug 31 06:57:09 2015) [sssd[be[cygnus.dev]]] [ipa_hbac_evaluate_rules] (0x0080): Access granted by HBAC rule [Test_rule] (Mon Aug 31 06:57:09 2015) [sssd[be[cygnus.dev]]] [ipa_hbac_evaluate_rules] (0x0080): Access denied by HBAC rules

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On (30/08/15 15:31), Simo Sorce wrote: >On Fri, 2015-08-28 at 09:03 +0200, Petr Cech wrote: >> Hi everyone, >> >> I would like to ask you what you think about the initialization of >> iterative variables in forloops. I know that present code style does not >> allow it. But how I recognized, we

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On (29/08/15 14:33), Alexander Bokovoy wrote: >On Fri, 28 Aug 2015, Petr Cech wrote: >>Hi everyone, >> >>I would like to ask you what you think about the initialization of >>iterative variables in forloops. I know that present code style does not >>allow it. But how I recognized, we use C99, and

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On Mon, Aug 31, 2015 at 02:09:19PM +0300, Alexander Bokovoy wrote: > On Mon, 31 Aug 2015, Lukas Slebodnik wrote: > >On (29/08/15 14:33), Alexander Bokovoy wrote: > >>On Fri, 28 Aug 2015, Petr Cech wrote: > >>>Hi everyone, > >>> > >>>I would like to ask you what you think about the initialization

Re: [SSSD] [DING-LIBS] [INI] [PATCH] Fix comment in ini_augment_ut.c

On (31/08/15 13:30), Robbie Harwood wrote: >In the unit test for ini_config_augment(), there is an incorrect comment >on the `patterns` field. For more information, see >https://fedorahosted.org/sssd/ticket/2769 >From 8e5d5769095edc0ebd84036b68b0f567959bb0d8 Mon Sep 17 00:00:00 2001 >From:

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 08/10/2015 04:27 PM, Michal Židek wrote: From 725cb791d43e9f651345ec50419143c4e6bd22b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Thu, 6 Aug 2015 09:16:03 +0200 Subject: [PATCH 1/3] SYSDB: Add function to expire entry Ticket:

Re: [SSSD] [PATCH v3] Remove trailing whitespace

On 08/27/2015 11:56 AM, Lukas Slebodnik wrote: On (18/08/15 15:31), Nikolai Kondrashov wrote: On 08/17/2015 08:42 PM, Lukas Slebodnik wrote: - Original Message - From: "Nikolai Kondrashov" To: "Development of the System Security Services Daemon"

Re: [SSSD] More upstream CI tests

On 08/31/2015 02:19 PM, Jakub Hrozek wrote: On Mon, Aug 31, 2015 at 01:46:11PM +0300, Nikolai Kondrashov wrote: On 08/31/2015 01:32 PM, Jakub Hrozek wrote: On Fri, Aug 21, 2015 at 04:24:13PM +0300, Nikolai Kondrashov wrote: On 08/20/2015 12:38 AM, Jakub Hrozek wrote: as we're stabilizing the