Re: [SSSD] [PATCH] sss_override: add -find and -show

2015-10-23 Thread Pavel Reichl
Patch won't apply. Please rebase on top of 'sss_override: Remove unused parameter tool_ctx' (c12cd2d95d08c9316bc358c2f7707d92551b6909). Thanks. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-23 Thread Lukas Slebodnik
On (23/10/15 09:54), Pavel Reichl wrote: > > >On 10/23/2015 09:10 AM, Lukas Slebodnik wrote: >>On (22/10/15 13:35), Pavel Reichl wrote: >>>On 10/22/2015 12:27 PM, Pavel Březina wrote: On 10/22/2015 11:23 AM, Pavel Reichl wrote: > > >On 10/21/2015 12:44 PM, Pavel Březina wrote:

Re: [SSSD] [PATCH] intg: Fix all PEP8 issues

2015-10-23 Thread Michal Židek
On 10/23/2015 08:55 AM, Lukas Slebodnik wrote: On (22/10/15 19:52), Nikolai Kondrashov wrote: On 10/22/2015 05:55 PM, Michal Židek wrote: On 10/22/2015 04:06 PM, Nikolai Kondrashov wrote: Hi everyone, The attached patch fixes all PEP8 issues in src/tests/intg directory. I.e. the integration

Re: [SSSD] [PATCH] sss_override: add -find and -show

2015-10-23 Thread Pavel Reichl
Thanks for rebase. I'm having little trouble testing now, it seems to me that user-show does not work, but it's Friday evening so the problem might be between between keyboard and chair :-) $ getent passwd john john:*:1234:1:John Doe:/home/john:/bin/bash sudo sss_override user-add john

Re: [SSSD] [PATCH] sss_override: add -find and -show

2015-10-23 Thread Pavel Březina
On 10/23/2015 05:41 PM, Pavel Reichl wrote: Thanks for rebase. I'm having little trouble testing now, it seems to me that user-show does not work, but it's Friday evening so the problem might be between between keyboard and chair :-) $ getent passwd john john:*:1234:1:John

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-23 Thread Michal Židek
Hi! There is one new pep8 error in the code: ../src/tests/intg/ldap_test.py:819:37: E126 continuation line over-indented for hanging indent For the memcache workaroud please do this change in the code: diff --git a/src/tests/intg/ldap_test.py b/src/tests/intg/ldap_test.py index

Re: [SSSD] [PATCHES] BUILD: Remove unused variables

2015-10-23 Thread Jakub Hrozek
On Mon, Oct 19, 2015 at 09:16:40AM +0200, Lukas Slebodnik wrote: > ehlo, > > attached are few simple patches which simplify Makefile.am in src/test/cwrap > > LS The patches look good to me and CI passed: http://sssd-ci.duckdns.org/logs/job/31/21/summary.html

Re: [SSSD] [PATCH] intg: Fix all PEP8 issues

2015-10-23 Thread Michal Židek
On 10/23/2015 12:26 PM, Michal Židek wrote: On 10/23/2015 08:55 AM, Lukas Slebodnik wrote: On (22/10/15 19:52), Nikolai Kondrashov wrote: On 10/22/2015 05:55 PM, Michal Židek wrote: On 10/22/2015 04:06 PM, Nikolai Kondrashov wrote: Hi everyone, The attached patch fixes all PEP8 issues in

Re: [SSSD] Running tests with different environment

2015-10-23 Thread Lukas Slebodnik
On (21/10/15 09:20), Sumit Bose wrote: >On Tue, Oct 20, 2015 at 10:15:06PM +0200, Jakub Hrozek wrote: >> On Tue, Oct 20, 2015 at 05:17:49PM +0300, Nikolai Kondrashov wrote: >> > Hi Jakub, >> > >> > On 10/19/2015 09:43 PM, Jakub Hrozek wrote: >> > >I'm working on pam_sss.so tests[1] and I ran into

Re: [SSSD] [PATCH] sss_override: add -find and -show

2015-10-23 Thread Pavel Březina
On 10/23/2015 10:59 AM, Pavel Reichl wrote: Patch won't apply. Please rebase on top of 'sss_override: Remove unused parameter tool_ctx' (c12cd2d95d08c9316bc358c2f7707d92551b6909). Thanks. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-10-23 Thread Jakub Hrozek
On Fri, Oct 02, 2015 at 01:55:29PM +0200, Petr Cech wrote: > Hi, > > there is WiP attached. I removed some tests like this one some time ago. > They fail really often and we decided that the test logic was corrupted. Now > I am trying get it back to the codebase. > > There is some kind of cmocka

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-10-23 Thread Petr Cech
How to reproduce: Sumit wrote explanation to ticket comment. Better is if .log files missing. And you need run SSSD logging only to journal. Lukas wrote in soe mail above in thread, how to enable it. Thanks to all. Petr ___ sssd-devel mailing list

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

2015-10-23 Thread Michal Židek
On 10/21/2015 07:25 PM, Michal Židek wrote: On 10/21/2015 07:19 PM, Michal Židek wrote: On 10/21/2015 06:40 PM, Pavel Reichl wrote: On 10/21/2015 06:28 PM, Michal Židek wrote: + +def test_wrong_LC_ALL(local_domain_only): +""" +Regression test for ticket

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-10-23 Thread Petr Cech
On 10/23/2015 02:18 PM, Petr Cech wrote: How to reproduce: Sumit wrote explanation to ticket comment. Better is if .log files missing. And you need run SSSD logging only to journal. Lukas wrote in soe mail above in thread, how to enable it. Thanks to all. Petr # sudo bash # systemctl stop

Re: [SSSD] [PATCH] intg: Fix all PEP8 issues

2015-10-23 Thread Lukas Slebodnik
On (22/10/15 19:52), Nikolai Kondrashov wrote: >On 10/22/2015 05:55 PM, Michal Židek wrote: >>On 10/22/2015 04:06 PM, Nikolai Kondrashov wrote: >>>Hi everyone, >>> >>>The attached patch fixes all PEP8 issues in src/tests/intg directory. >>>I.e. the >>>integration tests. It was extracted from the

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-23 Thread Lukas Slebodnik
On (22/10/15 13:35), Pavel Reichl wrote: >On 10/22/2015 12:27 PM, Pavel Březina wrote: >>On 10/22/2015 11:23 AM, Pavel Reichl wrote: >>> >>> >>>On 10/21/2015 12:44 PM, Pavel Březina wrote: On 10/21/2015 12:39 PM, Pavel Reichl wrote: >Hello, > >while reviewing integration tests for

Re: [SSSD] [PATCH] CI: Add --enable-silent-rules flag

2015-10-23 Thread Lukas Slebodnik
On (22/10/15 16:53), Michal Židek wrote: >On 10/22/2015 04:43 PM, Jakub Hrozek wrote: >>On Thu, Oct 22, 2015 at 02:13:11PM +0200, Michal Židek wrote: >>>On 10/22/2015 02:01 PM, Jakub Hrozek wrote: On Thu, Oct 22, 2015 at 01:56:23PM +0200, Michal Židek wrote: >Hi, > >I think it is

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-23 Thread Pavel Reichl
On 10/23/2015 09:10 AM, Lukas Slebodnik wrote: On (22/10/15 13:35), Pavel Reichl wrote: On 10/22/2015 12:27 PM, Pavel Březina wrote: On 10/22/2015 11:23 AM, Pavel Reichl wrote: On 10/21/2015 12:44 PM, Pavel Březina wrote: On 10/21/2015 12:39 PM, Pavel Reichl wrote: Hello, while

Re: [SSSD] [PATCH] Use refcount to keep track of server structures returned from failover

2015-10-23 Thread Jakub Hrozek
On Wed, Oct 21, 2015 at 11:50:07AM +0200, Pavel Březina wrote: > On 10/11/2015 10:00 PM, Jakub Hrozek wrote: > >Hi, > > > >the attached patches are my proposal to fix > >https://fedorahosted.org/sssd/ticket/2829 > > > >I haven't tested them past make check yet, because I'm not sure I like > >them

Re: [SSSD] [PATCH] util: Include disabled domains in link_forest_roots

2015-10-23 Thread Jakub Hrozek
On Thu, Oct 22, 2015 at 01:00:36PM +0200, Michal Židek wrote: > On 10/22/2015 11:12 AM, Jakub Hrozek wrote: > >On Wed, Oct 21, 2015 at 04:27:36PM +0200, Michal Židek wrote: > >>If you agree that these Coverity complains are false positives > >>it would be good to push the patches. So far they

Re: [SSSD] [PATCH] util: Include disabled domains in link_forest_roots

2015-10-23 Thread Jakub Hrozek
On Fri, Oct 23, 2015 at 10:32:38AM +0200, Jakub Hrozek wrote: > On Thu, Oct 22, 2015 at 01:00:36PM +0200, Michal Židek wrote: > > On 10/22/2015 11:12 AM, Jakub Hrozek wrote: > > >On Wed, Oct 21, 2015 at 04:27:36PM +0200, Michal Židek wrote: > > >>If you agree that these Coverity complains are