Re: [SSSD] Fix warning may be used uninitialized

2015-11-11 Thread Pavel Březina
On 11/10/2015 09:13 AM, Lukas Slebodnik wrote: ehlo, and the last one patch to fix warnings on el6 LS Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] Fix warning may be used uninitialized

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 11:22:03AM +0100, Pavel Březina wrote: > On 11/10/2015 09:13 AM, Lukas Slebodnik wrote: > >ehlo, > > > >and the last one patch to fix warnings on el6 > > > >LS > > Ack. * master: 911e9879cae1f8f18e73acb3c6037af651cd9db5 ___

Re: [SSSD] [PATCHES] UTIL: Fix memory leak in switch_creds

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 08:16:55AM +0100, Petr Cech wrote: > > > On 11/11/2015 08:04 AM, Lukas Slebodnik wrote: > >On (11/11/15 07:58), Petr Cech wrote: > >>>On 11/09/2015 08:06 AM, Lukas Slebodnik wrote: > >ehlo, > > > >You can see a leak in talloc report. > >But it was ignored.

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-11 Thread Petr Cech
On 11/11/2015 09:32 AM, Jakub Hrozek wrote: >Hi Jakub, > >I just sent the patch to the CI tests and they passed >http://sssd-ci.duckdns.org/logs/job/32/63/summary.html > > >Then I would prefer undocumented. It matches how we (don't) document the > >"command" option. >I agree with little

Re: [SSSD] [PATCH] IFP: Skip non-POSIX groups properly

2015-11-11 Thread Pavel Březina
On 11/09/2015 10:24 PM, Jakub Hrozek wrote: Hi, please review! Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

2015-11-11 Thread Pavel Reichl
On 11/10/2015 05:00 PM, Lukas Slebodnik wrote: [snip] I tried it and all test passed. Please fix small issues and you have my ACK. LS Thanks, updated patch set attached. >From 5f43c3ddef195a7a480755306349555e059778a3 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date:

Re: [SSSD] [PATCH] cache_req: check all domains for lookups by certificate

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 01:50:12PM +0100, Pavel Březina wrote: > Ack. * master: 04aed439cc058413e2331e9bfbe598cc563c2c7b * sssd-1-13: ad259029b179bda7e3b6ae7ae6a858b15891b421 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [PATCHES]: Add a sketch of Samba AD DC tests

2015-11-11 Thread Nikolai Kondrashov
Hi everyone, I've worked on Samba integration tests for a while and here is where I got thus far. I'll need to resume my work on Session Recording [1] for now and will be happy if someone took the Samba work over. If not I'll return to it some time in the future. The attached patches add very

Re: [SSSD] [PATCHES] sssd_client: Do not use removed memory cache

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 05:53:15PM +0100, Michal Židek wrote: > ACK to all. > > CI link: > http://sssd-ci.duckdns.org/logs/job/32/83/summary.html > > These patches are required before Nick's LDAP tests > can be pushed (so that we can push them without the > workaround for failing memcache

Re: [SSSD] [PATCHES] sssd_client: Do not use removed memory cache

2015-11-11 Thread Michal Židek
On 11/06/2015 01:04 PM, Lukas Slebodnik wrote: On (06/11/15 12:52), Lukas Slebodnik wrote: ehlo, attached patches fix issue with memory cache in integration tests. https://fedorahosted.org/sssd/ticket/2726 LS From 2b5f31feee6aac24af5d86abab3540466d359438 Mon Sep 17 00:00:00 2001 From:

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-11-11 Thread Michal Židek
On 11/09/2015 09:19 AM, Lukas Slebodnik wrote: On (08/11/15 23:49), Michal Židek wrote: I am attaching patch that can be applied and squashed into Nick's patch. I am sending both patches to see what changes have been made, *please squash them before pushing*. This patch just removes the

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-11-11 Thread Michal Židek
On 11/11/2015 06:03 PM, Michal Židek wrote: On 11/09/2015 09:19 AM, Lukas Slebodnik wrote: On (08/11/15 23:49), Michal Židek wrote: I am attaching patch that can be applied and squashed into Nick's patch. I am sending both patches to see what changes have been made, *please squash them before

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 09:12:52AM +0100, Petr Cech wrote: > On 11/10/2015 04:20 PM, Jakub Hrozek wrote: > >On Tue, Nov 10, 2015 at 01:22:54PM +0100, Lukas Slebodnik wrote: > >>>On (10/11/15 13:15), Jakub Hrozek wrote: > >On Mon, Nov 09, 2015 at 11:32:30AM +0100, Petr Cech wrote: > > >>On

Re: [SSSD] Fix warning may be used uninitialized

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 12:03:01PM +0100, Jakub Hrozek wrote: > On Wed, Nov 11, 2015 at 11:22:03AM +0100, Pavel Březina wrote: > > On 11/10/2015 09:13 AM, Lukas Slebodnik wrote: > > >ehlo, > > > > > >and the last one patch to fix warnings on el6 > > > > > >LS > > > > Ack. > > * master:

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-11 Thread Jakub Hrozek
On Wed, Nov 11, 2015 at 11:07:46AM +0100, Petr Cech wrote: > On 11/11/2015 09:32 AM, Jakub Hrozek wrote: > >>>Hi Jakub, > >>> > >>>I just sent the patch to the CI tests and they passed > >>>http://sssd-ci.duckdns.org/logs/job/32/63/summary.html > >>> > >Then I would prefer undocumented. It

Re: [SSSD] [PATCH] cache_req: check all domains for lookups by certificate

2015-11-11 Thread Sumit Bose
On Wed, Nov 11, 2015 at 12:57:23PM +0100, Pavel Březina wrote: > On 11/10/2015 10:48 AM, Sumit Bose wrote: > >Hi, > > > >this patch is the equivalent of 374268c5eda35e8bbc2fef30752299199439cffe > >"fix upn cache_req for sub-domain users" for lookups by certificates. > > > >bye, > >Sumit > > > > >

Re: [SSSD] [PATCH] cache_req: check all domains for lookups by certificate

2015-11-11 Thread Pavel Březina
On 11/11/2015 01:28 PM, Sumit Bose wrote: On Wed, Nov 11, 2015 at 12:57:23PM +0100, Pavel Březina wrote: On 11/10/2015 10:48 AM, Sumit Bose wrote: Hi, this patch is the equivalent of 374268c5eda35e8bbc2fef30752299199439cffe "fix upn cache_req for sub-domain users" for lookups by certificates.

Re: [SSSD] [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-11 Thread Jakub Hrozek
On Mon, Nov 09, 2015 at 04:56:32PM +0100, Petr Cech wrote: > Hello, > > please see first attempt of patch for: > https://fedorahosted.org/sssd/ticket/2747 Hi, I think it's a good idea to only say we don't handle services for IPA subdomains. But I also think it would be better to shortcut the

Re: [SSSD] [PATCH] cache_req: check all domains for lookups by certificate

2015-11-11 Thread Pavel Březina
On 11/10/2015 10:48 AM, Sumit Bose wrote: Hi, this patch is the equivalent of 374268c5eda35e8bbc2fef30752299199439cffe "fix upn cache_req for sub-domain users" for lookups by certificates. bye, Sumit 0001-cache_req-check-all-domains-for-lookups-by-certifica.patch From

[SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-11 Thread Jakub Hrozek
Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! >From f6e929d4132a23d23a9016e43f4b870780c53032 Mon Sep 17 00:00:00

Re: [SSSD] [PATCHES] sssd_client: Do not use removed memory cache

2015-11-11 Thread Lukas Slebodnik
On (11/11/15 18:13), Jakub Hrozek wrote: >On Wed, Nov 11, 2015 at 05:53:15PM +0100, Michal Židek wrote: >> ACK to all. >> >> CI link: >> http://sssd-ci.duckdns.org/logs/job/32/83/summary.html >> >> These patches are required before Nick's LDAP tests >> can be pushed (so that we can push them

[SSSD] [PATCH] sbus_codegen_tests: Use portable definition of large constants

2015-11-11 Thread Lukas Slebodnik
ehlo, INT64_C(n) will expand to something appropriate for any n in (at least) a 64-bit range (see §7.18 in general, and particularly §7.18.4.1). http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf You can see a warnings only on 32 bit architecture. So the simplest reproducer is to rebuild

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-11 Thread Petr Cech
On 11/10/2015 04:20 PM, Jakub Hrozek wrote: On Tue, Nov 10, 2015 at 01:22:54PM +0100, Lukas Slebodnik wrote: >On (10/11/15 13:15), Jakub Hrozek wrote: > >On Mon, Nov 09, 2015 at 11:32:30AM +0100, Petr Cech wrote: > >>On 11/04/2015 11:24 AM, Jakub Hrozek wrote: > >> >Hi, > >> > > >> >I