On (13/11/15 11:12), Jakub Hrozek wrote:
>On Fri, Nov 13, 2015 at 08:51:17AM +0100, Lukas Slebodnik wrote:
>> ehlo,
>>
>> I found these iisues due to different size of integer and pointer
>> on el6.
>>
>> /home/build/sssd/src/tests/cmocka/test_sysdb_subdomains.c:248: error: cast
>> from
>>
Hi,
I prepared release notes page for the 1.13.2 release:
https://fedorahosted.org/sssd/wiki/Releases/Notes-1.13.2
Comments or edits are welcome!
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
On Fri, Nov 13, 2015 at 12:00:36PM +0100, Lukas Slebodnik wrote:
> On (13/11/15 11:32), Jakub Hrozek wrote:
> >On Fri, Nov 13, 2015 at 10:52:08AM +0100, Petr Cech wrote:
> >> On 11/13/2015 10:30 AM, Petr Cech wrote:
> >> >On 11/13/2015 10:27 AM, Petr Cech wrote:
> >> >>
> >> >>Patches are rebased
On 11/13/2015 11:32 AM, Jakub Hrozek wrote:
On Fri, Nov 13, 2015 at 10:52:08AM +0100, Petr Cech wrote:
>On 11/13/2015 10:30 AM, Petr Cech wrote:
> >On 11/13/2015 10:27 AM, Petr Cech wrote:
> >>
> >>Patches are rebased now. I hope it will be ok now.
> >>
> >>Petr
> >Sorry, now my local CI
On 11/13/2015 12:27 PM, Jakub Hrozek wrote:
+req_mem_ctx = talloc_new(test_ctx->tctx);
> >>+check_leaks_push(req_mem_ctx);
> >
> >I think the last question is whether we want to use this new context or
> >just call check_leaks_push(test_ctx) recursively. I don't really mind
> >too much,
On 11/13/2015 08:20 AM, Petr Cech wrote:
>Hi Jakub,
>
>it works due to your reproducer. It is really need to have
>setenforce == 1
You meant setenforce 0, right?
Hi Jakub,
yes, of course, I meant setenforce 1. It was mistake.
--^-- 1 --> 0
I did little
On Fri, Nov 13, 2015 at 08:32:55AM +0100, Petr Cech wrote:
> bump
Hi, patch 003 doesn't apply cleanly for me, can you rebase?
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On 11/13/2015 10:09 AM, Jakub Hrozek wrote:
Hi, patch 003 doesn't apply cleanly for me, can you rebase?
Patches are rebased now. I hope it will be ok now.
Petr
>From 3e43417db9b66bdb44d60b5f186156c5ac26ad4b Mon Sep 17 00:00:00 2001
From: Petr Cech
Date: Fri, 2 Oct 2015
On 11/13/2015 10:27 AM, Petr Cech wrote:
Patches are rebased now. I hope it will be ok now.
Petr
Sorry, now my local CI tests failed... I will rebase it again.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
On Fri, Nov 13, 2015 at 08:20:53AM +0100, Petr Cech wrote:
> I reviewed the code. All remarks were addressed.
> CI tests passed:
> http://sssd-ci.duckdns.org/logs/job/33/10/summary.html
>
> => ACK
>
> Regards
>
> Petr
I changed the wording of the commit message a bit (we added an option,
not a
On Fri, Nov 13, 2015 at 02:56:53PM +0100, Jakub Hrozek wrote:
> On Fri, Nov 13, 2015 at 02:27:05PM +0100, Sumit Bose wrote:
> > > +static int sbus_request_valist_check(va_list va, int first_arg_type)
> > > +{
> > > +int ret = EOK;
> > > +#ifdef HAVE_DBUSBASICVALUE
> > > +int type;
> > > +
Hi,
I meant to send the pretty-printers for some time already..
>From 2927820959e1ffdb83c8f196a9195673bc927e44 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Fri, 13 Nov 2015 16:44:45 +0100
Subject: [PATCH] CONTRIB: Add a gdb pretty-printer for ldb and sysdb_attrs
On 11/13/2015 05:44 PM, Nikolai Kondrashov wrote:
On 11/13/2015 06:19 PM, Pavel Reichl wrote:
Thanks Nick, updated patch attached.
Thanks, Pavel, this looks really neat now! I have only two comments.
+def test_simple_user_override(ldap_conn, env_simple_user_override):
+"""Test entries
Thanks Nick, updated patch attached.
>From ef503789ba6eb8618efef600e063e8031afcb0bc Mon Sep 17 00:00:00 2001
From: Pavel Reichl
Date: Mon, 5 Oct 2015 10:02:05 -0400
Subject: [PATCH] intg: Add test for user and group local overrides
Introduce a new integration test for local
On 11/13/2015 06:19 PM, Pavel Reichl wrote:
Thanks Nick, updated patch attached.
Thanks, Pavel, this looks really neat now! I have only two comments.
+def test_simple_user_override(ldap_conn, env_simple_user_override):
+"""Test entries are overriden"""
+
+
Shouldn't there be an actual
On 11/13/2015 07:06 PM, Pavel Reichl wrote:
On 11/13/2015 05:44 PM, Nikolai Kondrashov wrote:
On 11/13/2015 06:19 PM, Pavel Reichl wrote:
Thanks Nick, updated patch attached.
Thanks, Pavel, this looks really neat now! I have only two comments.
+def test_simple_user_override(ldap_conn,
On Fri, Nov 13, 2015 at 08:51:17AM +0100, Lukas Slebodnik wrote:
> ehlo,
>
> I found these iisues due to different size of integer and pointer
> on el6.
>
> /home/build/sssd/src/tests/cmocka/test_sysdb_subdomains.c:248: error: cast
> from
> pointer to integer of different size
>
> Simple patch
On (13/11/15 11:32), Jakub Hrozek wrote:
>On Fri, Nov 13, 2015 at 10:52:08AM +0100, Petr Cech wrote:
>> On 11/13/2015 10:30 AM, Petr Cech wrote:
>> >On 11/13/2015 10:27 AM, Petr Cech wrote:
>> >>
>> >>Patches are rebased now. I hope it will be ok now.
>> >>
>> >>Petr
>> >Sorry, now my local CI
On Fri, Nov 13, 2015 at 10:52:08AM +0100, Petr Cech wrote:
> On 11/13/2015 10:30 AM, Petr Cech wrote:
> >On 11/13/2015 10:27 AM, Petr Cech wrote:
> >>
> >>Patches are rebased now. I hope it will be ok now.
> >>
> >>Petr
> >Sorry, now my local CI tests failed... I will rebase it again.
>
> Well,
On Fri, Nov 13, 2015 at 12:27:03PM +0100, Jakub Hrozek wrote:
> > I have a different question. (i haven't read patches yet)
> > But I can see that check_leaks_push is called after sysdb_store_user.
> >
> > I would like to know why.
> > because we shout try to check leaks "caused" in this
On Fri, Nov 13, 2015 at 12:45:00PM +0100, Petr Cech wrote:
> >Otherwise ACK.
> Thanks.
>
> >
> >CI is still running..
>
> There is new patch set attached.
These patches look OK to me code-wise, waiting for CI results..
___
sssd-devel mailing list
On (13/11/15 13:40), Sumit Bose wrote:
>On Wed, Nov 11, 2015 at 12:00:31PM +0100, Jakub Hrozek wrote:
>> On Mon, Nov 09, 2015 at 03:14:31PM +0100, Jakub Hrozek wrote:
>> > On Mon, Nov 09, 2015 at 12:44:17PM +0100, Sumit Bose wrote:
>> > > On Fri, Nov 06, 2015 at 09:32:23PM +0100, Jakub Hrozek
On Fri, Nov 13, 2015 at 02:27:05PM +0100, Sumit Bose wrote:
> > +static int sbus_request_valist_check(va_list va, int first_arg_type)
> > +{
> > +int ret = EOK;
> > +#ifdef HAVE_DBUSBASICVALUE
> > +int type;
> > +va_list va_check;
> > +const DBusBasicValue *value;
> > +bool ok;
On Wed, Nov 11, 2015 at 12:00:31PM +0100, Jakub Hrozek wrote:
> On Mon, Nov 09, 2015 at 03:14:31PM +0100, Jakub Hrozek wrote:
> > On Mon, Nov 09, 2015 at 12:44:17PM +0100, Sumit Bose wrote:
> > > On Fri, Nov 06, 2015 at 09:32:23PM +0100, Jakub Hrozek wrote:
> > > > On Fri, Nov 06, 2015 at
On Fri, Nov 13, 2015 at 01:40:16PM +0100, Sumit Bose wrote:
> > Hi,
> >
> > attached are patches that only use sss_utf8_check() and work on RHEL-6
> > also.
>
> The patches look good and fixing the issue as expected. CI passes as
> well http://sssd-ci.duckdns.org/logs/job/33/16/summary.html (the
Hi Pavel,
On 11/13/2015 02:22 PM, Pavel Reichl wrote:
Hello Nick, thanks for the valid comments I hope I addressed them all.
I used the dictionary hint, but I didn't use it everywhere - mostly just
where the same dict would be reused in the same function.
Sure, thank you.
On 11/03/2015
Hello Nick, thanks for the valid comments I hope I addressed them all.
I used the dictionary hint, but I didn't use it everywhere - mostly just where
the same dict would be reused in the same function.
On 11/03/2015 04:40 PM, Nikolai Kondrashov wrote:
+
+# We can create override with
On Fri, Nov 13, 2015 at 02:08:59PM +0100, Jakub Hrozek wrote:
> On Fri, Nov 13, 2015 at 01:40:16PM +0100, Sumit Bose wrote:
> > > Hi,
> > >
> > > attached are patches that only use sss_utf8_check() and work on RHEL-6
> > > also.
> >
> > The patches look good and fixing the issue as expected. CI
28 matches
Mail list logo