[SSSD] [PATCH] Warn if ad_server contains IP address

2016-02-24 Thread Justin Stephenson
First patch, see attached. This is for easy fix from ticket https://fedorahosted.org/sssd/ticket/2789 I am going on the assumption that if the first 2 characters of ad_server are digits then it is likely an IP address and not hostname. If you have a better idea for this please let me know.

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 16:43), Jakub Hrozek wrote: >We don't know the group name at that point yet, so better not print >"null" in the debug message.. >From ffdc00755a9fbaeb54f781956a0025719e532b11 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Tue, 26 Jan 2016 16:29:08 +0100

[SSSD] Re: [PATCH] build: detect endianness at configure time

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 17:47), Lukas Slebodnik wrote: >On (24/02/16 17:18), David Disseldorp wrote: >>From: David Disseldorp >> >>WORDS_BIGENDIAN, HAVE_BIG_ENDIAN and HAVE_LITTLE_ENDIAN are needed by >>Samba. See Samba's byteorder.h header for an example. >> >>Signed-off-by: David

[SSSD] Re: [PATCH] build: detect endianness at configure time

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 17:18), David Disseldorp wrote: >From: David Disseldorp > >WORDS_BIGENDIAN, HAVE_BIG_ENDIAN and HAVE_LITTLE_ENDIAN are needed by >Samba. See Samba's byteorder.h header for an example. > >Signed-off-by: David Disseldorp >--- > configure.ac | 3 +++ >

[SSSD] [PATCH] build: detect endianness at configure time

2016-02-24 Thread David Disseldorp
From: David Disseldorp WORDS_BIGENDIAN, HAVE_BIG_ENDIAN and HAVE_LITTLE_ENDIAN are needed by Samba. See Samba's byteorder.h header for an example. Signed-off-by: David Disseldorp --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git

[SSSD] Re: [DESIGN] Invalidate cached sudo rules

2016-02-24 Thread Petr Cech
On 02/24/2016 04:28 PM, Jakub Hrozek wrote: On Tue, Feb 23, 2016 at 04:08:52PM +0100, Petr Cech wrote: Hello, I've started the design page for Invalidating cached sudo rules here: https://fedorahosted.org/sssd/wiki/DesignDocs/SUDOCachingRulesInvalidate This task consists of two tickets (see

[SSSD] [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-02-24 Thread Jakub Hrozek
We don't know the group name at that point yet, so better not print "null" in the debug message.. >From ffdc00755a9fbaeb54f781956a0025719e532b11 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Tue, 26 Jan 2016 16:29:08 +0100 Subject: [PATCH] LDAP: Do not print "null" in the

[SSSD] [PATCH] IPA: Use the common if-else coding style

2016-02-24 Thread Jakub Hrozek
This is just a code-style patch, but I got confused by the two if statements, they made me think they were unrelated.. >From 20259fe42b8cec38b913c17a6b5be2e6456a31d3 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 22 Feb 2016 10:56:52 +0100 Subject: [PATCH] IPA: Use the

[SSSD] Re: libini - config file validity checks

2016-02-24 Thread Michal Židek
On 02/24/2016 04:30 PM, Jakub Hrozek wrote: On Wed, Feb 24, 2016 at 04:20:10PM +0100, Michal Židek wrote: On 02/23/2016 09:17 PM, Jakub Hrozek wrote: On Tue, Feb 23, 2016 at 05:06:57PM +0100, Michal Židek wrote: On 02/22/2016 09:21 AM, Jakub Hrozek wrote: On Fri, Feb 19, 2016 at 04:35:38PM

[SSSD] [PATCH] tests: Extend test_child_common.c to include tests for the only_extra_args functionality

2016-02-24 Thread Jakub Hrozek
Hi, the attached patch was already acked by Sumit as part of the adcli thread, so I'd like to push it now. >From 52003e9d03a38e863b46bb25fffd803ecf1716e5 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 15 Jan 2016 11:24:11 +0100 Subject: [PATCH] tests: Extend

[SSSD] Re: libini - config file validity checks

2016-02-24 Thread Jakub Hrozek
On Wed, Feb 24, 2016 at 04:20:10PM +0100, Michal Židek wrote: > On 02/23/2016 09:17 PM, Jakub Hrozek wrote: > >On Tue, Feb 23, 2016 at 05:06:57PM +0100, Michal Židek wrote: > >>On 02/22/2016 09:21 AM, Jakub Hrozek wrote: > >>>On Fri, Feb 19, 2016 at 04:35:38PM +0100, Michal Židek wrote: >

[SSSD] Re: [DESIGN] Invalidate cached sudo rules

2016-02-24 Thread Jakub Hrozek
On Tue, Feb 23, 2016 at 04:08:52PM +0100, Petr Cech wrote: > Hello, > > I've started the design page for Invalidating cached sudo rules here: > https://fedorahosted.org/sssd/wiki/DesignDocs/SUDOCachingRulesInvalidate > > This task consists of two tickets (see below). So far, I have worked on the

[SSSD] Re: libini - config file validity checks

2016-02-24 Thread Michal Židek
On 02/23/2016 09:17 PM, Jakub Hrozek wrote: On Tue, Feb 23, 2016 at 05:06:57PM +0100, Michal Židek wrote: On 02/22/2016 09:21 AM, Jakub Hrozek wrote: On Fri, Feb 19, 2016 at 04:35:38PM +0100, Michal Židek wrote: Thank you for comments! See my response. On 02/19/2016 12:18 PM, Jakub Hrozek

[SSSD] [PATCH] memberof: Don't allocate on a NULL context

2016-02-24 Thread Jakub Hrozek
Hi, the attached patch fixes: https://fedorahosted.org/sssd/ticket/2959 It was confirmed by the original reporter. The bug was there since 2009, by the way, I'm really suprised we only caught it now.. >From 0e734587a8fc4bb0160a2a7cbb5fae2054d5283c Mon Sep 17 00:00:00 2001 From: Jakub Hrozek

[SSSD] Re: [PATCH] remove user certificate if not found on the server

2016-02-24 Thread Sumit Bose
On Wed, Feb 24, 2016 at 10:31:31AM +0100, Pavel Březina wrote: > On 02/23/2016 02:09 PM, Sumit Bose wrote: > >On Tue, Feb 23, 2016 at 01:24:30PM +0100, Pavel Březina wrote: > >>https://fedorahosted.org/sssd/ticket/2934 > > > >> From 94ae3c5231dc7f1cd9f9d172d13a11a8afcacd16 Mon Sep 17 00:00:00 2001

[SSSD] Re: [PATCH] Resolve IPA external group members during getgr* requests

2016-02-24 Thread Jakub Hrozek
On Wed, Feb 24, 2016 at 01:17:27PM +0100, Sumit Bose wrote: > On Tue, Feb 23, 2016 at 09:37:57PM +0100, Jakub Hrozek wrote: > > On Mon, Feb 22, 2016 at 06:04:07PM +0100, Jakub Hrozek wrote: > > > Hi, > > > > > > the attached patches implement https://fedorahosted.org/sssd/ticket/2522 > > > > > >

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 14:01), Lukas Slebodnik wrote: >On (24/02/16 12:47), Petr Cech wrote: >>On 02/23/2016 03:28 PM, Lukas Slebodnik wrote: >>>On (23/02/16 08:28), Petr Cech wrote: On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: [...] >>>Hello Lukas, >>> >>>thank you for

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 12:47), Petr Cech wrote: >On 02/23/2016 03:28 PM, Lukas Slebodnik wrote: >>On (23/02/16 08:28), Petr Cech wrote: >>>On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: >>> >>>[...] >>> >>Hello Lukas, >> >>thank you for careful code review. I addressed all comments and I found

[SSSD] Re: [PATCH] Resolve IPA external group members during getgr* requests

2016-02-24 Thread Sumit Bose
On Tue, Feb 23, 2016 at 09:37:57PM +0100, Jakub Hrozek wrote: > On Mon, Feb 22, 2016 at 06:04:07PM +0100, Jakub Hrozek wrote: > > Hi, > > > > the attached patches implement https://fedorahosted.org/sssd/ticket/2522 > > > > Here is what I tested: > > 1) topgr -> bottomgr -> extgr ->

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-24 Thread Petr Cech
On 02/23/2016 03:28 PM, Lukas Slebodnik wrote: On (23/02/16 08:28), Petr Cech wrote: On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: [...] Hello Lukas, thank you for careful code review. I addressed all comments and I found memory leak in original colondb tool. Patch of memory leak is