[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ New patch set pushed and in the end the changes were not intrusive at all. @pbrezina, I've partially taken your idea (with some changes). Please, let

[SSSD] [sssd PR#246][synchronized] filter_users and filter_groups stop working properly in v 1.15

2017-04-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Author: fidencio Title: #246: filter_users and filter_groups stop working properly in v 1.15 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/246/head:pr246 git checkout pr246

[SSSD] [sssd PR#248][edited] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-25 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: edited Changed field: body Original value: """ This patch is piggyback This patch improves the log message to be more information for

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-25 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297100901

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-25 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297100893

[SSSD] [sssd PR#248][opened] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-25 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: opened PR body: """ This patch is piggyback This patch improves the log message to be more information for the SSSD user

[SSSD] [sssd PR#136][comment] Tlog integration

2017-04-25 Thread spbnick
URL: https://github.com/SSSD/sssd/pull/136 Title: #136: Tlog integration spbnick commented: """ BTW, should I perhaps include an update to the sssd.conf man page? """ See the full comment at https://github.com/SSSD/sssd/pull/136#issuecomment-297017382

[SSSD] [sssd PR#136][comment] Tlog integration

2017-04-25 Thread spbnick
URL: https://github.com/SSSD/sssd/pull/136 Title: #136: Tlog integration spbnick commented: """ Hi Pavel, thank you for your review! I'll be addressing your comments soon, but for now here is how to test this. The patches add support for a new section in sssd.conf: `session_recording`. The

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side fidencio commented: """ On Tue, Apr 25, 2017 at 1:56 PM, Pavel Březina wrote: > Yes, I think we should log it so we

[SSSD] [sssd PR#235][synchronized] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/235 Author: fidencio Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side pbrezina commented: """ Yes, I think we should log it so we know what's used when we will debug issues :-) """ See the full comment at

[SSSD] [sssd PR#136][comment] Tlog integration

2017-04-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/136 Title: #136: Tlog integration pbrezina commented: """ Hi, here are some comments. Mostly nitpicks. Can you also share some link how to enable tlog and test this code? * **CACHE_REQ: Rename search_domains_done to search_domains_next_done```** As far

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 lslebodn commented: """ On (25/04/17 03:59), fidencio wrote: >On Tue, Apr 25, 2017 at 12:16 PM, Pavel Březina >wrote: > >> Hi, we should solve this

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Tue, Apr 25, 2017 at 12:16 PM, Pavel Březina wrote: > Hi, we should solve this on cache_req level so we get the same

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side fidencio commented: """ On Tue, Apr 25, 2017 at 12:37 PM, Pavel Březina wrote: > Thank you. Last trivial change, you

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side pbrezina commented: """ Thank you. Last trivial change, you have typo in commit message (domaiN): `RESPONDER_COMMON: Improve

[SSSD] [sssd PR#247][comment] Subdomain inherit

2017-04-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit lslebodn commented: """ This patch set modified the function `check_subdom_config_file` which is called from the function `new_subdomain`. And this function is already tested in unitests. ``` sh$ git grep

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ This is really from top of my mind, there may be another, easier way to do it. But we should do it on cache_req level. """ See the full comment at

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-25 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ Hi, we should solve this on `cache_req` level so we get the same resultt in `nss` and `ifp` (and others) responders. What I had in mind was to create

[SSSD] [sssd PR#247][comment] Subdomain inherit

2017-04-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit lslebodn commented: """ This patch set modified the function `check_subdom_config_file` which is called from the function `new_subdomain`. And this function is already tested in unitests. ``` sh$ git grep

[SSSD] [sssd PR#247][+Changes requested] Subdomain inherit

2017-04-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#247][opened] Subdomain inherit

2017-04-25 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/247 Author: mzidek-rh Title: #247: Subdomain inherit Action: opened PR body: """ I tested if the options that work in subdomain inherit also work in trusted domain section in sssd.conf. Most seem to work without any changes in the code except for two.