[SSSD] [sssd PR#476][comment] IPA: Handle empty nisDomainName

2018-01-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/476 Title: #476: IPA: Handle empty nisDomainName fidencio commented: """ Patch looks good, although I don't know how to reproduce the issue. Would be possible to add steps to reproduce (either here or in the pagure issue)? ps: I'm not adding myself as a

[SSSD] [sssd PR#484][+Changes requested] SDAP: skip builtin AD groups in sdap_save_grpmem()

2018-01-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/484 Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem() Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#481][comment] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-01-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn fidencio commented: """ > "But still I am not sure should -Wsuggest-attribute=noreturn go in > Makefile.am or elsewhere.." @amitkumar50, please, take a look at #378 in the first