URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn
fidencio commented: """ > "But still I am not sure should -Wsuggest-attribute=noreturn go in > Makefile.am or elsewhere.." @amitkumar50, please, take a look at #378 in the first place. Here's the place where you should **remove** the warning: https://github.com/SSSD/sssd/pull/378/files#diff-f58315bc70c0ac2bfe8c883fe389cc6fR37 But, please, I'd like to ask for **no action** till #378 is merged for two reasons: - There's no guarantee that the PR will be merged. It's been opened for more than one year and there's a big chance it'll just be closed due to the lack of the interest of the SSSD team on having the patches merged; - Once you remove the warning as I've suggested and rebase your patches atop of mine, you'll have a lot of work to actually suppress the warning on difference parts of the code. Spending time on this without having some idea about whether #378 will be merged or not is not the best approach (as working on something that is never going to be merged may be frustrating). Also, I'd like to ask you to ping me on the internal IRC so we can go through the process of firing internal CI builds, as we have to be sure the patches will pass there (when they're rebased atop of #378) and have the manywarnings file updated accordingly. Thanks for your contribution and, please, **let's wait till #378 is merged before taking any action here**. """ See the full comment at https://github.com/SSSD/sssd/pull/481#issuecomment-354652124
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
