URL: https://github.com/SSSD/sssd/pull/945
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
sumit-bose commented:
"""
The latest version should address all your comments.
Thanks.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/945#issuecomment-559691848
URL: https://github.com/SSSD/sssd/pull/945
Author: sumit-bose
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/945/head:pr945
git checkout pr945
From
URL: https://github.com/SSSD/sssd/pull/945
Author: sumit-bose
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/945/head:pr945
git checkout pr945
From
URL: https://github.com/SSSD/sssd/pull/945
Author: sumit-bose
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/945/head:pr945
git checkout pr945
From
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
sumit-bose commented:
"""
Thanks, no further comments. ACK
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/948#issuecomment-559672168
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
F29 failed `test_enumeration.py::test_add_remove_membership_rfc2307`...
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/945
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/945
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
alexey-tikhonov commented:
"""
I only have a couple of minor remarks. Please see comments inline.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/945#issuecomment-559619960
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
alexey-tikhonov commented:
"""
> I only have the comment about salt_len, otherwise the patches are looking
> good.
Fixed.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/948
Author: alexey-tikhonov
Title: #948: Proper zeroization of sensitive data
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/948/head:pr948
git checkout pr948
From
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
sumit-bose commented:
"""
I only have the comment about salt_len, otherwise the patches are looking good.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/948#issuecomment-559560169
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/948
Title: #948: Proper zeroization of sensitive data
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/946
Title: #946: INI: sssctl config-check giving the wrong message
thalman commented:
"""
@mzidek-rh thanks for review, Fixed, test included
"""
See the full comment at
https://github.com/SSSD/sssd/pull/946#issuecomment-559548188
URL: https://github.com/SSSD/sssd/pull/946
Author: thalman
Title: #946: INI: sssctl config-check giving the wrong message
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/946/head:pr946
git checkout pr946
From
URL: https://github.com/SSSD/sssd/pull/946
Author: thalman
Title: #946: INI: sssctl config-check giving the wrong message
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/946/head:pr946
git checkout pr946
From
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
Thank you both for your time. I amended in-code comments and commit messages.
1) About files provider.
You are right that the sleep is suppose to eliminated race
URL: https://github.com/SSSD/sssd/pull/947
Author: pbrezina
Title: #947: tests: fix race conditions in integration tests
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/947/head:pr947
git checkout pr947
From
URL: https://github.com/SSSD/sssd/pull/949
Title: #949: ssh: apply certificate matching rules
sumit-bose commented:
"""
The latest version include fixes for more general issues which make sense to be
fixed here as well.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/945
Author: sumit-bose
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/945/head:pr945
git checkout pr945
From
URL: https://github.com/SSSD/sssd/pull/945
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
sumit-bose commented:
"""
The latest version just squashes the second patch into the first.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/945#issuecomment-559506020
URL: https://github.com/SSSD/sssd/pull/949
Author: sumit-bose
Title: #949: ssh: apply certificate matching rules
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/949/head:pr949
git checkout pr949
From
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> @pbrezina, Hi Pavel :)
> I don't really remember, sorry, but looking at the code now it might be to
> avoid racing with SSSD initialization, while making the
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> @pbrezina, Hi Pavel :)
> I don't really remember, sorry, but looking at the code now it might be to
> avoid racing with SSSD initialization, while making the
URL: https://github.com/SSSD/sssd/pull/946
Author: thalman
Title: #946: INI: sssctl config-check giving the wrong message
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/946/head:pr946
git checkout pr946
From
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
spbnick commented:
"""
@pbrezina, Hi Pavel :)
I don't really remember, sorry, but looking at the code now it might be to
avoid racing with SSSD initialization, while making the change before
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> > tl,dr: I'm not categorically against estimation of REAL_ENUMERATION_TIMEOUT
> > as 2*ENUMERATION_TIMEOUT.
> > But IMO this has nothing to do with Nyquist
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> Sorry if I was not clear enough.
> I was talking about different bug/race: when updated data are requested
> _before_ files_provider even started update.
>
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
> tl,dr: I'm not categorically against estimation of REAL_ENUMERATION_TIMEOUT
> as 2*ENUMERATION_TIMEOUT.
> But IMO this has nothing to do with Nyquist frequency and
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> About files provider tests: I checked if there is a bug that you mentioned
> and no. There does not seem to be any bug, though the behavior is not the
>
URL: https://github.com/SSSD/sssd/pull/947
Author: pbrezina
Title: #947: tests: fix race conditions in integration tests
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/947/head:pr947
git checkout pr947
From
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> Enumeration is run periodically. It is scheduled during SSSD startup and then
> it runs every four seconds. We do not know precisely when the enumeration
>
URL: https://github.com/SSSD/sssd/pull/947
Author: pbrezina
Title: #947: tests: fix race conditions in integration tests
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/947/head:pr947
git checkout pr947
From
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
Enumeration is run periodically. It is scheduled during SSSD startup and then
it runs every four seconds. We do not know precisely when the enumeration
refresh is
URL: https://github.com/SSSD/sssd/pull/945
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
sumit-bose commented:
"""
Hi @alexey-tikhonov,
thanks for the review, the latest commit should cover all your comments
including the date.
bye,
Sumit
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/945
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/945
Author: sumit-bose
Title: #945: p11_child: add 'soft_ocsp' and 'soft_crl options
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/945/head:pr945
git checkout pr945
From
41 matches
Mail list logo
