URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
> In other words, you think it is safer to have INTERACTIVE_TIMEOUT*2 where the
> previous /2 was?
Actually I liked initial Pavel's approach
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> > > `poll_canary` has no meaning as we currently block when refreshing the
> > > cache. We can either remove it or report a bug against sssd that it
> > >
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
alexey-tikhonov commented:
"""
> > > `poll_canary` has no meaning as we currently block when refreshing the
> > > cache. We can either remove it or report a bug against sssd that it
> > >
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
mzidek-rh commented:
"""
In other words, you think it is safer to have INTERACTIVE_TIMEOUT*2 where the
previous /2 was? I think it makes sense. As I mentioned previously, I think
that this
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Fixed the unused variable, and added a check for a NULL reply when searching
the host sid. Also added a computer_timeout option.
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Fixed the unused variable, and added a check for a NULL reply when searching
the host sid.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/905
Author: dmulder
Title: #905: Don't ignore host entries in Group Policy security filters
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/905/head:pr905
git checkout pr905
From
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
> ```
> warning: Loadable section ".note.gnu.property" outside of ELF segments
> Core was generated by `/usr/libexec/sssd/sssd_be --domain ad.vm --uid 0
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
> ```
> warning: Loadable section ".note.gnu.property" outside of ELF segments
> Core was generated by `/usr/libexec/sssd/sssd_be --domain ad.vm --uid 0
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
> there can be leftovers from previous test run in the passwd result
> (enumeration) after the fixture with function scope was executed, but the
> enumeration
URL: https://github.com/SSSD/sssd/pull/957
Title: #957: ci: add RHEL 7
mzidek-rh commented:
"""
ACK.
@pbrezina
Just a comment. Do you know about a way to put the mock results into a
subfolder or maybe prefix them with some string (for example mock-). It looks a
but messy with all the
URL: https://github.com/SSSD/sssd/pull/957
Title: #957: ci: add RHEL 7
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
mzidek-rh commented:
"""
In case we do clean the cache (rm) before each test run, the problem may be
that the changes in LDAP were kind of slow to propagate after the fixture with
function
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
mzidek-rh commented:
"""
The problem with these tests is that ldap_conn has scope=module and the fixture
that fills the ldap contents before the test has scope=function (default), so
there
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
For detailed discussion see #947
"""
See the full comment at
https://github.com/SSSD/sssd/pull/956#issuecomment-562181499
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Please, take a note, I do not remove 'accepted' label.
What I want is to clarify test design so asking if you understand it. If no,
well, I will have to figure
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I agree with the reasoning for this patch. ACK.
Do you by any chance have an explanation for this
`time.sleep(INTERACTIVE_TIMEOUT/2)`
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I agree with the reasoning for this patch. ACK.
Do you by any chance have an explanation for the this
`time.sleep(INTERACTIVE_TIMEOUT/2)`
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I agree with the reasoning for this patch. ACK.
Do you by any chance have an explanation for the this
`time.sleep(INTERACTIVE_TIMEOUT/2)`
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I agree with the reasoning for this patch. ACK.
Do you by any chance have an explanation for the this
`time.sleep(INTERACTIVE_TIMEOUT/2)`
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I agree with the reasoning for this patch. ACK.
Do you by any chance have an explanation for the this
`time.sleep(INTERACTIVE_TIMEOUT/2)`
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I agree with the reasoning for this patch. ACK.
Do you by any chance have an explanation for the this
`time.sleep(INTERACTIVE_TIMEOUT/2)`
URL: https://github.com/SSSD/sssd/pull/944
Title: #944: 1.16: backport recent sudo improvements
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/944
Title: #944: 1.16: backport recent sudo improvements
mzidek-rh commented:
"""
I think the changes are OK as they were reviewed before and only backported to
1.16, the patches were tested by a user, some very basic sanity testing was
done and no
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/956
Title: #956: tests: fix race confition in enumeration tests
mzidek-rh commented:
"""
I agree with the reasoning for this patch. ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/956#issuecomment-562150939
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
```
/home/pbrezina/workspace/sssd/src/db/sysdb_computer.c: In function
‘sysdb_search_computer’:
URL: https://github.com/SSSD/sssd/pull/957
Author: pbrezina
Title: #957: ci: add RHEL 7
Action: opened
PR body:
"""
Add a RHEL 7 host to PR CI.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/957/head:pr957
git checkout pr957
From
URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests
pbrezina commented:
"""
Actually, as Alexey pointer out from [my
comment](https://github.com/SSSD/sssd/pull/947#issuecomment-562093538)
`dp_sbus` calls in `sf_passwd|group_cb` are useless
URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests
Label: +Blocked
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests
alexey-tikhonov commented:
"""
For detailed discussion see #947
"""
See the full comment at
https://github.com/SSSD/sssd/pull/955#issuecomment-562105150
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
* https://github.com/SSSD/sssd/pull/955 Files provider.
* https://github.com/SSSD/sssd/pull/956 Enumeration.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/947
Author: pbrezina
Title: #947: tests: fix race conditions in integration tests
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/947/head:pr947
git checkout pr947
URL: https://github.com/SSSD/sssd/pull/956
Author: pbrezina
Title: #956: tests: fix race confition in enumeration tests
Action: opened
PR body:
"""
Resubmitting Fabiano's PR since the tests kept failing for last two years
with no reason. This needs to be fixed.
---
INTG: Increase the
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
Label: +superseded
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
* https://github.com/SSSD/sssd/pull/956 Files provider.
* https://github.com/SSSD/sssd/pull/956 Enumeration.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/955
Author: pbrezina
Title: #955: tests: fix race confition in files provider tests
Action: opened
PR body:
"""
Lets give files provider more time to load changes from files to avoid
race condition failures. The files provider tests works like this:
1.
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
> Lets see what other will say. If your patch will not be merged I will try my
> best to investigate issue and explain `INTERACTIVE_TIMEOUT/2`
Fair enough. I will
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
You actually don't even need to call `sss_cache -E` because files provider
invalidates memory cache on its own:
URL: https://github.com/SSSD/sssd/pull/947
Title: #947: tests: fix race conditions in integration tests
pbrezina commented:
"""
> I. `test_files_provider.py`
>
> > `poll_canary` has no meaning as we currently block when refreshing the
> > cache. We can either remove it or report a bug against
45 matches
Mail list logo
