[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information mzidek-rh commented: """ Sorry to jump late to the conversation, but I want to request one change to the patch. We should really not use the word "subdomain" in an

[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information mzidek-rh commented: """ Sorry to jump late to the conversation, but I want to request one change to the patch. We should really not use the word "subdomain" in an

[SSSD] [sssd PR#285][-Accepted] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#247][comment] Subdomain inherit

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit mzidek-rh commented: """ @lslebodn the downstream bugs were moved to later milestone, but we still need to do it... unfortunately something with higher priority always pops up... I hope to get back to t

[SSSD] [sssd PR#296][synchronized] TESTS: Add one config-check test case

2017-06-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/296 Author: mzidek-rh Title: #296: TESTS: Add one config-check test case Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/296/head:pr296 git checkout pr296 From

[SSSD] [sssd PR#296][opened] TESTS: Add one config-check test case

2017-06-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/296 Author: mzidek-rh Title: #296: TESTS: Add one config-check test case Action: opened PR body: """ Add test case with wrong subdomain section format, where the too many domains are used to identify the trusted domain instead of jus

[SSSD] [sssd PR#292][+Accepted] Test config check

2017-06-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/292 Title: #292: Test config check Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#292][comment] Test config check

2017-06-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/292 Title: #292: Test config check mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/292#issuecomment-305444789 ___ sssd-de

[SSSD] [sssd PR#292][comment] Test config check

2017-05-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/292 Title: #292: Test config check mzidek-rh commented: """ I will run it through CI and Ack when it finishes. """ See the full comment at https://github.com/SSSD/sssd/pull/292#issuecomment-305234528 __

[SSSD] [sssd PR#226][-Changes requested] Config check regex

2017-05-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#226][comment] Config check regex

2017-05-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex mzidek-rh commented: """ Added new patch with sssd specific validator + unit test for it. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-05-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#226][-Changes requested] Config check regex

2017-05-30 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#226][comment] Config check regex

2017-05-30 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex mzidek-rh commented: """ I added one small patch to apply the same restrictions we have on domain section to the application section. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-05-30 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-05-30 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#226][comment] Config check regex

2017-05-30 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex mzidek-rh commented: """ Pushed new version. Added a patch to fix the man page typo in trusted domain section. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#226][comment] Config check regex

2017-05-30 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex mzidek-rh commented: """ About the inherit_from ... please read the first comment in this PR. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#226][comment] Config check regex

2017-05-29 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex mzidek-rh commented: """ Pushed the new version, the tests are now not built for rhel6 because they need new libini. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-05-29 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#226][comment] Config check regex

2017-05-26 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Title: #226: Config check regex mzidek-rh commented: """ Pushed the unit test. They should be easy to extend. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-05-26 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ Ok, I changed the level from CRIT_FAILURE to MINOR_FAILURE. Or does someone prefer to fail completely in that case? The reason I decided to continue is tha

[SSSD] [sssd PR#270][synchronized] Subdomains direct integration

2017-05-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Author: mzidek-rh Title: #270: Subdomains direct integration Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/270/head:pr270 git checkout pr270 From

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ Commit message updated (otherwise no changes). """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#270][synchronized] Subdomains direct integration

2017-05-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Author: mzidek-rh Title: #270: Subdomains direct integration Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/270/head:pr270 git checkout pr270 From

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-17 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ The scratch build fixed the issue for the BZ reporter. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ Ok, I just sent a scratch build link to the BZ. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ You are correct Alexander, it could have been confusing. I changed it as you suggested. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#270][synchronized] Subdomains direct integration

2017-05-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Author: mzidek-rh Title: #270: Subdomains direct integration Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/270/head:pr270 git checkout pr270 From

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ I updated the commit message a little and linked it with new issue. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#270][synchronized] Subdomains direct integration

2017-05-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Author: mzidek-rh Title: #270: Subdomains direct integration Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/270/head:pr270 git checkout pr270 From

[SSSD] [sssd PR#270][comment] Subdomains direct integration

2017-05-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Title: #270: Subdomains direct integration mzidek-rh commented: """ Btw, we fixed practically the same issue in IPA subdomains code (from users perspective). The code for direct integration is completely different, but maybe we could

[SSSD] [sssd PR#270][opened] Subdomains direct integration

2017-05-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/270 Author: mzidek-rh Title: #270: Subdomains direct integration Action: opened PR body: """ Note: I know the commit message misses an issue number. I will add it tomorrow when I clone the BZ. However this should not block the revie

[SSSD] [sssd PR#254][comment] Handling of sdap_domain lists in server mode

2017-05-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/254 Title: #254: Handling of sdap_domain lists in server mode mzidek-rh commented: """ Sorry, I accidentally pushed the patches to a different branch before. Now I pushed them to this one. """ See the full comment at htt

[SSSD] [sssd PR#254][synchronized] Handling of sdap_domain lists in server mode

2017-05-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/254 Author: mzidek-rh Title: #254: Handling of sdap_domain lists in server mode Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/254/head:pr254 git checkout pr254 From

[SSSD] [sssd PR#254][comment] Handling of sdap_domain lists in server mode

2017-05-03 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/254 Title: #254: Handling of sdap_domain lists in server mode mzidek-rh commented: """ Thank you for the review. New version pushed. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#253][comment] Use the ad_account_can_shortcut function in sssd server mode

2017-05-02 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/253 Title: #253: Use the ad_account_can_shortcut function in sssd server mode mzidek-rh commented: """ ACK. CI (the failure on RHEL6 is not related): http://sssd-ci.duckdns.org/logs/job/68/90/summary.html Michal """

[SSSD] [sssd PR#254][opened] Handling of sdap_domain lists in server mode

2017-04-28 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/254 Author: mzidek-rh Title: #254: Handling of sdap_domain lists in server mode Action: opened PR body: """ SERVER_MODE: Update sdap lists for each ad_ctx We use separate AD context for each subdomain in the server mode. Eve

[SSSD] [sssd PR#250][comment] cache_req: Use ternary operator instead of bool+switch

2017-04-28 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/250 Title: #250: cache_req: Use ternary operator instead of bool+switch mzidek-rh commented: """ LGTM++ """ See the full comment at https://github.com/SSSD/sssd/pull/250#issuecomment-297988213

[SSSD] [sssd PR#247][comment] Subdomain inherit

2017-04-27 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit mzidek-rh commented: """ I forgot to comment on this. In order to add tests for this I first need to fix the https://pagure.io/SSSD/sssd/issue/3338 otherwise it would be double work. I already started doi

[SSSD] [sssd PR#250][comment] cache_req: Use ternary operator instead of bool+switch

2017-04-27 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/250 Title: #250: cache_req: Use ternary operator instead of bool+switch mzidek-rh commented: """ What about: ``` if (head->fqnames) { return true; } else if (enforce_non_fqnames) { return false; } else

[SSSD] [sssd PR#247][opened] Subdomain inherit

2017-04-25 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/247 Author: mzidek-rh Title: #247: Subdomain inherit Action: opened PR body: """ I tested if the options that work in subdomain inherit also work in trusted domain section in sssd.conf. Most seem to work without any changes in the code

[SSSD] [sssd PR#233][-Changes requested] SDAP: Fix handling of search bases

2017-04-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#233][comment] SDAP: Fix handling of search bases

2017-04-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases mzidek-rh commented: """ Updated patch pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/233#issuecomment-295791320

[SSSD] [sssd PR#233][synchronized] SDAP: Fix handling of search bases

2017-04-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/233 Author: mzidek-rh Title: #233: SDAP: Fix handling of search bases Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/233/head:pr233 git checkout pr233 From

[SSSD] [sssd PR#193][+Accepted] UTIL: Use max 15 characters for AD host UPN

2017-04-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/193 Title: #193: UTIL: Use max 15 characters for AD host UPN Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#193][comment] UTIL: Use max 15 characters for AD host UPN

2017-04-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/193 Title: #193: UTIL: Use max 15 characters for AD host UPN mzidek-rh commented: """ ACK. CI (fail on rhel6 with enum tests is unrelated): http://sssd-ci.duckdns.org/logs/job/67/87/summary.html """ See the full comment at

[SSSD] [sssd PR#193][comment] UTIL: Use max 15 characters for AD host UPN

2017-04-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/193 Title: #193: UTIL: Use max 15 characters for AD host UPN mzidek-rh commented: """ Everything works as expected. Just waiting for the CI to finish. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#193][comment] UTIL: Use max 15 characters for AD host UPN

2017-04-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/193 Title: #193: UTIL: Use max 15 characters for AD host UPN mzidek-rh commented: """ A rather important nitpick :) ``` diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c index 8dfb6af..a3f066e 100644 --- a/src/util/sss_krb5.c +++ b/sr

[SSSD] [sssd PR#233][opened] SDAP: Fix handling of search bases

2017-04-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/233 Author: mzidek-rh Title: #233: SDAP: Fix handling of search bases Action: opened PR body: """ We were rewriting the sdap_domain's search bases for only the first sdap_domain in the list, which does not work for subdomains. Also wh

[SSSD] [sssd PR#227][comment] CONFDB: Fix handling of enable_files_domain

2017-04-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/227 Title: #227: CONFDB: Fix handling of enable_files_domain mzidek-rh commented: """ Oh, I did not notice, you posted CI results before. It is an ACK then. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#227][+Accepted] CONFDB: Fix handling of enable_files_domain

2017-04-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/227 Title: #227: CONFDB: Fix handling of enable_files_domain Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#227][comment] CONFDB: Fix handling of enable_files_domain

2017-04-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/227 Title: #227: CONFDB: Fix handling of enable_files_domain mzidek-rh commented: """ LGTM. I tested with both --enable/disable-files domain and true/false enable_files_domain in sssd.conf. I will give you an ack when CI finishes. &q

[SSSD] [sssd PR#165][comment] selinux: Do not fail if SELinux is not managed

2017-04-05 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Title: #165: selinux: Do not fail if SELinux is not managed mzidek-rh commented: """ New version pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/165#issuecomment-291889506 __

[SSSD] [sssd PR#165][synchronized] selinux: Do not fail if SELinux is not managed

2017-04-05 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Author: mzidek-rh Title: #165: selinux: Do not fail if SELinux is not managed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/165/head:pr165 git checkout pr165 From

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-04-05 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#226][synchronized] Config check regex

2017-04-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/226/head:pr226 git checkout pr226 From

[SSSD] [sssd PR#226][opened] Config check regex

2017-04-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/226 Author: mzidek-rh Title: #226: Config check regex Action: opened PR body: """ Some updates for src/config/cfg_rules.ini The most controversial is the third patch. It removes the special rule for application domains and only uses the

[SSSD] [sssd PR#165][comment] selinux: Do not fail if SELinux is not managed

2017-04-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Title: #165: selinux: Do not fail if SELinux is not managed mzidek-rh commented: """ New version pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/165#issuecomment-291572183 __

[SSSD] [sssd PR#165][synchronized] selinux: Do not fail if SELinux is not managed

2017-04-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Author: mzidek-rh Title: #165: selinux: Do not fail if SELinux is not managed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/165/head:pr165 git checkout pr165 From

[SSSD] [sssd PR#165][comment] selinux: Do not fail if SELinux is not managed

2017-04-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Title: #165: selinux: Do not fail if SELinux is not managed mzidek-rh commented: """ Update version pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/165#issuecomment-291501202 __

[SSSD] [sssd PR#165][synchronized] selinux: Do not fail if SELinux is not managed

2017-04-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Author: mzidek-rh Title: #165: selinux: Do not fail if SELinux is not managed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/165/head:pr165 git checkout pr165 From

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-03-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ On 03/31/2017 03:44 PM, lslebodn wrote: > On (31/03/17 06:34), mzidek-rh wrote: >>Actually, I looking at it again I do not think these patches solve the

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-03-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ Actually, I looking at it again I do not think these patches solve the issue. The reproducer is not correct. After you update all the members in the group with db

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-03-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ Actually, I looking at it again I do not think these patches solve the issue. The reproducer is not correct. After you update all the members in the group with db

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-03-31 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ These patches fixed the issue for me. LGTM, if CI passes I will give you an ACK. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#193][+Changes requested] UTIL: Use max 15 characters for AD host UPN

2017-03-29 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/193 Title: #193: UTIL: Use max 15 characters for AD host UPN Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#193][comment] UTIL: Use max 15 characters for AD host UPN

2017-03-29 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/193 Title: #193: UTIL: Use max 15 characters for AD host UPN mzidek-rh commented: """ Hi, I have this on my "to test" list, but could you please add a comment to the code, why we use exactly 15. It is cleat from the ticket, bu

[SSSD] [sssd PR#197][+Accepted] KCM responder

2017-03-24 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-24 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ All my concerns have been addressed (and If I am not mistaken also Simo's). ACK from me. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#197][+Changes requested] KCM responder

2017-03-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ Some nitpicks mostly regarding the lack of DEBUG messages. src/responder/kcm/kcmsrv_cmd.c 164 /* First 16 bits are 8 bit major and 8bit major p

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ Other then that it LGTM and what I tried worked for me. """ See the full comment at https://github.com/SSSD/sssd/pull/197#issuecomment-288409819 __

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ Other than that it LGTM and what I tried worked for me. """ See the full comment at https://github.com/SSSD/sssd/pull/197#issuecomment-288409819 __

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ Some nitpicks mostly regarding the lack of DEBUG messages. src/responder/kcm/kcmsrv_cmd.c 164 /* First 16 bits are 8 bit major and 8bit major p

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ Nitpick: In the contrib/kcm_default_ccache it would be good to indicate (in the comments) where the snippet belongs. It is written in the commit message, but if someone just opens

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ Actually we do check for libcurl in configure. The reproducer is: $ sudo dnf remove libcurl-devel $ configure | grep curl configure: WARNING: The libcurl development library was

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ On VM with were libcurl-devel is not installed, the configure succeeds, but compilation fails with: /home/user/gitrepo/sssd/src/util/tev_curl.c:32:23: fatal error: curl/curl.h

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder mzidek-rh commented: """ On VM with were libcurl-devel is not installed, the configure succeeds, but compilation fails with: /home/user/gitrepo/sssd/src/util/tev_curl.c:32:23: fatal error: curl/curl.h

[SSSD] [sssd PR#196][comment] SSSD-1.15 - config-check: Message when sssd.conf is missing

2017-03-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing mzidek-rh commented: """ Thank you for summarizing it in the pagure issues. is it OK, if I send patches for the issues you mentioned in this PR as part of the

[SSSD] [sssd PR#196][comment] SSSD-1.15 - config-check: Message when sssd.conf is missing

2017-03-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing mzidek-rh commented: """ Sorry, I do not understand your last comment. Can you please summarize it in an pagure issue? I am little bit confused (but if I understa

[SSSD] [sssd PR#196][comment] SSSD-1.15 - config-check: Message when sssd.conf is missing

2017-03-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing mzidek-rh commented: """ I just realized that the message needs to be printed conditionally only if SSSD was configured with --enable-files-domain . I tested i

[SSSD] [sssd PR#196][synchronized] SSSD-1.15 - config-check: Message when sssd.conf is missing

2017-03-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/196 Author: mzidek-rh Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/196/head:pr196 git checkout pr196

[SSSD] [sssd PR#186][comment] Subdomain config

2017-03-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config mzidek-rh commented: """ I agree with the comments. I also want to add a sssd specific configuration validator that will check if options used in subdomain are allowed and print message if they are

[SSSD] [sssd PR#196][opened] SSSD-1.15 - config-check: Message when sssd.conf is missing

2017-03-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/196 Author: mzidek-rh Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing Action: opened PR body: """ SSSD 1.15 version for patch recently pushed to 1.14. sssctl config-check should print a message for user if no sssd

[SSSD] [sssd PR#194][comment] config-check: Message when sssd.conf is missing

2017-03-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Title: #194: config-check: Message when sssd.conf is missing mzidek-rh commented: """ I know this is a corner case, but I would like sssctl config-check to behave more user friendly in the case when config file is missing for

[SSSD] [sssd PR#195][opened] UTIL: Typo in comment

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/195 Author: mzidek-rh Title: #195: UTIL: Typo in comment Action: opened PR body: """ I hope this patch makes it to the rebase. I do not understand how people were even able to use SSSD without it. Someone with deep knowledge of SSSD in

[SSSD] [sssd PR#194][comment] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Title: #194: config-check: Message when sssd.conf is missing mzidek-rh commented: """ On 03/14/2017 06:08 PM, lslebodn wrote: > *@lslebodn* commented on

[SSSD] [sssd PR#194][comment] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Title: #194: config-check: Message when sssd.conf is missing mzidek-rh commented: """ New version attached. """ See the full comment at https://github.com/SSSD/sssd/pull/194#issuecomment-286493411 __

[SSSD] [sssd PR#194][synchronized] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Author: mzidek-rh Title: #194: config-check: Message when sssd.conf is missing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/194/head:pr194 git checkout pr194 From

[SSSD] [sssd PR#194][comment] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Title: #194: config-check: Message when sssd.conf is missing mzidek-rh commented: """ I agree with the comments. See new version pushed. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#194][synchronized] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Author: mzidek-rh Title: #194: config-check: Message when sssd.conf is missing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/194/head:pr194 git checkout pr194 From

[SSSD] [sssd PR#194][synchronized] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Author: mzidek-rh Title: #194: config-check: Message when sssd.conf is missing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/194/head:pr194 git checkout pr194 From

[SSSD] [sssd PR#194][comment] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Title: #194: config-check: Message when sssd.conf is missing mzidek-rh commented: """ To test just remove the sssd.conf file and do sssctl config-check. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#194][opened] config-check: Message when sssd.conf is missing

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/194 Author: mzidek-rh Title: #194: config-check: Message when sssd.conf is missing Action: opened PR body: """ sssctl config-check should print a message for user if no sssd.conf was found. Resolves: https://pagure.io/SSSD/sssd/issue/33

[SSSD] [sssd PR#186][comment] Subdomain config

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config mzidek-rh commented: """ Ok, I added the ad_server, ad_site and ad_backup_server to this patchset (it is only 14 lines and the testing is almost the same, so i guess it makes sense). I also updated the

[SSSD] [sssd PR#186][synchronized] Subdomain config

2017-03-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/186 Author: mzidek-rh Title: #186: Subdomain config Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/186/head:pr186 git checkout pr186 From

[SSSD] [sssd PR#166][comment] NSS: Fix invalidating memory cache for subdomain users

2017-03-10 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/166 Title: #166: NSS: Fix invalidating memory cache for subdomain users mzidek-rh commented: """ ACK. CI link: http://sssd-ci.duckdns.org/logs/job/64/39/summary.html """ See the full comment at https://github.com/S

[SSSD] [sssd PR#166][+Accepted] NSS: Fix invalidating memory cache for subdomain users

2017-03-10 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/166 Title: #166: NSS: Fix invalidating memory cache for subdomain users Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

<    1   2   3   4   5   6   7   >