[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations lslebodn commented: """ master: * a4837791f62283079e7be4b17efb769be8b2dfd1 * 5a660d3aa67403fba69a8047ecedfe8a4276fc30 * 13294bedc56faf1011f5ba7b1ed9a53b08e71c00 * 76b6d7fb9f31f7836158d248161aec3558098659 * 78bb3676fe8326e0fe2b60daad8bf524e4625d4e """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282994119 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ I just squashed the patches together per @lslebodn request """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282747658 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282709063 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ btw one thing I would like to do more that this auto-magic is for SSSD to have the functionality to enable all domains that are defined even in snippets without having to define them on the domains=line. Then the downstream package could just drop a files domain definition..but we don't have this functionality, so.. """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282314586 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ OK, I added a new option and a test for it. So far (for easier review) I kept the option and the test as separate patches prefixed with SQ. If the patches are acked, I will squash them into the ones just before (and resubmit before pushing for sanity check) """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282314208 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ On Fri, Feb 24, 2017 at 04:41:48AM -0800, Pavel Březina wrote: > Typo in last commit message: > ``` > This functionality is only enabled in case SSSD is configured with with < > ``` > > Otherwise ack. I just wonder if this is really something that must be enabled > on build level. My concern is that if someone will not want to use it for > some reason, there is no way to disable the implicit files domain. We should > provide a configuration option to disable it. Are you referring to the domain that gets prepended before other domains or the fallback config? > > Or we should provide a configuration option `enable_implicit_files` that will > default to `yes` if `--enable-files-domain` is given and to `no` otherwise. I can implement this, sure. """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282294063 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations pbrezina commented: """ Typo in last commit message: ``` This functionality is only enabled in case SSSD is configured with with < ``` Otherwise ack. I just wonder if this is really something that must be enabled on build level. My concern is that if someone will not want to use it for some reason, there is no way to disable the implicit files domain. We should provide a configuration option to disable it. Or we should provide a configuration option `enable_implicit_files` that will default to `yes` if `--enable-files-domain` is given and to `no` otherwise. """ See the full comment at https://github.com/SSSD/sssd/pull/163#issuecomment-282282200 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
