Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-10-01 Thread Michal Židek
On 10/01/2015 12:37 PM, Petr Cech wrote: On 09/18/2015 04:30 PM, Petr Cech wrote: Hello, there are fixed patches attached. Bump. The code was already acked by PavelR, the only problem was with the version info change and the version script. I checked the last iteration and both version

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-10-01 Thread Michal Židek
On 10/01/2015 01:03 PM, Pavel Reichl wrote: On 10/01/2015 12:59 PM, Michal Židek wrote: On 10/01/2015 12:37 PM, Petr Cech wrote: On 09/18/2015 04:30 PM, Petr Cech wrote: Hello, there are fixed patches attached. Bump. The code was already acked by PavelR, the only problem was with the

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-10-01 Thread Pavel Reichl
On 10/01/2015 12:59 PM, Michal Židek wrote: On 10/01/2015 12:37 PM, Petr Cech wrote: On 09/18/2015 04:30 PM, Petr Cech wrote: Hello, there are fixed patches attached. Bump. The code was already acked by PavelR, the only problem was with the version info change and the version script. I

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-10-01 Thread Petr Cech
On 09/18/2015 04:30 PM, Petr Cech wrote: Hello, there are fixed patches attached. Bump. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-10-01 Thread Jakub Hrozek
On Thu, Oct 01, 2015 at 01:40:34PM +0200, Michal Židek wrote: > On 10/01/2015 01:03 PM, Pavel Reichl wrote: > > > > > >On 10/01/2015 12:59 PM, Michal Židek wrote: > >>On 10/01/2015 12:37 PM, Petr Cech wrote: > >>>On 09/18/2015 04:30 PM, Petr Cech wrote: > Hello, > > there are fixed

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-18 Thread Petr Cech
Hello, there are fixed patches attached. On 09/18/2015 11:08 AM, Lukas Slebodnik wrote: --version-info 0:1:0 +-version-info 1:0:1 >>>Lukas, are you sure this version number 1:0:1? If you're really sure this >>>number, I have not understood it properly. You might also look

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-15 Thread Petr Cech
On 09/14/2015 03:25 PM, Jakub Hrozek wrote: On Mon, Sep 14, 2015 at 02:15:39PM +0200, Petr Cech wrote: From 4246d5cd91c4c34b8524be5bfce38c57163a6e2b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 11 Sep 2015 17:04:58 +0200 Subject: [PATCH] squash_me ---

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-14 Thread Petr Cech
On 09/11/2015 05:24 PM, Lukas Slebodnik wrote: --- a/src/providers/ipa/ipa_hbac.exports >+++ b/src/providers/ipa/ipa_hbac.exports >@@ -1,4 +1,4 @@ >-IPA_HBAC_0.0.1 { >+IPA_HBAC_0.0.2 { > > # public functions > global: >@@ -8,6 +8,7 @@ IPA_HBAC_0.0.1 { > hbac_error_string; >

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-14 Thread Jakub Hrozek
On Mon, Sep 14, 2015 at 02:15:39PM +0200, Petr Cech wrote: > > From 4246d5cd91c4c34b8524be5bfce38c57163a6e2b Mon Sep 17 00:00:00 2001 > >From: Lukas Slebodnik > >Date: Fri, 11 Sep 2015 17:04:58 +0200 > >Subject: [PATCH] squash_me > > > >--- > > Makefile.am

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-11 Thread Lukas Slebodnik
On (01/09/15 16:15), Petr Cech wrote: >On 09/01/2015 11:00 AM, Pavel Reichl wrote: >>> From 6b1c6cac7123e78a2c55c51019b66a6bcf97ec29 Mon Sep 17 00:00:00 2001 >>>From: Petr Cech >>>Date: Fri, 24 Jul 2015 10:56:49 -0400 >>>Subject: [PATCH 2/2] HBAC: Better libhbac debugging >>>

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-04 Thread Pavel Reichl
All my concerns were addressed. CI passed: http://sssd-ci.duckdns.org/logs/job/24/37/summary.html Code is fine by me and my testing passed. ACK I think that this patch will be a real improvement for debugging HBAC issues, thanks Petr. ___ sssd-devel

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-01 Thread Pavel Reichl
In https://fedorahosted.org/sssd/wiki/FAQ SSSDBG_FATAL_FAILURE is described as: 0x0010: Fatal failures. Anything that would prevent SSSD from starting up or causes it to cease running. Are you sure that such errors can happen in HBAC? HBAC_DBG_FATAL isn't used in

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-01 Thread Petr Cech
On 09/01/2015 11:00 AM, Pavel Reichl wrote: From 6b1c6cac7123e78a2c55c51019b66a6bcf97ec29 Mon Sep 17 00:00:00 2001 From: Petr Cech Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH 2/2] HBAC: Better libhbac debugging Added support for logging via external log function.

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-31 Thread Petr Cech
On 08/27/2015 10:42 AM, Pavel Reichl wrote: * SSSDBG_TRACE_ALL produces: ...hbac_evaluator.c:150] [< hbac_evaluate() ...hbac_evaluator.c:410] REQUEST: ...hbac_evaluator.c:391] service [sshd] ...hbac_evaluator.c:400] service_group (none) ...hbac_evaluator.c:391] user [csikos]

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-31 Thread Petr Cech
On 08/31/2015 01:32 PM, Pavel Reichl wrote: 0x2000 (Mon Aug 31 07:03:04 2015) [sssd[be[cygnus.dev]]] [hbac] (0x0100): [../src/providers/ipa/hbac_evaluator.c:152] [< hbac_evaluate() (Mon Aug 31 07:03:04 2015) [sssd[be[cygnus.dev]]] [hbac] (0x2000): [../src/providers/ipa/hbac_evaluator.c:409]

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-31 Thread Pavel Reichl
On 08/31/2015 01:18 PM, Petr Cech wrote: 0x0080 (Mon Aug 31 06:57:09 2015) [sssd[be[cygnus.dev]]] [ipa_hbac_evaluate_rules] (0x0080): Access granted by HBAC rule [Test_rule] (Mon Aug 31 06:57:09 2015) [sssd[be[cygnus.dev]]] [ipa_hbac_evaluate_rules] (0x0080): Access denied by HBAC rules

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-27 Thread Pavel Reichl
On 08/26/2015 09:44 AM, Petr Cech wrote: +void hbac_debug_messages(const char *file, int line, + enum hbac_debug_level level, + const char *fmt, ...) +{ +int loglevel = SSSDBG_UNRESOLVED; +int ret; +char *message = NULL; + +

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-27 Thread Pavel Reichl
* SSSDBG_TRACE_ALL produces: ...hbac_evaluator.c:150] [ hbac_evaluate() ...hbac_evaluator.c:410] REQUEST: ...hbac_evaluator.c:391] service [sshd] ...hbac_evaluator.c:400] service_group (none) ...hbac_evaluator.c:391] user [csikos] ...hbac_evaluator.c:395] user_group: I think it

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-26 Thread Petr Cech
On 08/24/2015 03:45 PM, Pavel Reichl wrote: On 07/24/2015 06:20 PM, Petr Cech wrote: From 2fcf13ef59f00b460afa77b27ef6cc2789b06393 Mon Sep 17 00:00:00 2001 From: Petr Cechpc...@redhat.com Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH] [HBAC]: Better libhbac debuging

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-24 Thread Pavel Reichl
On 07/24/2015 06:20 PM, Petr Cech wrote: From 2fcf13ef59f00b460afa77b27ef6cc2789b06393 Mon Sep 17 00:00:00 2001 From: Petr Cechpc...@redhat.com Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH] [HBAC]: Better libhbac debuging s/debuging/debugging Added support for logging via external

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-14 Thread Petr Cech
ping :-) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-07-24 Thread Petr Cech
Hi, according to https://fedorahosted.org/sssd/ticket/2703 I tried to add logging to the library HBAC. A) Logging is performed using an external function, which you can set by: # hbac_enable_debug(...) B) The specific implementation of such a function, you can see # hbac_debug_messages(...)