On 09/01/2015 08:44 AM, Petr Cech wrote:
On 08/31/2015 09:51 PM, Jakub Hrozek wrote:
On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote:
On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote:
ACK
LS
* master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a
This patch broke
On 08/31/2015 09:51 PM, Jakub Hrozek wrote:
On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote:
On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote:
ACK
LS
* master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a
This patch broke distcheck:
../src/util/sss_cli_cmd.c
On Tue, Sep 01, 2015 at 09:37:29AM +0200, Pavel Reichl wrote:
> On 09/01/2015 08:44 AM, Petr Cech wrote:
> >On 08/31/2015 09:51 PM, Jakub Hrozek wrote:
> >>On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote:
> >>>On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote:
> ACK
On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote:
> ACK
>
> LS
* master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote:
> On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote:
> > ACK
> >
> > LS
>
> * master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a
This patch broke distcheck:
../src/util/sss_cli_cmd.c -fPIC -DPIC -o
On (18/08/15 15:54), Petr Cech wrote:
On 08/13/2015 11:11 AM, Lukas Slebodnik wrote:
From a93e36f11759cf9a748942e7632d4a07a088b098 Mon Sep 17 00:00:00 2001
From: Petr Cech pc...@redhat.com
Date: Wed, 8 Jul 2015 07:17:28 -0400
Subject: [PATCH] UTIL: Function 2string for enum sss_cli_command
On 08/13/2015 11:11 AM, Lukas Slebodnik wrote:
From a93e36f11759cf9a748942e7632d4a07a088b098 Mon Sep 17 00:00:00 2001
From: Petr Cech pc...@redhat.com
Date: Wed, 8 Jul 2015 07:17:28 -0400
Subject: [PATCH] UTIL: Function 2string for enum sss_cli_command
Improvement of debug messages.
Instead
On (14/07/15 13:21), Petr Cech wrote:
On 07/13/2015 07:13 PM, Lukas Slebodnik wrote:
On (13/07/15 10:57), Jakub Hrozek wrote:
On Mon, Jul 13, 2015 at 09:47:46AM +0200, Lukas Slebodnik wrote:
On (10/07/15 16:54), Jakub Hrozek wrote:
On Wed, Jul 08, 2015 at 03:26:52PM +0200, Sumit Bose wrote:
I
On 07/13/2015 07:13 PM, Lukas Slebodnik wrote:
On (13/07/15 10:57), Jakub Hrozek wrote:
On Mon, Jul 13, 2015 at 09:47:46AM +0200, Lukas Slebodnik wrote:
On (10/07/15 16:54), Jakub Hrozek wrote:
On Wed, Jul 08, 2015 at 03:26:52PM +0200, Sumit Bose wrote:
I would suggest that you put
On Mon, Jul 13, 2015 at 09:47:46AM +0200, Lukas Slebodnik wrote:
On (10/07/15 16:54), Jakub Hrozek wrote:
On Wed, Jul 08, 2015 at 03:26:52PM +0200, Sumit Bose wrote:
I would suggest that you put sss_cli_command_2string() in a file on
its own similar like atomic_io.c or authtok-utils.c.
On (13/07/15 10:57), Jakub Hrozek wrote:
On Mon, Jul 13, 2015 at 09:47:46AM +0200, Lukas Slebodnik wrote:
On (10/07/15 16:54), Jakub Hrozek wrote:
On Wed, Jul 08, 2015 at 03:26:52PM +0200, Sumit Bose wrote:
I would suggest that you put sss_cli_command_2string() in a file on
its own
On (10/07/15 16:54), Jakub Hrozek wrote:
On Wed, Jul 08, 2015 at 03:26:52PM +0200, Sumit Bose wrote:
I would suggest that you put sss_cli_command_2string() in a file on
its own similar like atomic_io.c or authtok-utils.c. And add this file
to pam_sss_la_SOURCES and libsss_debug_la_SOURCES
On (09/07/15 14:03), Petr Cech wrote:
Hi!
There is my repaired patch. All of yours comments were helpful.
I renamed the function to sss_cmd2str(), but maybe it could be
sss_cli_cmd2str(). I am not sure with it, but if it is better, I will rename
it again.
Petr
On 07/08/2015 03:26 PM, Sumit
Hi!
There is my repaired patch. All of yours comments were helpful.
I renamed the function to sss_cmd2str(), but maybe it could be
sss_cli_cmd2str(). I am not sure with it, but if it is better, I will
rename it again.
Petr
On 07/08/2015 03:26 PM, Sumit Bose wrote:
On Wed, Jul 08, 2015 at
Hi!
https://fedorahosted.org/sssd/ticket/2703
It's my first patch to this ticket. It is simple transforming of number
of command to the string.
Petr
From ca782a1518480635ef60bc2cdf77d9b8644132b0 Mon Sep 17 00:00:00 2001
From: Petr Cech pc...@redhat.com
Date: Wed, 8 Jul 2015 07:17:28 -0400
On 07/08/2015 02:13 PM, Petr Cech wrote:
Hi!
https://fedorahosted.org/sssd/ticket/2703
It's my first patch to this ticket. It is simple transforming of
number of command to the string.
Petr
Hello Petr,
thank for the patch!
I haven't tested the patch yet, but I have some nitpicks. Please
On Wed, Jul 08, 2015 at 02:13:42PM +0200, Petr Cech wrote:
Hi!
https://fedorahosted.org/sssd/ticket/2703
It's my first patch to this ticket. It is simple transforming of number of
command to the string.
Hi Petr,
welcome and thank you for your first patch. Besides Pavel's suggestions
I
On 07/08/2015 02:46 PM, Pavel Reichl wrote:
On 07/08/2015 02:13 PM, Petr Cech wrote:
Hi!
https://fedorahosted.org/sssd/ticket/2703
It's my first patch to this ticket. It is simple transforming of
number of command to the string.
Petr
Hello Petr,
thank for the patch!
I haven't tested
Hi!
I think the function is a little overkill. The only change I
would do in case of sss_cli commands is that I would change the
decimal %d to a hexa 0x%x because that matches
the representation in the header and would simplify grepping
the code.
OTOH if we want to make the messages also
19 matches
Mail list logo
