Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-14 Thread Pavel Březina
On 10/13/2015 03:51 PM, Jakub Hrozek wrote: On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel Březina wrote: I don't like overriding opt_name and opt_id here, the caller of check_cache() does not expect that those values change (especially because opt_name is declared const in the header).

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-14 Thread Jakub Hrozek
On Wed, Oct 14, 2015 at 11:29:09AM +0200, Pavel Březina wrote: > On 10/13/2015 03:51 PM, Jakub Hrozek wrote: > >On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel Březina wrote: > >>>I don't like overriding opt_name and opt_id here, the caller of > >>>check_cache() does not expect that those values

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-14 Thread Sumit Bose
On Wed, Oct 14, 2015 at 12:27:12PM +0200, Jakub Hrozek wrote: > On Wed, Oct 14, 2015 at 11:29:09AM +0200, Pavel Březina wrote: > > On 10/13/2015 03:51 PM, Jakub Hrozek wrote: > > >On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel Březina wrote: > > >>>I don't like overriding opt_name and opt_id

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-14 Thread Jakub Hrozek
On Wed, Oct 14, 2015 at 12:52:38PM +0200, Sumit Bose wrote: > On Wed, Oct 14, 2015 at 12:27:12PM +0200, Jakub Hrozek wrote: > > On Wed, Oct 14, 2015 at 11:29:09AM +0200, Pavel Březina wrote: > > > On 10/13/2015 03:51 PM, Jakub Hrozek wrote: > > > >On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-13 Thread Pavel Březina
On 10/12/2015 05:43 PM, Sumit Bose wrote: On Sun, Oct 11, 2015 at 06:10:50PM +0200, Pavel Březina wrote: On 10/11/2015 06:03 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2833 We can't search of overridden name/id in LDAP when using local overrides. These patches fix this for

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-13 Thread Pavel Březina
On 10/12/2015 05:43 PM, Sumit Bose wrote: On Sun, Oct 11, 2015 at 06:10:50PM +0200, Pavel Březina wrote: On 10/11/2015 06:03 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2833 We can't search of overridden name/id in LDAP when using local overrides. These patches fix this for

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-13 Thread Jakub Hrozek
On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel Březina wrote: > >I don't like overriding opt_name and opt_id here, the caller of > >check_cache() does not expect that those values change (especially > >because opt_name is declared const in the header). Additionally I'm not > > The values won't

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-12 Thread Sumit Bose
On Sun, Oct 11, 2015 at 06:10:50PM +0200, Pavel Březina wrote: > On 10/11/2015 06:03 PM, Pavel Březina wrote: > >https://fedorahosted.org/sssd/ticket/2833 > > > >We can't search of overridden name/id in LDAP when using local > >overrides. These patches fix this for nss and sudo responder, please

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-12 Thread Jakub Hrozek
On Sun, Oct 11, 2015 at 06:10:50PM +0200, Pavel Březina wrote: > On 10/11/2015 06:03 PM, Pavel Březina wrote: > >https://fedorahosted.org/sssd/ticket/2833 > > > >We can't search of overridden name/id in LDAP when using local > >overrides. These patches fix this for nss and sudo responder, please

[SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-11 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2833 We can't search of overridden name/id in LDAP when using local overrides. These patches fix this for nss and sudo responder, please let me know if there is any other place. Similar fix needs to be done in cache_req interface, but I'll send it as

Re: [SSSD] [PATCH] local overrides: don't concact server with overriden name/id

2015-10-11 Thread Pavel Březina
On 10/11/2015 06:03 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2833 We can't search of overridden name/id in LDAP when using local overrides. These patches fix this for nss and sudo responder, please let me know if there is any other place. Similar fix needs to be done in