Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-31 Thread Jakub Hrozek
On Fri, Aug 28, 2015 at 03:24:21PM +0200, Petr Cech wrote: > On 08/28/2015 03:13 PM, Petr Cech wrote: > >I am doing code review for fixed patch now. Patch looks good to me and > >it works. > > > >I discussed the problem above (about fprintf vs. libpopt) with both > >offline. The libpopt solution

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Pavel Březina
On 08/28/2015 12:21 PM, Lukas Slebodnik wrote: On (28/08/15 12:13), Pavel Březina wrote: On 08/27/2015 12:49 PM, Lukas Slebodnik wrote: On (25/08/15 13:00), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 From f181b0a94863f082abaf074a0940e83fbf1c89b1 Mon Sep 17 00:00:00 2001

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Pavel Březina
On 08/27/2015 12:49 PM, Lukas Slebodnik wrote: On (25/08/15 13:00), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 From f181b0a94863f082abaf074a0940e83fbf1c89b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Tue, 25 Aug 2015 12:58:45

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Petr Cech
On 08/28/2015 03:13 PM, Petr Cech wrote: I am doing code review for fixed patch now. Patch looks good to me and it works. I discussed the problem above (about fprintf vs. libpopt) with both offline. The libpopt solution starts here [1] and I agree it would not be straightforward. So I am

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Petr Cech
On 08/28/2015 12:25 PM, Pavel Březina wrote: I would be also curious why you need to provide hacks for printing argument description for autohelp. There is a much more elegant way how to do it with libpopt. (small hint POPT_ARGFLAG_DOC_HIDDEN in sss_tool_common_opts) Your curiosity is

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-27 Thread Lukas Slebodnik
On (25/08/15 13:00), Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 From f181b0a94863f082abaf074a0940e83fbf1c89b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Tue, 25 Aug 2015 12:58:45 +0200 Subject: [PATCH] sss_override: document

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-25 Thread Petr Cech
On 08/25/2015 01:00 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 Hi Pavel, I have 3 formal comments to coding style. Now I am running the tests. I will send you mail with results soon. Petr 0001-sss_override-document-debug-options.patch From

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-25 Thread Pavel Březina
On 08/25/2015 01:32 PM, Petr Cech wrote: On 08/25/2015 01:00 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 Hi Pavel, I have 3 formal comments to coding style. Now I am running the tests. I will send you mail with results soon. Petr

[SSSD] [PATCH] sss_override: document --debug options

2015-08-25 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/2758 From f181b0a94863f082abaf074a0940e83fbf1c89b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Tue, 25 Aug 2015 12:58:45 +0200 Subject: [PATCH] sss_override: document --debug options Resolves:

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-25 Thread Petr Cech
On 08/25/2015 01:36 PM, Pavel Březina wrote: +static void sss_tool_print_common_opts(void) +{ +fprintf(stderr, _(Common options:\n)); +fprintf(stderr, -d, --debug=INT%s\n, +_(Enable debug at level)); I'm not sure, but is it habbit to indent to '('? I mean: