URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
master:
* 91b0592cdab22915dff27ceae6d8e49c608aea4a
* ca90f2102a43a3d49a2ef26610d7b4ff3062a823
* 321ca28277cbf9882769537fd4c0dfaea224c86e
*
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
pbrezina commented:
"""
On 03/14/2017 12:19 PM, Jakub Hrozek wrote:
> On Tue, Mar 14, 2017 at 03:22:19AM -0700, Pavel Březina wrote:
>> The changes looks good, although I would
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
On Tue, Mar 14, 2017 at 03:31:45AM -0700, lslebodn wrote:
> BTW `util/sss_iobuf.h` includes itself
>
> following diff fixes it
> ```
> diff --git
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
On Tue, Mar 14, 2017 at 03:29:17AM -0700, lslebodn wrote:
> On (14/03/17 01:34), Jakub Hrozek wrote:
> >I squashed one last trivial change that just checks
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
On Tue, Mar 14, 2017 at 03:22:19AM -0700, Pavel Březina wrote:
> The changes looks good, although I would say that disabling `Expect:
> 100-continue` is
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
BTW `util/sss_iobuf.h` includes itself
following diff fixes it
```
diff --git a/src/tests/cmocka/test_iobuf.c b/src/tests/cmocka/test_iobuf.c
index
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
pbrezina commented:
"""
The changes looks good, although I would say that disabling `Expect:
100-continue` is not the way to go in a long-term. I believe the problem lies
in
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
I squashed one last trivial change that just checks the return value of the
option set:
```
diff --git a/src/util/tev_curl.c b/src/util/tev_curl.c
index
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
@lslebodn @pbrezina OK to push?
I admit I don't understand the inner workings of neither libcurl nor the HTTP
server, but I noticed that the requests
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
OK, I /hope/ I finally fixed the bug. Here is the diff:
```
diff --git a/src/util/tev_curl.c b/src/util/tev_curl.c
index d6e4d41..b966a78 100644
---
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
Update: latest version works well in internal CI; but there is still problem in
CentOS infrastructure with `test_secrets.py::test_curlwrap_parallel`. The
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/152#issuecomment-283681560
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
seems to work well with el7
http://sssd-ci.duckdns.org/logs/job/63/65/summary.html
http://sssd-ci.duckdns.org/logs/job/63/66/summary.html
LS
"""
See
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
On (01/03/17 04:41), Pavel Březina wrote:
>pbrezina commented on this pull request.
>
>
>
>> + urls[i],
>+
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
I am sorry but there is some problem with integration test on rhel7.
I need to kill the test after 1.5 hour
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
lslebodn commented:
"""
I am sorry but there is some problem with integration test on rhel7.
I need to kill the test after 1.5 hour
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
I squashed in changes @lslebodn suggested for the tests and pushed a new version
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
On Thu, Feb 23, 2017 at 03:10:12AM -0800, lslebodn wrote:
> lslebodn commented on this pull request.
>
>
>
> > @@ -3241,6 +3281,7 @@ intgcheck-prepare:
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
pbrezina commented:
"""
Ack from my side. We can push these patches. I will modify the integration to
some extend for `secrets` needs.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
@lslebodn could you please check if you agree with how the curlwrap tool is
built and detected during the intgcheck target? The intent was to skip
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
Thank you, hopefully I addressed all concerns.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/152#issuecomment-281941839
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
I also added more comments per Pavel's request. If there are more areas that
need to be commented better, please point them out and I will decorate the
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
Per Pavel's request I moved the headers parameter to the send function so every
request can run with different headers.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
On Fri, Feb 17, 2017 at 03:59:51AM -0800, Pavel Březina wrote:
> Hi, I prepared few trivial commits for you to squash if you agree:
>
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
pbrezina commented:
"""
Hi, I prepared few trivial commits for you to squash if you agree:
https://github.com/pbrezina/sssd/commits/curl I tried to push it to your branch
but I
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
On Tue, Feb 14, 2017 at 05:57:32AM -0800, Pavel Březina wrote:
> Thank you. So far I'm reading `secrets` code trying to figure out my needs to
> comment
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
pbrezina commented:
"""
Thank you. So far I'm reading `secrets` code trying to figure out my needs to
comment on `curl` implementation. Here are some comments on the `iobuf`
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
I tried to submit a new job for the centos CI because our CI "passed":
http://sssd-ci.duckdns.org/logs/job/62/42/summary.html
(there is an unrelated
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/152#issuecomment-279656176
URL: https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
I changed three patches a bit:
* the build patch now detects if libcurl supports unix sockets and skips
building the curl code if not completely. Pavel,
30 matches
Mail list logo
