URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
jhrozek commented:
"""
* master: 57a924e71230ea360b19a88e0d5818cf01017161
"""
See the full comment at
https://github.com/SSSD/sssd/pull/153#issuecomment-285018846
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
@jhrozek re-reading those patches I do believe all your comments have been
addressed in the latest version.
I'm adding a the "Accepted" label.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
New version uploaded. Thanks for review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/153#issuecomment-284703683
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
jhrozek commented:
"""
btw CI passed, so as soon as the comments are added, I'll push the patch:
http://sssd-ci.duckdns.org/logs/job/63/98/summary.html
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
jhrozek commented:
"""
I have one last trivial thing to add -- can you add comment to the new
function that is always writes to the persistent cache and a similar comment to
the call
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
I updated the patch.
1. The issue with enum is addressed.
1. I added function ```sysdb_invalidate_cache_entry()``` to sysdb API and
removed the specific two
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
Patch looks good and there's just two really minor coding style issues, IMO.
Whoever pushes this patch, please, squash
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
New version pushed. CI passed:
http://sssd-ci.duckdns.org/logs/job/63/02/summary.html
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
New version pushed, but CI said "NO":
http://sssd-ci.duckdns.org/logs/job/62/98/summary.html
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
I take my comment back. I've submitted the wrong patch version to CI.
Yes, those tests are failing!
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
@celestian:
Just ran the ci on your patch and it passed without issues (apart from the
rhel6, but the failure is unrelated).
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
The are results from our CI
http://sssd-ci.duckdns.org/logs/job/62/90/summary.html
How we can see this patch fails on test_ts_cache.py integration test, namely:
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
@celestian:
One thing that I forgot to mention, it's worth to write a test for this as well.
Just checked with @lslebodn and he mentioned that an integration test
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
Fixed patch is pushed. I sent it to our CI and I will share the result.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/153#issuecomment-280025798
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
So, dnf repositories work again. I am able to test the functionality of my
patch set. Unfortunately it doesnt work. I will fix it.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
FYI http://sssd-ci.duckdns.org/logs/job/62/59/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/153#issuecomment-279693430
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
fidencio commented:
"""
This approach seems less intrusive than the previous one and the integration
tests passed locally (already asked @celestian to run our CI as well).
I'll do a
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
I pushed new version (#2).
I addressed Lukáš's comment. Now it works only for sss_cache case. In detail, I
added functions
```
URL: https://github.com/SSSD/sssd/pull/153
Title: #153: sss_cache: User/groups invalidation in domain cache
celestian commented:
"""
I pushed new version (#2).
I addressed Lukáš's comment. Now it works only for sss_cache case. In detail, I
added functions
```
19 matches
Mail list logo
