URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
sumit-bose commented:
"""
ok, I have no further comments as well, so ACK.
Since @pbrezina already gave his ACK I'll set the Accepted flag.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
On Wed, Dec 06, 2017 at 12:55:22PM +, sumit-bose wrote:
> The code works well for me and I didn't run into issues either. I left two
> minor comments
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
sumit-bose commented:
"""
The code works well for me and I didn't run into issues either. I left two
minor comments which do not affect the code, so feel free to ignore them.
"""
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
pbrezina commented:
"""
Thank you, this code is much better. I ran some test and it seems to be OK.
Ack.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
downstream tests:
* AD tests "passed" - 2182302 - there are some child tests that failed, but
Lukas tells me he has at least a workaround for the tests in
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
new patches that fix the Coverity warnings were pushed
"""
See the full comment at
https://github.com/SSSD/sssd/pull/453#issuecomment-349283744
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
btw Coverity found two issues in the latest patches; I've fixed them both
locally and I'm re-running all the tests now..
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
I pushed new patches. The changes include:
- the domain locator logic in `cache_req.c` is now in a separate request as
@pbrezina suggested
- several fixes
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
pbrezina commented:
"""
Yes, turning it into a separate request would be better.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/453#issuecomment-348442274
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
@pbrezina sorry for the delay, but I was working on other PR reviews but also
on fixing some issues these patches had caused in AD downstream tests (new
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
I'll try to work on that during the next couple of days.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/453#issuecomment-346682291
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
pbrezina commented:
"""
Is it possible to make the cache req code more straightforward instead of
mixing logic of locating domain and normal domain search?
I.e. create a request,
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
The test failures are not so bad after all, but there are some failures in
parts of code I touched.
but the earliest I will be able to debug the failing
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
quick test update: All the generic ldap, kerberos and proxy tests succeeded,
the AD tests failed in a grandiose way. I'll investigate why later.
"""
See
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
I fixed the multidomain bug and another bug in the AD locator request which
could have caused a loop in an MPG domain.
I still haven't ran any downstream
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
Lastly, I realized that get-by-SID requests could theoretically be supported as
well, but I also don't think it's urgent. Maybe we should have a ticket for
URL: https://github.com/SSSD/sssd/pull/453
Title: #453: Speed up by-ID lookups with the help of the Global Catalog
jhrozek commented:
"""
I pushed new version of patches:
- MPG domains now work fine with this request
- unit tests were added for the negcache additions
- I didn't add tests for
17 matches
Mail list logo
