URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
jhrozek commented:
"""
The fix itself was pushed as 67645557dc0301e7ea66bba15c4ff3fb11f9540e and
Sumit's test was pushed as 0f8add07b8257fcce9f62ad80d24e79b8013ae42. I filed a
ticket about the python3
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
lslebodn commented:
"""
@sumit-bose, thank you very much for increasing test coverage.
Initially I though that it could be included in sssd git using our internal
python-multihost `src/tests/python/`. But
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
lslebodn commented:
"""
@sumit-bose, thank you very much for increasing test coverage.
Initially I though that it could be included in sssd git using our internal
python-multihost `src/tests/python/`. But
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
sumit-bose commented:
"""
@jhrozek, please find some additional integration tests for netgroups where
some components like the NIS domain name are missing at
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
sumit-bose commented:
"""
@jhrozek, please find some additional integration tests for netgroups where
some components like the NIS domain name are missing at
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
@lslebodn, please, I've asked you before, please, **move on**.
You have already caused enough damage by deliberately blocking my work (or
anything I've tried to do in the project),
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
lslebodn commented:
"""
I did not require any changes in PR. I only asked trivial question because I do
not know the answer.
Therefore removing label changed requested
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
> I wonder here if @lslebodn could not have asked about unit/integration tests
> as the first thing saving thus the time of other reviewers.
I'm sorry, because I did **not** express
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
Adding the "Changes Requested" label as per @lslebodn's review.
I wonder here if @lslebodn could not have asked about unit/integration tests as
the first thing saving thus the time
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
lslebodn commented:
"""
There is neither unit test nor integration test in this PR and moreover
upstream ticket is not linked to any downstream BZ? May I know who will write a
regression test?
"""
See the
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
CI:http://vm-031.${abc}/logs/job/82/90/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/476#issuecomment-356434161
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
Works as expected, no issues found by coverity and internal CI is running. In
order to do thing by the booj, I'll add the "Accepted" label as soon as I get
the results.
"""
See the
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
jhrozek commented:
"""
I described the steps to reproduce in the commit message, does that work for
you?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/476#issuecomment-356090663
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
Patch looks good, although I don't know how to reproduce the issue.
Would be possible to add steps to reproduce (either here or in the pagure
issue)?
ps: I'm not adding myself as a
14 matches
Mail list logo
