URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
* `master`
* 5c8f7960f10686e62ef12799f4243e4eb2aad16e - Resolve computer lookup
failure when sam!=cn
* a2e7f687533800753e3062aac83e17c3af2df82f -
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
> Code looks good and works as expected. Ack.
>
> Thank you for your time and I'm sorry it took such a long time to get though
> our review process.
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
Code looks good and works as expected. Ack.
Thank you for your time and I'm sorry it took such a long time to get though
our review process.
"""
See the
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
@pbrezina I've pushed a patch that works for me, and seems to resolve the issue
you encountered.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
> Probably because the computure object has `name=MASTER` instead of
> `name=master.client.vm`. However this is after fresh enrollment to AD via
> `realm`
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
> This is strange. It seems to be segfaulting on the dereference of reply. How
> did we get a null reply if sdap_get_generic_recv() returned EOK?
>
> I
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
Sorry for the delay I was on PTO. I will be much more responsive now so we can
finally finish it.
It does not crash anymore, though it is unable to
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Ping. Any progress here? @pbrezina?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-572146196
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Ping. Any progress here?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-572146196
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Fixed the unused variable, and added a check for a NULL reply when searching
the host sid. Also added a computer_timeout option.
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Fixed the unused variable, and added a check for a NULL reply when searching
the host sid.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
> ```
> warning: Loadable section ".note.gnu.property" outside of ELF segments
> Core was generated by `/usr/libexec/sssd/sssd_be --domain ad.vm --uid 0
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
> ```
> warning: Loadable section ".note.gnu.property" outside of ELF segments
> Core was generated by `/usr/libexec/sssd/sssd_be --domain ad.vm --uid 0
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
```
/home/pbrezina/workspace/sssd/src/db/sysdb_computer.c: In function
‘sysdb_search_computer’:
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
Thanks for reviewing! I've fixed the issues you commented on, as well as one of
my own. I noticed that the sssd-ad man page still contained a comment
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
@pbrezina Thanks for reviewing! I've fixed the issues you commented on, as well
as one of my own. I noticed that the sssd-ad man page still contained a
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
pbrezina commented:
"""
Thank you for these patches. I have just few nitpicks:
We have a convention of prefixing output variables with underscore, i.e.
`size_t *_num_hosts`. Can
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
abbra commented:
"""
@dmulder they need to be reviewed by SSSD core team (I'm not the one ;)), so we
need a review from @pbrezina and @sumit-bose, at least.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
@abbra Any thoughts on these latest patches?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-553475294
19 matches
Mail list logo
