[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-14 Thread Jakub Hrozek
On Fri, Dec 11, 2015 at 05:02:01PM +0100, Lukas Slebodnik wrote: > On (11/12/15 15:42), Petr Cech wrote: > >Hi Lukas, > > > >I addressed your comments, see attachment. > > > >And I did a little investigation---if we use clang-format the ' \' on the end > >of lines are really vanished. It is good

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-14 Thread Jakub Hrozek
On Mon, Dec 14, 2015 at 10:36:05AM +0100, Jakub Hrozek wrote: > On Fri, Dec 11, 2015 at 05:02:01PM +0100, Lukas Slebodnik wrote: > > On (11/12/15 15:42), Petr Cech wrote: > > >Hi Lukas, > > > > > >I addressed your comments, see attachment. > > > > > >And I did a little investigation---if we use

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Jakub Hrozek
On Thu, Dec 10, 2015 at 01:39:42PM +0100, Petr Cech wrote: > On 12/10/2015 11:31 AM, Jakub Hrozek wrote: > >On Wed, Dec 09, 2015 at 02:25:06PM +0100, Petr Cech wrote: > >>Hi, > >> > >>simple patch is attached. > >> > >>Regards > >> > >>Petr > > > >I think we should put the debug message into

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Petr Cech
On 12/11/2015 11:56 AM, Jakub Hrozek wrote: On Thu, Dec 10, 2015 at 01:39:42PM +0100, Petr Cech wrote: On 12/10/2015 11:31 AM, Jakub Hrozek wrote: On Wed, Dec 09, 2015 at 02:25:06PM +0100, Petr Cech wrote: Hi, simple patch is attached. Regards Petr I think we should put the debug message

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Jakub Hrozek
On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote: > From 45754d761d6b549e4055f8af38a1229ad2689527 Mon Sep 17 00:00:00 2001 > From: Petr Cech > Date: Wed, 9 Dec 2015 08:13:59 -0500 > Subject: [PATCH] KRB5_CHILD: Debug logs for PAC timeout > > This patch adds debug

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Petr Cech
On 12/11/2015 12:46 PM, Jakub Hrozek wrote: On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote: From 45754d761d6b549e4055f8af38a1229ad2689527 Mon Sep 17 00:00:00 2001 From: Petr Cech Date: Wed, 9 Dec 2015 08:13:59 -0500 Subject: [PATCH] KRB5_CHILD: Debug logs for PAC

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Lukas Slebodnik
On (11/12/15 12:59), Petr Cech wrote: >On 12/11/2015 12:46 PM, Jakub Hrozek wrote: >>On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote: >>> From 45754d761d6b549e4055f8af38a1229ad2689527 Mon Sep 17 00:00:00 2001 >>>From: Petr Cech >>>Date: Wed, 9 Dec 2015 08:13:59 -0500

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Petr Cech
On 12/11/2015 03:13 PM, Lukas Slebodnik wrote: On (11/12/15 12:59), Petr Cech wrote: On 12/11/2015 12:46 PM, Jakub Hrozek wrote: On Fri, Dec 11, 2015 at 12:19:27PM +0100, Petr Cech wrote: From 897fd7a64770955a58c2dc7f71acdbf086477e8f Mon Sep 17 00:00:00 2001 From: Petr Cech

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-11 Thread Lukas Slebodnik
On (11/12/15 15:42), Petr Cech wrote: >Hi Lukas, > >I addressed your comments, see attachment. > >And I did a little investigation---if we use clang-format the ' \' on the end >of lines are really vanished. It is good news to everyone I hope. >I am afraid that it will be nearly impossible to say

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-10 Thread Jakub Hrozek
On Wed, Dec 09, 2015 at 02:25:06PM +0100, Petr Cech wrote: > Hi, > > simple patch is attached. > > Regards > > Petr I think we should put the debug message into sss_send_pac() after we actually succeeded in writing to the socket to avoid printing the message for cases where the PAC responder

[SSSD] Re: [PATCH] KRB5_CHILD: Debug logs for PAC timeout

2015-12-10 Thread Petr Cech
On 12/10/2015 11:31 AM, Jakub Hrozek wrote: On Wed, Dec 09, 2015 at 02:25:06PM +0100, Petr Cech wrote: Hi, simple patch is attached. Regards Petr I think we should put the debug message into sss_send_pac() after we actually succeeded in writing to the socket to avoid printing the message