[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-20 Thread Lukas Slebodnik
On (20/04/16 10:18), Pavel Březina wrote: >On 04/19/2016 08:18 AM, Petr Cech wrote: >> On 04/18/2016 04:04 PM, Petr Cech wrote: >> > On 04/15/2016 09:54 AM, Pavel Březina wrote: >> > > Hi, CI fails on debian: >> > > http://sssd-ci.duckdns.org/logs/job/41/53/debian_testing/ci.html >> > >> > Hi, >>

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-19 Thread Petr Cech
On 04/18/2016 04:04 PM, Petr Cech wrote: On 04/15/2016 09:54 AM, Pavel Březina wrote: Hi, CI fails on debian: http://sssd-ci.duckdns.org/logs/job/41/53/debian_testing/ci.html Hi, CI tests passed locally. Moderate CI tests passed too: http://sssd-ci.duckdns.org/logs/job/41/87/summary.html

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-18 Thread Petr Cech
On 04/15/2016 09:54 AM, Pavel Březina wrote: Hi, CI fails on debian: http://sssd-ci.duckdns.org/logs/job/41/53/debian_testing/ci.html Hi, CI tests passed locally. Moderate CI tests passed too: http://sssd-ci.duckdns.org/logs/job/41/87/summary.html And I have started rigorous CI tests

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-15 Thread Pavel Březina
On 04/14/2016 04:50 PM, Petr Cech wrote: On 04/13/2016 12:09 PM, Petr Cech wrote: On 04/12/2016 04:24 PM, Petr Cech wrote: Hi, I investigated the time issue with Pavel -- it is probably known DST issue [1]. [1] https://fedorahosted.org/sssd/ticket/2316#comment:1 Patch uses work out with big

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-14 Thread Petr Cech
On 04/13/2016 12:09 PM, Petr Cech wrote: On 04/12/2016 04:24 PM, Petr Cech wrote: Hi, I investigated the time issue with Pavel -- it is probably known DST issue [1]. [1] https://fedorahosted.org/sssd/ticket/2316#comment:1 Patch uses work out with big time shift. Hi, attached patch set

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-13 Thread Petr Cech
On 04/12/2016 04:24 PM, Petr Cech wrote: On 04/12/2016 01:27 PM, Pavel Březina wrote: On 04/06/2016 04:55 PM, Petr Cech wrote: On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-12 Thread Petr Cech
On 04/12/2016 01:27 PM, Pavel Březina wrote: On 04/06/2016 04:55 PM, Petr Cech wrote: On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak and they really test :-) It is possible

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-12 Thread Pavel Březina
On 04/06/2016 04:55 PM, Petr Cech wrote: On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak and they really test :-) It is possible to use compact form of them, maybe more help

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-04-06 Thread Petr Cech
On 03/31/2016 03:29 PM, Pavel Březina wrote: On 03/29/2016 03:17 PM, Petr Cech wrote: Hi, I am going to take three days of PTO. There is my work. Tests don't leak and they really test :-) It is possible to use compact form of them, maybe more help functions... But I hope that main idea is

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-31 Thread Pavel Březina
On 03/29/2016 03:17 PM, Petr Cech wrote: My big challenge is test_filter_rules_by_time(). I recognize that we don't have function for load sudo rule by name. I mean how to obtain struct sysdb_attrs *rule, for example by name of rule. If I understand it rigt, we just prepare filter and we say (in

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-29 Thread Petr Cech
On 03/21/2016 03:39 PM, Petr Cech wrote: On 03/16/2016 12:37 PM, Pavel Březina wrote: On 03/15/2016 04:40 PM, Petr Cech wrote: On 03/10/2016 02:36 PM, Pavel Březina wrote: [...] There is whole patch set attached. I worked on tests (003 patch) last couple days. I know that there are some

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-22 Thread Lukas Slebodnik
On (22/03/16 11:20), Pavel Březina wrote: >On 03/22/2016 11:05 AM, Lukas Slebodnik wrote: >>On (22/03/16 10:37), Pavel Březina wrote: >>>On 03/21/2016 02:06 PM, Lukas Slebodnik wrote: On (21/03/16 13:51), Pavel Březina wrote: >On 03/21/2016 01:10 PM, Lukas Slebodnik wrote: >>On

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-22 Thread Pavel Březina
On 03/22/2016 11:05 AM, Lukas Slebodnik wrote: On (22/03/16 10:37), Pavel Březina wrote: On 03/21/2016 02:06 PM, Lukas Slebodnik wrote: On (21/03/16 13:51), Pavel Březina wrote: On 03/21/2016 01:10 PM, Lukas Slebodnik wrote: On (21/03/16 11:02), Petr Cech wrote: On 03/16/2016 12:37 PM,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-22 Thread Lukas Slebodnik
On (22/03/16 10:37), Pavel Březina wrote: >On 03/21/2016 02:06 PM, Lukas Slebodnik wrote: >>On (21/03/16 13:51), Pavel Březina wrote: >>>On 03/21/2016 01:10 PM, Lukas Slebodnik wrote: On (21/03/16 11:02), Petr Cech wrote: >On 03/16/2016 12:37 PM, Pavel Březina wrote: > >[...] >

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-22 Thread Pavel Březina
On 03/21/2016 02:06 PM, Lukas Slebodnik wrote: On (21/03/16 13:51), Pavel Březina wrote: On 03/21/2016 01:10 PM, Lukas Slebodnik wrote: On (21/03/16 11:02), Petr Cech wrote: On 03/16/2016 12:37 PM, Pavel Březina wrote: [...] *Patch 2: SYSDB: Add new funtions into sysdb_sudo* +errno_t

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-21 Thread Petr Cech
On 03/16/2016 12:37 PM, Pavel Březina wrote: On 03/15/2016 04:40 PM, Petr Cech wrote: On 03/10/2016 02:36 PM, Pavel Březina wrote: [...] There is whole patch set attached. I worked on tests (003 patch) last couple days. I know that there are some test cases missing. My big challenge is

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-21 Thread Lukas Slebodnik
On (21/03/16 13:51), Pavel Březina wrote: >On 03/21/2016 01:10 PM, Lukas Slebodnik wrote: >>On (21/03/16 11:02), Petr Cech wrote: >>>On 03/16/2016 12:37 PM, Pavel Březina wrote: >>> >>>[...] >>> *Patch 2: SYSDB: Add new funtions into sysdb_sudo* >+errno_t

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-21 Thread Pavel Březina
On 03/21/2016 01:10 PM, Lukas Slebodnik wrote: On (21/03/16 11:02), Petr Cech wrote: On 03/16/2016 12:37 PM, Pavel Březina wrote: [...] *Patch 2: SYSDB: Add new funtions into sysdb_sudo* +errno_t +sysdb_set_sudo_rule_attr(struct sss_domain_info *domain, + const char

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-21 Thread Lukas Slebodnik
On (21/03/16 11:02), Petr Cech wrote: >On 03/16/2016 12:37 PM, Pavel Březina wrote: > >[...] > >>*Patch 2: SYSDB: Add new funtions into sysdb_sudo* >> >>>+errno_t >>>+sysdb_set_sudo_rule_attr(struct sss_domain_info *domain, >>>+ const char *name, >>>+

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-21 Thread Pavel Březina
On 03/21/2016 11:02 AM, Petr Cech wrote: On 03/16/2016 12:37 PM, Pavel Březina wrote: [...] *Patch 2: SYSDB: Add new funtions into sysdb_sudo* +errno_t +sysdb_set_sudo_rule_attr(struct sss_domain_info *domain, + const char *name, + struct

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-21 Thread Petr Cech
On 03/16/2016 12:37 PM, Pavel Březina wrote: [...] *Patch 2: SYSDB: Add new funtions into sysdb_sudo* +errno_t +sysdb_set_sudo_rule_attr(struct sss_domain_info *domain, + const char *name, + struct sysdb_attrs *attrs, +

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-19 Thread Pavel Březina
On 03/15/2016 04:40 PM, Petr Cech wrote: On 03/10/2016 02:36 PM, Pavel Březina wrote: On 03/09/2016 05:49 PM, Petr Cech wrote: On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-15 Thread Petr Cech
On 03/10/2016 02:36 PM, Pavel Březina wrote: On 03/09/2016 05:49 PM, Petr Cech wrote: On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I will

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-10 Thread Pavel Březina
On 03/09/2016 05:49 PM, Petr Cech wrote: On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I will address some suggestions tomorrow. I am doing tests

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-09 Thread Petr Cech
On 03/08/2016 05:57 PM, Petr Cech wrote: On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I will address some suggestions tomorrow. I am doing tests for sysdb_sudo_rules now. Thanks for

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-08 Thread Petr Cech
On 03/08/2016 05:09 PM, Pavel Reichl wrote: Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). I will address some suggestions tomorrow. I am doing tests for sysdb_sudo_rules now. Thanks for comments. Petr On 03/08/2016 01:11 PM,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-08 Thread Pavel Reichl
Hello Petr, I just run through the code and I have some code style suggestions, feel free to disagree :-). On 03/08/2016 01:11 PM, Petr Cech wrote: 0001-SYSDB-Add-new-funtions-into-sysdb_sudo.patch ... + +errno_t sysdb_search_sudo_rules(TALLOC_CTX *mem_ctx, +

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-08 Thread Petr Cech
On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-08 Thread Pavel Březina
On 03/07/2016 03:26 PM, Petr Cech wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: Hi, see comments inline. errno_t sysdb_search_sudo_rules(TALLOC_CTX *mem_ctx, struct sss_domain_info *domain, const char *sub_filter,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-08 Thread Petr Cech
On 03/07/2016 03:57 PM, Petr Cech wrote: On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: ret = sysdb_search_entry(mem_ctx, domain->sysdb, dn, LDB_SCOPE_SUBTREE, filter,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-07 Thread Petr Cech
On 03/07/2016 01:53 PM, Pavel Březina wrote: On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-07 Thread Petr Cech
On 03/07/2016 01:11 PM, Pavel Březina wrote: Hi, see comments inline. errno_t sysdb_search_sudo_rules(TALLOC_CTX *mem_ctx, struct sss_domain_info *domain, const char *sub_filter, const char **attrs,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-07 Thread Petr Cech
On 03/03/2016 02:15 PM, Pavel Březina wrote: On 03/03/2016 02:00 PM, Petr Cech wrote: Hi, I found an interesting thing. I wonder if this is a bug or not. I tried to write a test for sysdb_sudo_store() function: # src/db/sysdb_sudo.h errno_t sysdb_sudo_store (struct * sss_domain_info domain,

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-07 Thread Pavel Březina
On 03/07/2016 01:11 PM, Pavel Březina wrote: On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some, but there were troubles with memory leak.

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-07 Thread Pavel Březina
On 03/02/2016 05:04 PM, Petr Cech wrote: Hi all, attached two patches resolve [1]. This ticket has design page [2]. In my opinion it could be fine to have tests on sysdb_sudo. I have started write some, but there were troubles with memory leak. Maybe I haven't understood necessary logic

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-03 Thread Pavel Březina
On 03/03/2016 02:00 PM, Petr Cech wrote: Hi, I found an interesting thing. I wonder if this is a bug or not. I tried to write a test for sysdb_sudo_store() function: # src/db/sysdb_sudo.h errno_t sysdb_sudo_store (struct * sss_domain_info domain, struct sysdb_attrs ** rules, size_t num_rules);

[SSSD] Re: [PATCH SET] TOOL: Invalidation of sudo rules at sss_cache

2016-03-03 Thread Petr Cech
Hi, I found an interesting thing. I wonder if this is a bug or not. I tried to write a test for sysdb_sudo_store() function: # src/db/sysdb_sudo.h errno_t sysdb_sudo_store (struct * sss_domain_info domain, struct sysdb_attrs ** rules, size_t num_rules); As far as I see first parameter